| Message ID | 20220126225159.1567622-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/2] package/xvisor: drop ARM32 without virtualization support | expand |
On 26/01/2022 23:51, Fabrice Fontaine wrote: > Support for old 32-bit ARM boards (i.e. ARMv5, ARMv6, ARMv7a) without > virtualization has been dropped since > https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5 > resulting in the following build failure since bump to version 0.3.1 in > commit c4f8b8968770ecbf6444a5921c6472f126717626: > > *** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-3/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v6-defconfig"! > > *** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-0/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v7-defconfig"! > > As spotted by Thomas Petazzoni in > https://patchwork.ozlabs.org/project/buildroot/patch/20220125190650.107677-1-fontaine.fabrice@gmail.com, > "ARM32 cores that support the ARMv7ve instruction set are still > supported by Xvisor. This means that Cortex-A7, Cortex-A12, Cortex-A15 > and Cortex-A17, which are all ARM32 cores, are still supported" > > Fixes: > - http://autobuild.buildroot.org/results/1211bf6ff10c75815fa3ac320532fab5fe649a2b > - http://autobuild.buildroot.org/results/2bcbbb270df71d2489b7bc83e56c898c58cc90d2 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Both applied ot master, thanks. Regards, Arnout > --- > Changes v1 -> v2: > - Keep ARM32 with virtualization > > package/xvisor/Config.in | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/package/xvisor/Config.in b/package/xvisor/Config.in > index eb7475b86d..71628e633e 100644 > --- a/package/xvisor/Config.in > +++ b/package/xvisor/Config.in > @@ -1,9 +1,9 @@ > config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS > bool > - default y > + default y if BR2_aarch64 > + default y if BR2_cortex_a7 || BR2_cortex_a12 || BR2_cortex_a15 || BR2_cortex_a17 > + default y if BR2_x86_64 > depends on BR2_USE_MMU > - depends on BR2_arm || BR2_aarch64 || BR2_x86_64 > - depends on !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV7M > > menuconfig BR2_PACKAGE_XVISOR > bool "xvisor" > @@ -32,9 +32,7 @@ endchoice > > config BR2_PACKAGE_XVISOR_DEFCONFIG > string "Defconfig name" > - default "generic-v5" if BR2_ARM_CPU_ARMV5 > - default "generic-v6" if BR2_ARM_CPU_ARMV6 > - default "generic-v7" if BR2_ARM_CPU_ARMV7A > + default "generic-v7-ve" if BR2_ARM_CPU_ARMV7A > default "generic-v8" if BR2_aarch64 > default "x86_64_generic" if BR2_x86_64 > depends on BR2_PACKAGE_XVISOR_USE_DEFCONFIG
diff --git a/package/xvisor/Config.in b/package/xvisor/Config.in index eb7475b86d..71628e633e 100644 --- a/package/xvisor/Config.in +++ b/package/xvisor/Config.in @@ -1,9 +1,9 @@ config BR2_PACKAGE_XVISOR_ARCH_SUPPORTS bool - default y + default y if BR2_aarch64 + default y if BR2_cortex_a7 || BR2_cortex_a12 || BR2_cortex_a15 || BR2_cortex_a17 + default y if BR2_x86_64 depends on BR2_USE_MMU - depends on BR2_arm || BR2_aarch64 || BR2_x86_64 - depends on !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV7M menuconfig BR2_PACKAGE_XVISOR bool "xvisor" @@ -32,9 +32,7 @@ endchoice config BR2_PACKAGE_XVISOR_DEFCONFIG string "Defconfig name" - default "generic-v5" if BR2_ARM_CPU_ARMV5 - default "generic-v6" if BR2_ARM_CPU_ARMV6 - default "generic-v7" if BR2_ARM_CPU_ARMV7A + default "generic-v7-ve" if BR2_ARM_CPU_ARMV7A default "generic-v8" if BR2_aarch64 default "x86_64_generic" if BR2_x86_64 depends on BR2_PACKAGE_XVISOR_USE_DEFCONFIG
Support for old 32-bit ARM boards (i.e. ARMv5, ARMv6, ARMv7a) without virtualization has been dropped since https://github.com/xvisor/xvisor/commit/9fcd69692484e0f6aa5036c27196f55c797582c5 resulting in the following build failure since bump to version 0.3.1 in commit c4f8b8968770ecbf6444a5921c6472f126717626: *** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-3/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v6-defconfig"! *** Can't find default configuration "/home/giuliobenetti/autobuild/run/instance-0/output-1/build/xvisor-0.3.1/arch/arm/configs/generic-v7-defconfig"! As spotted by Thomas Petazzoni in https://patchwork.ozlabs.org/project/buildroot/patch/20220125190650.107677-1-fontaine.fabrice@gmail.com, "ARM32 cores that support the ARMv7ve instruction set are still supported by Xvisor. This means that Cortex-A7, Cortex-A12, Cortex-A15 and Cortex-A17, which are all ARM32 cores, are still supported" Fixes: - http://autobuild.buildroot.org/results/1211bf6ff10c75815fa3ac320532fab5fe649a2b - http://autobuild.buildroot.org/results/2bcbbb270df71d2489b7bc83e56c898c58cc90d2 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- Changes v1 -> v2: - Keep ARM32 with virtualization package/xvisor/Config.in | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)