diff mbox series

[2/2] package/gobject-introspection/Config.in: Allow RISCV_32 builds

Message ID 20210507170102.1896972-2-aduskett@rivian.com
State Accepted
Headers show
Series [1/2] package/qemu: bump version to 6.0.0 | expand

Commit Message

Adam Duskett May 7, 2021, 5:01 p.m. UTC
From: Adam Duskett <aduskett@gmail.com>

Qemu 6.0.0 no longer segfaults when running qemu-riscv32. As such, it's now
possible to allow riscv32 to compile gobject-introspection.

Fixes:
http://autobuild.buildroot.org/results/668397b1df42297505e6fc8353c4752290a5628d
Signed-off-by: Adam Duskett <aduskett@rivian.com>
---
 package/gobject-introspection/Config.in | 1 -
 1 file changed, 1 deletion(-)

Comments

Arnout Vandecappelle May 18, 2021, 8:36 p.m. UTC | #1
On 07/05/2021 19:01, Adam Duskett wrote:
> From: Adam Duskett <aduskett@gmail.com>
> 
> Qemu 6.0.0 no longer segfaults when running qemu-riscv32. As such, it's now
> possible to allow riscv32 to compile gobject-introspection.
> 
> Fixes:
> http://autobuild.buildroot.org/results/668397b1df42297505e6fc8353c4752290a5628d
> Signed-off-by: Adam Duskett <aduskett@rivian.com>

 Applied to next, thanks.

 However, this doesn't actually fix anything, so I rewrote part of the commit
message:

    package/gobject-introspection/Config.in: Allow RISCV_32 builds

    Qemu 6.0.0 no longer segfaults when running qemu-riscv32. As such, it's now
    possible to allow riscv32 to compile gobject-introspection.

    This partially reverts commit c94a212390e33c122cf9db4c772caf8bf3804565.
    The symbol BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS is kept, even
    though it is now equivalent to BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS,
    because it's likely that architecture dependencies will pop up again in
    the future.

    The configuration of a previously failing autobuilder [1] now passes.

    [1]
http://autobuild.buildroot.org/results/668397b1df42297505e6fc8353c4752290a5628d

    Signed-off-by: Adam Duskett <aduskett@rivian.com>
    Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> ---
>  package/gobject-introspection/Config.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/gobject-introspection/Config.in b/package/gobject-introspection/Config.in
> index 57c569704e..bacf44363c 100644
> --- a/package/gobject-introspection/Config.in
> +++ b/package/gobject-introspection/Config.in
> @@ -2,7 +2,6 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
>  	bool
>  	default y
>  	depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
> -	depends on !BR2_RISCV_32 # qemu-riscv32 segfaults in qemu-5.0.0
>  
>  config BR2_PACKAGE_GOBJECT_INTROSPECTION
>  	bool "gobject-introspection"
>
diff mbox series

Patch

diff --git a/package/gobject-introspection/Config.in b/package/gobject-introspection/Config.in
index 57c569704e..bacf44363c 100644
--- a/package/gobject-introspection/Config.in
+++ b/package/gobject-introspection/Config.in
@@ -2,7 +2,6 @@  config BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
 	bool
 	default y
 	depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
-	depends on !BR2_RISCV_32 # qemu-riscv32 segfaults in qemu-5.0.0
 
 config BR2_PACKAGE_GOBJECT_INTROSPECTION
 	bool "gobject-introspection"