diff mbox series

[1/1] package/quickjs: disable on nios2

Message ID 20210414212608.1376653-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/quickjs: disable on nios2 | expand

Commit Message

Fabrice Fontaine April 14, 2021, 9:26 p.m. UTC
quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on
nios2 since its addition in commit
5d50793659acb95050c110d5fc05399df20ce30b

Fixes:
 - http://autobuild.buildroot.org/results/69e280a7f478d1b16be989c7bd559f766053134b
 - http://autobuild.buildroot.org/results/f2c3ef7e3bbe30ac24710288336adabebd8b83a6

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/quickjs/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Arnout Vandecappelle April 15, 2021, 7:17 p.m. UTC | #1
On 14/04/2021 23:26, Fabrice Fontaine wrote:
> quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on
> nios2 since its addition in commit
> 5d50793659acb95050c110d5fc05399df20ce30b
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/69e280a7f478d1b16be989c7bd559f766053134b
>  - http://autobuild.buildroot.org/results/f2c3ef7e3bbe30ac24710288336adabebd8b83a6
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 Applied to master, thanks.

 Regards,
 Arnout

> ---
>  package/quickjs/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/quickjs/Config.in b/package/quickjs/Config.in
> index 5c3b068c3a..dc466241ba 100644
> --- a/package/quickjs/Config.in
> +++ b/package/quickjs/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_QUICKJS
>  	bool "quickjs"
> +	depends on !BR2_nios2 # fenv.h lacks FE_{DOWN,UP}WARD on nios2
>  	depends on !BR2_STATIC_LIBS
>  	# No way to check for fenv support.
>  	depends on !BR2_TOOLCHAIN_USES_UCLIBC
> @@ -14,6 +15,7 @@ config BR2_PACKAGE_QUICKJS
>  	  https://bellard.org/quickjs/
>  
>  comment "quickjs needs a glibc or musl toolchain w/ gcc >= 4.9, host gcc >= 4.9, dynamic library"
> +	depends on !BR2_nios2
>  	depends on BR2_USE_MMU
>  	depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_UCLIBC || \
>  		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_HOST_GCC_AT_LEAST_4_9
>
Peter Korsgaard April 25, 2021, 7:21 a.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on
 > nios2 since its addition in commit
 > 5d50793659acb95050c110d5fc05399df20ce30b

 > Fixes:
 >  - http://autobuild.buildroot.org/results/69e280a7f478d1b16be989c7bd559f766053134b
 >  - http://autobuild.buildroot.org/results/f2c3ef7e3bbe30ac24710288336adabebd8b83a6

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.02.x, thanks.
diff mbox series

Patch

diff --git a/package/quickjs/Config.in b/package/quickjs/Config.in
index 5c3b068c3a..dc466241ba 100644
--- a/package/quickjs/Config.in
+++ b/package/quickjs/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_QUICKJS
 	bool "quickjs"
+	depends on !BR2_nios2 # fenv.h lacks FE_{DOWN,UP}WARD on nios2
 	depends on !BR2_STATIC_LIBS
 	# No way to check for fenv support.
 	depends on !BR2_TOOLCHAIN_USES_UCLIBC
@@ -14,6 +15,7 @@  config BR2_PACKAGE_QUICKJS
 	  https://bellard.org/quickjs/
 
 comment "quickjs needs a glibc or musl toolchain w/ gcc >= 4.9, host gcc >= 4.9, dynamic library"
+	depends on !BR2_nios2
 	depends on BR2_USE_MMU
 	depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_UCLIBC || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_HOST_GCC_AT_LEAST_4_9