diff mbox series

boot/at91bootstrap: add legal information

Message ID 20210405153249.1352356-1-thomas.petazzoni@bootlin.com
State New
Headers show
Series boot/at91bootstrap: add legal information | expand

Commit Message

Thomas Petazzoni April 5, 2021, 3:32 p.m. UTC
The old at91bootstrap version (1.x) uses a strange variant of the BSD
license, called "BSD Source Code Attribution" and referenced by SPDX
as BSD-Source-Code.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 boot/at91bootstrap/at91bootstrap.hash | 1 +
 boot/at91bootstrap/at91bootstrap.mk   | 2 ++
 2 files changed, 3 insertions(+)

Comments

Peter Korsgaard April 5, 2021, 4:37 p.m. UTC | #1
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > The old at91bootstrap version (1.x) uses a strange variant of the BSD
 > license, called "BSD Source Code Attribution" and referenced by SPDX
 > as BSD-Source-Code.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > ---
 >  boot/at91bootstrap/at91bootstrap.hash | 1 +
 >  boot/at91bootstrap/at91bootstrap.mk   | 2 ++
 >  2 files changed, 3 insertions(+)

 > diff --git a/boot/at91bootstrap/at91bootstrap.hash b/boot/at91bootstrap/at91bootstrap.hash
 > index b1f963b825..e4a6760f12 100644
 > --- a/boot/at91bootstrap/at91bootstrap.hash
 > +++ b/boot/at91bootstrap/at91bootstrap.hash
 > @@ -1,2 +1,3 @@
 >  # locally computed
 >  sha256  d66192a274247f4baa39fa932eadf903d7add55641d89d30402f967c4f2282a5  AT91Bootstrap1.16.zip
 > +sha256  cb53ea8cf7a54929944de5de10569f51068af4f6d63ddfe8735759bdd8cebf38  main.c
 > diff --git a/boot/at91bootstrap/at91bootstrap.mk b/boot/at91bootstrap/at91bootstrap.mk
 > index c68b56b6ec..001427855f 100644
 > --- a/boot/at91bootstrap/at91bootstrap.mk
 > +++ b/boot/at91bootstrap/at91bootstrap.mk
 > @@ -7,6 +7,8 @@
 >  AT91BOOTSTRAP_VERSION = 1.16
 >  AT91BOOTSTRAP_SITE = ftp://www.at91.com/pub/at91bootstrap
 >  AT91BOOTSTRAP_SOURCE = AT91Bootstrap$(AT91BOOTSTRAP_VERSION).zip
 > +AT91BOOTSTRAP_LICENSE = BSD-Source-Code
 > +AT91BOOTSTRAP_LICENSE_FILES = main.c

Hmm, this doesn't work very well if someone patches main.c :/ But OK, I
don't really know how common that is / what to do about it.
Alexander Dahl April 5, 2021, 6:37 p.m. UTC | #2
Hei hei,

On Mon, Apr 05, 2021 at 06:37:43PM +0200, Peter Korsgaard wrote:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> 
>  > The old at91bootstrap version (1.x) uses a strange variant of the BSD
>  > license, called "BSD Source Code Attribution" and referenced by SPDX
>  > as BSD-Source-Code.
> 
>  > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>  > ---
>  >  boot/at91bootstrap/at91bootstrap.hash | 1 +
>  >  boot/at91bootstrap/at91bootstrap.mk   | 2 ++
>  >  2 files changed, 3 insertions(+)
> 
>  > diff --git a/boot/at91bootstrap/at91bootstrap.hash b/boot/at91bootstrap/at91bootstrap.hash
>  > index b1f963b825..e4a6760f12 100644
>  > --- a/boot/at91bootstrap/at91bootstrap.hash
>  > +++ b/boot/at91bootstrap/at91bootstrap.hash
>  > @@ -1,2 +1,3 @@
>  >  # locally computed
>  >  sha256  d66192a274247f4baa39fa932eadf903d7add55641d89d30402f967c4f2282a5  AT91Bootstrap1.16.zip
>  > +sha256  cb53ea8cf7a54929944de5de10569f51068af4f6d63ddfe8735759bdd8cebf38  main.c
>  > diff --git a/boot/at91bootstrap/at91bootstrap.mk b/boot/at91bootstrap/at91bootstrap.mk
>  > index c68b56b6ec..001427855f 100644
>  > --- a/boot/at91bootstrap/at91bootstrap.mk
>  > +++ b/boot/at91bootstrap/at91bootstrap.mk
>  > @@ -7,6 +7,8 @@
>  >  AT91BOOTSTRAP_VERSION = 1.16
>  >  AT91BOOTSTRAP_SITE = ftp://www.at91.com/pub/at91bootstrap
>  >  AT91BOOTSTRAP_SOURCE = AT91Bootstrap$(AT91BOOTSTRAP_VERSION).zip
>  > +AT91BOOTSTRAP_LICENSE = BSD-Source-Code
>  > +AT91BOOTSTRAP_LICENSE_FILES = main.c
> 
> Hmm, this doesn't work very well if someone patches main.c :/ But OK, I
> don't really know how common that is / what to do about it.

Two remarks here:

1) atbootstrap 1.16 seems to be the final version, no updates anymore.
However patching is likely for someone with a certain combination
board and soc not supported out of the box.

2) in ptxdist license information or let's say hashes for license
texts for packages not shipping a separate
license file is frequently based on comment sections in source files,
but not based on the whole file but on the comment section only. The
packages contain information on which file and _from_ which line _to_
which line. Only those lines containing the license information are
extracted and hashed, making it possible to patch the file. Maybe
that's an idea to copy?

Greets
Alex
Thomas Petazzoni April 5, 2021, 6:43 p.m. UTC | #3
On Mon, 05 Apr 2021 18:37:43 +0200
Peter Korsgaard <peter@korsgaard.com> wrote:

>  >  AT91BOOTSTRAP_VERSION = 1.16
>  >  AT91BOOTSTRAP_SITE = ftp://www.at91.com/pub/at91bootstrap
>  >  AT91BOOTSTRAP_SOURCE = AT91Bootstrap$(AT91BOOTSTRAP_VERSION).zip
>  > +AT91BOOTSTRAP_LICENSE = BSD-Source-Code
>  > +AT91BOOTSTRAP_LICENSE_FILES = main.c  
> 
> Hmm, this doesn't work very well if someone patches main.c :/ But OK, I
> don't really know how common that is / what to do about it.

As Alexander pointed out, at91bootstrap (in this 1.x branch) is no
longer developed, so main.c will never be changed :)

Thomas
Peter Korsgaard April 5, 2021, 7:07 p.m. UTC | #4
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Mon, 05 Apr 2021 18:37:43 +0200
 > Peter Korsgaard <peter@korsgaard.com> wrote:

 >> >  AT91BOOTSTRAP_VERSION = 1.16
 >> >  AT91BOOTSTRAP_SITE = ftp://www.at91.com/pub/at91bootstrap
 >> >  AT91BOOTSTRAP_SOURCE = AT91Bootstrap$(AT91BOOTSTRAP_VERSION).zip
 >> > +AT91BOOTSTRAP_LICENSE = BSD-Source-Code
 >> > +AT91BOOTSTRAP_LICENSE_FILES = main.c  
 >> 
 >> Hmm, this doesn't work very well if someone patches main.c :/ But OK, I
 >> don't really know how common that is / what to do about it.

 > As Alexander pointed out, at91bootstrap (in this 1.x branch) is no
 > longer developed, so main.c will never be changed :)

"Never" is probably a bit too strong. I know I have done it in the past,
and there's even a bootlin blog entry about doing it ;)

https://bootlin.com/blog/at91bootstrap-linux/
Thomas Petazzoni April 5, 2021, 7:19 p.m. UTC | #5
On Mon, 05 Apr 2021 21:07:53 +0200
Peter Korsgaard <peter@korsgaard.com> wrote:

> "Never" is probably a bit too strong. I know I have done it in the past,
> and there's even a bootlin blog entry about doing it ;)
> 
> https://bootlin.com/blog/at91bootstrap-linux/

Fair enough :-)

Then we could use include/sdramc.h, which is even smaller, and less
likely to be changed. Let me know if that makes sense, or if you're
fine with keeping main.c.

Thomas
Peter Korsgaard April 5, 2021, 7:22 p.m. UTC | #6
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Mon, 05 Apr 2021 21:07:53 +0200
 > Peter Korsgaard <peter@korsgaard.com> wrote:

 >> "Never" is probably a bit too strong. I know I have done it in the past,
 >> and there's even a bootlin blog entry about doing it ;)
 >> 
 >> https://bootlin.com/blog/at91bootstrap-linux/

 > Fair enough :-)

;)

 > Then we could use include/sdramc.h, which is even smaller, and less
 > likely to be changed. Let me know if that makes sense, or if you're
 > fine with keeping main.c.

Given that we have 2 examples of people changing main.c, I would indeed
prefer to to use sdramc.h instead.
diff mbox series

Patch

diff --git a/boot/at91bootstrap/at91bootstrap.hash b/boot/at91bootstrap/at91bootstrap.hash
index b1f963b825..e4a6760f12 100644
--- a/boot/at91bootstrap/at91bootstrap.hash
+++ b/boot/at91bootstrap/at91bootstrap.hash
@@ -1,2 +1,3 @@ 
 # locally computed
 sha256  d66192a274247f4baa39fa932eadf903d7add55641d89d30402f967c4f2282a5  AT91Bootstrap1.16.zip
+sha256  cb53ea8cf7a54929944de5de10569f51068af4f6d63ddfe8735759bdd8cebf38  main.c
diff --git a/boot/at91bootstrap/at91bootstrap.mk b/boot/at91bootstrap/at91bootstrap.mk
index c68b56b6ec..001427855f 100644
--- a/boot/at91bootstrap/at91bootstrap.mk
+++ b/boot/at91bootstrap/at91bootstrap.mk
@@ -7,6 +7,8 @@ 
 AT91BOOTSTRAP_VERSION = 1.16
 AT91BOOTSTRAP_SITE = ftp://www.at91.com/pub/at91bootstrap
 AT91BOOTSTRAP_SOURCE = AT91Bootstrap$(AT91BOOTSTRAP_VERSION).zip
+AT91BOOTSTRAP_LICENSE = BSD-Source-Code
+AT91BOOTSTRAP_LICENSE_FILES = main.c
 
 AT91BOOTSTRAP_BOARD = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP_BOARD))
 AT91BOOTSTRAP_MEMORY = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP_MEMORY))