| Message ID | 20210303172019.931457-2-fontaine.fabrice@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] package/sconeserver: drop unrecognized options | expand |
Hello Fabrice, On Wed, 3 Mar 2021 18:20:19 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > pcre is optional not mandatory since > https://github.com/sconemad/sconeserver/commit/98ec61436c9ea68ffe2d70a818c1175dcafa2a79 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/sconeserver/sconeserver.mk | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/package/sconeserver/sconeserver.mk b/package/sconeserver/sconeserver.mk > index b81134002e..62cc128d77 100644 > --- a/package/sconeserver/sconeserver.mk > +++ b/package/sconeserver/sconeserver.mk > @@ -10,7 +10,10 @@ SCONESERVER_LICENSE = GPL-2.0+ > SCONESERVER_LICENSE_FILES = COPYING > # fetching from Git, we need to generate the configure script > SCONESERVER_AUTORECONF = YES > -SCONESERVER_DEPENDENCIES = host-pkgconf pcre zlib > +SCONESERVER_DEPENDENCIES = \ > + host-pkgconf \ > + $(if $(BR2_PACKAGE_PCRE),pcre) \ Remove of 'select BR2_PACKAGE_PCRE' from Config.in missing? Regards, Peter > + zlib > # disable markdown module because its git submodule cmark > # https://github.com/sconemad/sconeserver/tree/master/markdown > # has no cross-compile support provided by the sconeserver build system
Hi Peter, Le mer. 3 mars 2021 à 18:54, Peter Seiderer <ps.report@gmx.net> a écrit : > > Hello Fabrice, > > On Wed, 3 Mar 2021 18:20:19 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > > > pcre is optional not mandatory since > > https://github.com/sconemad/sconeserver/commit/98ec61436c9ea68ffe2d70a818c1175dcafa2a79 > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > --- > > package/sconeserver/sconeserver.mk | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/package/sconeserver/sconeserver.mk b/package/sconeserver/sconeserver.mk > > index b81134002e..62cc128d77 100644 > > --- a/package/sconeserver/sconeserver.mk > > +++ b/package/sconeserver/sconeserver.mk > > @@ -10,7 +10,10 @@ SCONESERVER_LICENSE = GPL-2.0+ > > SCONESERVER_LICENSE_FILES = COPYING > > # fetching from Git, we need to generate the configure script > > SCONESERVER_AUTORECONF = YES > > -SCONESERVER_DEPENDENCIES = host-pkgconf pcre zlib > > +SCONESERVER_DEPENDENCIES = \ > > + host-pkgconf \ > > + $(if $(BR2_PACKAGE_PCRE),pcre) \ > > Remove of 'select BR2_PACKAGE_PCRE' from Config.in missing? Indeed, thanks, I'll send a v2. > > Regards, > Peter > > > + zlib > > # disable markdown module because its git submodule cmark > > # https://github.com/sconemad/sconeserver/tree/master/markdown > > # has no cross-compile support provided by the sconeserver build system > Best Regards, Fabrice
diff --git a/package/sconeserver/sconeserver.mk b/package/sconeserver/sconeserver.mk index b81134002e..62cc128d77 100644 --- a/package/sconeserver/sconeserver.mk +++ b/package/sconeserver/sconeserver.mk @@ -10,7 +10,10 @@ SCONESERVER_LICENSE = GPL-2.0+ SCONESERVER_LICENSE_FILES = COPYING # fetching from Git, we need to generate the configure script SCONESERVER_AUTORECONF = YES -SCONESERVER_DEPENDENCIES = host-pkgconf pcre zlib +SCONESERVER_DEPENDENCIES = \ + host-pkgconf \ + $(if $(BR2_PACKAGE_PCRE),pcre) \ + zlib # disable markdown module because its git submodule cmark # https://github.com/sconemad/sconeserver/tree/master/markdown # has no cross-compile support provided by the sconeserver build system
pcre is optional not mandatory since https://github.com/sconemad/sconeserver/commit/98ec61436c9ea68ffe2d70a818c1175dcafa2a79 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/sconeserver/sconeserver.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)