diff mbox series

[1/1] package/sysklogd: needs threads

Message ID 20210120173803.90884-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/sysklogd: needs threads | expand

Commit Message

Fabrice Fontaine Jan. 20, 2021, 5:38 p.m. UTC
threads is mandatory since version 2.0 and
https://github.com/troglobit/sysklogd/commit/f6e17bd6b30397912dcae33842b7aba8d32710a2

Fixes:
 - http://autobuild.buildroot.org/results/33846ba0c6746c2befcd3c3ce0bbe0c5b32669ed

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/sysklogd/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Joachim Wiberg Jan. 21, 2021, 12:45 p.m. UTC | #1
On Wed, Jan 20, 2021 at 18:38, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> threads is mandatory since version 2.0 and
> https://github.com/troglobit/sysklogd/commit/f6e17bd6b30397912dcae33842b7aba8d32710a2

Had completely forgotten about that mutex, thanks for fixing this!

> Fixes:
>  - http://autobuild.buildroot.org/results/33846ba0c6746c2befcd3c3ce0bbe0c5b32669ed

I love the autobuilders :)

There should be a link from the front page to them (and perhaps a
redirect from https to http). 

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Acked-by: Joachim Wiberg <troglobit@gmail.com>
Yann E. MORIN Jan. 21, 2021, 9:30 p.m. UTC | #2
Fabrice, All,

On 2021-01-20 18:38 +0100, Fabrice Fontaine spake thusly:
> threads is mandatory since version 2.0 and
> https://github.com/troglobit/sysklogd/commit/f6e17bd6b30397912dcae33842b7aba8d32710a2
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/33846ba0c6746c2befcd3c3ce0bbe0c5b32669ed
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, with dependencies reordered;
    https://buildroot.org/downloads/manual/manual.html#_config_files

Thanks.

Regards,
Yann E. MORIN.

> ---
>  package/sysklogd/Config.in | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/sysklogd/Config.in b/package/sysklogd/Config.in
> index 18aff091c0..f4609f8297 100644
> --- a/package/sysklogd/Config.in
> +++ b/package/sysklogd/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_SYSKLOGD
>  	bool "sysklogd"
>  	depends on BR2_USE_MMU # fork()
>  	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	help
>  	  The continuation of the original sysklogd package, based on
>  	  the original Berkeley syslog daemon. Now with kernel
> @@ -11,3 +12,8 @@ config BR2_PACKAGE_SYSKLOGD
>  	  clients.
>  
>  	  https://github.com/troglobit/sysklogd/
> +
> +comment "sysklogd needs a toolchain w/ threads"
> +	depends on BR2_USE_MMU
> +	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> -- 
> 2.29.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/sysklogd/Config.in b/package/sysklogd/Config.in
index 18aff091c0..f4609f8297 100644
--- a/package/sysklogd/Config.in
+++ b/package/sysklogd/Config.in
@@ -2,6 +2,7 @@  config BR2_PACKAGE_SYSKLOGD
 	bool "sysklogd"
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  The continuation of the original sysklogd package, based on
 	  the original Berkeley syslog daemon. Now with kernel
@@ -11,3 +12,8 @@  config BR2_PACKAGE_SYSKLOGD
 	  clients.
 
 	  https://github.com/troglobit/sysklogd/
+
+comment "sysklogd needs a toolchain w/ threads"
+	depends on BR2_USE_MMU
+	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS