diff mbox series

[v4,3/8] package/freescale-imx/firmware-imx: Copy of all DDR files if uboot needs fw.

Message ID 20201125183017.15585-4-xroumegue@gmail.com
State Changes Requested
Headers show
Series [v3,1/8] package/freescale-imx/firmware-imx: Add option to install all ddr fw files | expand

Commit Message

Xavier Roumegue Nov. 25, 2020, 6:30 p.m. UTC 
Signed-off-by: Xavier Roumegue <xroumegue@gmail.com>
---
 package/freescale-imx/firmware-imx/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Heiko Thiery Dec. 14, 2020, 10:27 p.m. UTC | #1 
Hi Xavier,

Am Mi., 25. Nov. 2020 um 19:31 Uhr schrieb Xavier Roumegue
<xroumegue@gmail.com>:
>
> Signed-off-by: Xavier Roumegue <xroumegue@gmail.com>

Tested-by: Heiko Thiery <heiko.thiery@gmail.com>

> ---
>  package/freescale-imx/firmware-imx/Config.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/freescale-imx/firmware-imx/Config.in b/package/freescale-imx/firmware-imx/Config.in
> index 09ccacb0c1..c704d78637 100644
> --- a/package/freescale-imx/firmware-imx/Config.in
> +++ b/package/freescale-imx/firmware-imx/Config.in
> @@ -83,6 +83,7 @@ config BR2_PACKAGE_FIRMWARE_IMX_DMEM_LEN
>
>  config BR2_PACKAGE_FIRMWARE_IMX_DDR_FW_MULTIPLE
>         bool
> +       default y if BR2_TARGET_UBOOT_NEEDS_FW
>
>  endif # BR2_PACKAGE_FIRMWARE_IMX_NEEDS_DDR_FW
>
Thomas Petazzoni Jan. 23, 2021, 10:33 p.m. UTC | #2 
On Wed, 25 Nov 2020 19:30:12 +0100
Xavier Roumegue <xroumegue@gmail.com> wrote:

> Signed-off-by: Xavier Roumegue <xroumegue@gmail.com>
> ---
>  package/freescale-imx/firmware-imx/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/freescale-imx/firmware-imx/Config.in b/package/freescale-imx/firmware-imx/Config.in
> index 09ccacb0c1..c704d78637 100644
> --- a/package/freescale-imx/firmware-imx/Config.in
> +++ b/package/freescale-imx/firmware-imx/Config.in
> @@ -83,6 +83,7 @@ config BR2_PACKAGE_FIRMWARE_IMX_DMEM_LEN
>  
>  config BR2_PACKAGE_FIRMWARE_IMX_DDR_FW_MULTIPLE
>  	bool
> +	default y if BR2_TARGET_UBOOT_NEEDS_FW

See my proposal on PATCH 2/8, which makes this change unnecessary.

Thomas
diff mbox series

Patch

diff --git a/package/freescale-imx/firmware-imx/Config.in b/package/freescale-imx/firmware-imx/Config.in
index 09ccacb0c1..c704d78637 100644
--- a/package/freescale-imx/firmware-imx/Config.in
+++ b/package/freescale-imx/firmware-imx/Config.in
@@ -83,6 +83,7 @@  config BR2_PACKAGE_FIRMWARE_IMX_DMEM_LEN
 
 config BR2_PACKAGE_FIRMWARE_IMX_DDR_FW_MULTIPLE
 	bool
+	default y if BR2_TARGET_UBOOT_NEEDS_FW
 
 endif # BR2_PACKAGE_FIRMWARE_IMX_NEEDS_DDR_FW