diff mbox series

[1/2] wlroots: package does not require locale support

Message ID 20201122160008.44129-1-paul@crapouillou.net
State Accepted
Headers show
Series [1/2] wlroots: package does not require locale support | expand

Commit Message

Paul Cercueil Nov. 22, 2020, 4 p.m. UTC
Drop dependency on BR2_ENABLE_LOCALE, which was marked as a dependency
of libinput which is selected by wlroots. However, libinput does not
depend at all on BR2_ENABLE_LOCALE.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 package/wlroots/Config.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Thomas Petazzoni Nov. 22, 2020, 8:21 p.m. UTC | #1
On Sun, 22 Nov 2020 16:00:07 +0000
Paul Cercueil <paul@crapouillou.net> wrote:

> Drop dependency on BR2_ENABLE_LOCALE, which was marked as a dependency
> of libinput which is selected by wlroots. However, libinput does not
> depend at all on BR2_ENABLE_LOCALE.

The dependency of libinput on BR2_ENABLE_LOCALE was dropped in commit
bef6b92b67e08ee8cba085ae95af7e94e7a28202.

Best regards,

Thomas
Peter Korsgaard Nov. 23, 2020, 9:39 p.m. UTC | #2
>>>>> "Paul" == Paul Cercueil <paul@crapouillou.net> writes:

 > Drop dependency on BR2_ENABLE_LOCALE, which was marked as a dependency
 > of libinput which is selected by wlroots. However, libinput does not
 > depend at all on BR2_ENABLE_LOCALE.

 > Signed-off-by: Paul Cercueil <paul@crapouillou.net>

Committed after extending the commit message to explain when libinput
lost its locale dependency as suggested by Thomas, thanks.
Peter Korsgaard Dec. 11, 2020, 10:34 a.m. UTC | #3
>>>>> "Paul" == Paul Cercueil <paul@crapouillou.net> writes:

 > Drop dependency on BR2_ENABLE_LOCALE, which was marked as a dependency
 > of libinput which is selected by wlroots. However, libinput does not
 > depend at all on BR2_ENABLE_LOCALE.

 > Signed-off-by: Paul Cercueil <paul@crapouillou.net>

Committed to 2020.08.x, thanks.
diff mbox series

Patch

diff --git a/package/wlroots/Config.in b/package/wlroots/Config.in
index eb4c4725ac..2f72fd4945 100644
--- a/package/wlroots/Config.in
+++ b/package/wlroots/Config.in
@@ -3,16 +3,14 @@  comment "wlroots needs udev, mesa3d w/ EGL and GLES support"
 		!BR2_PACKAGE_MESA3D_OPENGL_ES || \
 		!BR2_PACKAGE_HAS_UDEV
 
-comment "wlroots needs a toolchain w/ threads, locale, dynamic library"
+comment "wlroots needs a toolchain w/ threads, dynamic library"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_ENABLE_LOCALE || \
 		BR2_STATIC_LIBS
 
 config BR2_PACKAGE_WLROOTS
 	bool "wlroots"
 	depends on !BR2_STATIC_LIBS # wayland
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm, wayland
-	depends on BR2_ENABLE_LOCALE # libinput
 	depends on BR2_PACKAGE_HAS_UDEV # libinput
 	# Technically wlroots should work with any OpenGL implementation
 	# which provides EGL, GLES2, and libgbm; but in practice only