diff mbox series

[1/1] utils/getdeveloperlib.py: fix issue with hasfile()

Message ID 20201113140627.6097-1-heiko.thiery@gmail.com
State Accepted
Headers show
Series [1/1] utils/getdeveloperlib.py: fix issue with hasfile() | expand

Commit Message

Heiko Thiery Nov. 13, 2020, 2:06 p.m. UTC
pkg-stats is not able anymore to set the developers for defconfigs and
packages. This issue is introduced with
ae86067a151b6596ca492d6f94ed513f4f8e18d7. The hasfile() method from
Developer object tries to check an absolute path against a relative path.

Convert the filepath to be checked also into an absolute path.

Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 utils/getdeveloperlib.py | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard Nov. 17, 2020, 10:49 p.m. UTC | #1
>>>>> "Heiko" == Heiko Thiery <heiko.thiery@gmail.com> writes:

 > pkg-stats is not able anymore to set the developers for defconfigs and
 > packages. This issue is introduced with
 > ae86067a151b6596ca492d6f94ed513f4f8e18d7. The hasfile() method from
 > Developer object tries to check an absolute path against a relative path.

 > Convert the filepath to be checked also into an absolute path.

 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

I know that Thomas has some pending patches to clean this up more, but
this is a trivial change and fixes the immediate issue, so committed,
thanks.
diff mbox series

Patch

diff --git a/utils/getdeveloperlib.py b/utils/getdeveloperlib.py
index dc0cc07cc7..f57f41887b 100644
--- a/utils/getdeveloperlib.py
+++ b/utils/getdeveloperlib.py
@@ -126,6 +126,7 @@  class Developer:
     def hasfile(self, f):
         f = os.path.abspath(f)
         for fs in self.files:
+            fs = os.path.abspath(fs)
             if f.startswith(fs):
                 return True
         return False