diff mbox series

[7/8] package/optee-test: add deps on openssl when enabled

Message ID 20201030075045.6960-7-etienne.carriere@linaro.org
State New
Headers show
Series [1/8] configs/qemu_arm_vexpress_tz_defconfig: enable CXX toolchain | expand

Commit Message

Etienne Carriere Oct. 30, 2020, 7:50 a.m. UTC
Add a dependency on openssl upon BR2_PACKAGE_LIBOPENSSL=y to
enable some for OP-TEE embedded tests.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
---
 package/optee-test/optee-test.mk | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thomas Petazzoni Oct. 31, 2020, 9:46 p.m. UTC | #1
Hello √Čtienne,

On Fri, 30 Oct 2020 08:50:44 +0100
Etienne Carriere <etienne.carriere@linaro.org> wrote:

>  OPTEE_TEST_DEPENDENCIES = optee-client optee-os
> +ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)

Is it intentional that the dependency is on BR2_PACKAGE_LIBOPENSSL and
not BR2_PACKAGE_OPENSSL ?

If you use BR2_PACKAGE_OPENSSL, it means that either openssl or
libressl can be used. If you use BR2_PACKAGE_LIBOPENSSL, then it means
that you really only support working with openssl.

Normally, libressl is a drop-in replacement for openssl, so it does
work just like openssl in most cases. There are however a few OpenSSL
APIs that are no longer supported in LibreSSL.

Could you clarify this point ?

Thanks,

Thomas
Etienne Carriere Nov. 2, 2020, 8:08 a.m. UTC | #2
Hello Thomas,

On Sat, 31 Oct 2020 at 22:46, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello √Čtienne,
>
> On Fri, 30 Oct 2020 08:50:44 +0100
> Etienne Carriere <etienne.carriere@linaro.org> wrote:
>
> >  OPTEE_TEST_DEPENDENCIES = optee-client optee-os
> > +ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)
>
> Is it intentional that the dependency is on BR2_PACKAGE_LIBOPENSSL and
> not BR2_PACKAGE_OPENSSL ?
>
> If you use BR2_PACKAGE_OPENSSL, it means that either openssl or
> libressl can be used. If you use BR2_PACKAGE_LIBOPENSSL, then it means
> that you really only support working with openssl.
>
> Normally, libressl is a drop-in replacement for openssl, so it does
> work just like openssl in most cases. There are however a few OpenSSL
> APIs that are no longer supported in LibreSSL.
>
> Could you clarify this point ?

Thanks for highlighting this. Indeed, constraining to libopenssl was
not intentional.

I've checked. From my reading, I would think optee-test uses standard
stuff from openssl that libressl supports but
testing here with libressl makes the optee-test test tool fail on a
certificate test.
I guess this should be investigated from the optee project scope.
As for now I'd rather stick to BR2_PACKAGE_LIBOPENSSL dependency here
as this change proposes.

Regards,
Etienne




>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
diff mbox series

Patch

diff --git a/package/optee-test/optee-test.mk b/package/optee-test/optee-test.mk
index 1f4f586672..189956651b 100644
--- a/package/optee-test/optee-test.mk
+++ b/package/optee-test/optee-test.mk
@@ -10,6 +10,9 @@  OPTEE_TEST_LICENSE = GPL-2.0, BSD-2-Clause,
 OPTEE_TEST_LICENSE_FILES = LICENSE.md
 
 OPTEE_TEST_DEPENDENCIES = optee-client optee-os
+ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)
+OPTEE_TEST_DEPENDENCIES += openssl
+endif
 
 OPTEE_TEST_CONF_OPTS = -DOPTEE_TEST_SDK=$(OPTEE_OS_SDK)