diff mbox series

[2/3] package/libabseil-cpp: depend on gcc >= 4.9

Message ID 20201027174046.17157-3-buildroot@heine.tech
State Changes Requested
Headers show
Series fix libabseil-cpp build on older gcc versions | expand

Commit Message

Michael Nosthoff Oct. 27, 2020, 5:40 p.m. UTC 
From: Michael Nosthoff <buildroot@heine.tech>

abseil depends on gcc >= 4.9

https://abseil.io/docs/cpp/platforms/platforms#linux

Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
---
 package/libabseil-cpp/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni Oct. 29, 2020, 10:36 p.m. UTC | #1 
On Tue, 27 Oct 2020 18:40:45 +0100
Michael Nosthoff via buildroot <buildroot@busybox.net> wrote:

> From: Michael Nosthoff <buildroot@heine.tech>
> 
> abseil depends on gcc >= 4.9
> 
> https://abseil.io/docs/cpp/platforms/platforms#linux
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

Is this fixing a build issue ? If so, is this issue reported in the
autobuilders ? If it's not fixing a build issue, what is the
reason/intention behind this change ?

Thanks,

Thomas
Michael Nosthoff Oct. 30, 2020, 7:48 a.m. UTC | #2 
Hi,

On Thursday, October 29, 2020 23:36 CET, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: 

> 
> Is this fixing a build issue ? If so, is this issue reported in the
> autobuilders ? If it's not fixing a build issue, what is the
> reason/intention behind this change ?
> 

The build with 4.8 still fails after applying the first patch of this series. As this is shadowed by the C++11 error it doesn't turn up in the autobuilders.
Should I just include a build error output into the commit?

Regards,
Michael
Thomas Petazzoni Oct. 30, 2020, 8:16 a.m. UTC | #3 
Hello,

On Fri, 30 Oct 2020 08:48:17 +0100
"Michael Nosthoff" <buildroot@heine.tech> wrote:

> The build with 4.8 still fails after applying the first patch of this
> series. As this is shadowed by the C++11 error it doesn't turn up in
> the autobuilders. Should I just include a build error output into the
> commit?

Yes, and you can explained that this was shadowed by the C++11 failure,
and therefore there are no recorded autobuilder failures.

Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/libabseil-cpp/Config.in b/package/libabseil-cpp/Config.in
index 8018e7b264..222e3a092a 100644
--- a/package/libabseil-cpp/Config.in
+++ b/package/libabseil-cpp/Config.in
@@ -14,6 +14,7 @@  config BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
 config BR2_PACKAGE_LIBABSEIL_CPP
 	bool "libabseil-cpp"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_STATIC_LIBS # uses dlfcn.h
 	depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
@@ -26,7 +27,7 @@  config BR2_PACKAGE_LIBABSEIL_CPP
 
 	  https://github.com/abseil/abseil-cpp
 
-comment "libabseil-cpp needs a toolchain w/ C++, threads, dynamic library"
+comment "libabseil-cpp needs a toolchain w/ gcc >= 4.9, C++, threads, dynamic library"
 	depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
-		BR2_STATIC_LIBS
+		BR2_STATIC_LIBS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9