| Message ID | 20201027075056.10753-2-mikeframpo@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/3] configs/qcom_db410c: Add support for Dragonboard410c SBC Adds basic support for the DB410c SBC. Builds the qualcomm kernel version 5.4 arm64. Adds the device's graphics firmware. | expand |
Hello Mike, On Tue, 27 Oct 2020 20:50:55 +1300 Mike Frampton <mikeframpo@gmail.com> wrote: > Signed-off-by: Mike Frampton <mikeframpo@gmail.com> > --- > configs/qcom_db410c_defconfig | 1 + > package/Config.in | 1 + > package/qcom-db410c-firmware/Config.in | 5 ++++ > .../qcom-db410c-firmware.mk | 28 +++++++++++++++++++ > 4 files changed, 35 insertions(+) You are adding a new package: we need an entry in the DEVELOPERS file for it. Also, please add a hash file for this package. The commit title should be: package/qcom-db410c-firmware: new package it would perhaps be nice to have a bit of explanation in the commit log about the oddities of this package. Or even better: a few comments above the install target commands. > create mode 100644 package/qcom-db410c-firmware/Config.in > create mode 100644 package/qcom-db410c-firmware/qcom-db410c-firmware.mk > > diff --git a/configs/qcom_db410c_defconfig b/configs/qcom_db410c_defconfig > index 835e34453d..470d55efde 100644 > --- a/configs/qcom_db410c_defconfig > +++ b/configs/qcom_db410c_defconfig > @@ -8,6 +8,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y > BR2_PACKAGE_LINUX_FIRMWARE=y > BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS=y > BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO=y > +BR2_PACKAGE_QCOM_DB410C_FIRMWARE=y This should be in the patch adding the defconfig. In fact, your patch 1/3 adding the defconfig should be the last one in the series. > diff --git a/package/Config.in b/package/Config.in > index d7e79f4795..6ceff1107c 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -400,6 +400,7 @@ menu "Firmware" > source "package/b43-firmware/Config.in" > source "package/linux-firmware/Config.in" > source "package/murata-cyw-fw/Config.in" > + source "package/qcom-db410c-firmware/Config.in" > source "package/rpi-bt-firmware/Config.in" > source "package/rpi-firmware/Config.in" > source "package/rpi-wifi-firmware/Config.in" > diff --git a/package/qcom-db410c-firmware/Config.in b/package/qcom-db410c-firmware/Config.in > new file mode 100644 > index 0000000000..8ad768230b > --- /dev/null > +++ b/package/qcom-db410c-firmware/Config.in > @@ -0,0 +1,5 @@ > +config BR2_PACKAGE_QCOM_DB410C_FIRMWARE > + bool "qcom-db410c-firmware" > + help > + Wifi/BT firmware for Qualcomm Dragonboard 410c SBC. > + > diff --git a/package/qcom-db410c-firmware/qcom-db410c-firmware.mk b/package/qcom-db410c-firmware/qcom-db410c-firmware.mk > new file mode 100644 > index 0000000000..5a1e6bbca4 > --- /dev/null > +++ b/package/qcom-db410c-firmware/qcom-db410c-firmware.mk > @@ -0,0 +1,28 @@ > + We like to have our traditional header here, like this: ################################################################################ # # qcom-db410c-firmware # ################################################################################ yes, this is silly, but consistency wins over silliness :-) > +QCOM_DB410C_FIRMWARE_VERSION = r1034.2.1 Please set the version to just 1034.2.1, and encode the "r" in the _SOURCE and _BASE variables. > +QCOM_DB410C_FIRMWARE_BASE = linux-board-support-package-$(QCOM_DB410C_FIRMWARE_VERSION) > +QCOM_DB410C_FIRMWARE_SOURCE = $(QCOM_DB410C_FIRMWARE_BASE).zip > +QCOM_DB410C_FIRMWARE_SITE = https://releases.linaro.org/96boards/dragonboard410c/qualcomm/firmware > + > +QCOM_DB410C_FIRMWARE_LICENCE = Qualcomm firmware license > +QCOM_DB410C_FIRMWARE_LICENSE_FILES = LICENSE > + > +QCOM_DB410C_FIRMWARE_INSTALL_TARGET = YES Not needed, this is the default. > +define QCOM_DB410C_FIRMWARE_EXTRACT_CMDS > + $(UNZIP) -d $(@D) $(QCOM_DB410C_FIRMWARE_DL_DIR)/$(QCOM_DB410C_FIRMWARE_SOURCE) > +endef > + > +define QCOM_DB410C_FIRMWARE_INSTALL_TARGET_CMDS > + $(INSTALL) -d $(TARGET_DIR)/boot Not needed if you change a bit the next line. > + cp $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/efs-seed/fs_image_linux.tar.gz.mbn.img $(TARGET_DIR)/boot/modem_fsg Change to: $(INSTALL) -D -m 0644 \ $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/efs-seed/fs_image_linux.tar.gz.mbn.img \ $(TARGET_DIR)/boot/modem_fsg > + $(INSTALL) -d $(TARGET_DIR)/lib/firmware > + cp -r $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/proprietary-linux/wlan $(TARGET_DIR)/lib/firmware/ > + > + $(INSTALL) -d $(TARGET_DIR)/lib/firmware/qcom/msm8916 > + MTOOLS_SKIP_CHECK=1 mcopy -i $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/bootloaders-linux/NON-HLOS.bin \ > + ::image/modem.* ::image/mba.mbn ::image/wcnss.* $(TARGET_DIR)/lib/firmware/qcom/msm8916 Doh, why are you using mcopy here? The files you need are burried inside NON-HLOS.bin which is a FAT filesystem image ? If you need mcopy, then you'll need a dependency on host-mtools, and use $(HOST_DIR)/bin/mcopy instead, as you can't rely on mcopy being available system-wide. Thanks! Thomas
diff --git a/configs/qcom_db410c_defconfig b/configs/qcom_db410c_defconfig index 835e34453d..470d55efde 100644 --- a/configs/qcom_db410c_defconfig +++ b/configs/qcom_db410c_defconfig @@ -8,6 +8,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_4=y BR2_PACKAGE_LINUX_FIRMWARE=y BR2_PACKAGE_LINUX_FIRMWARE_QCOM_VENUS=y BR2_PACKAGE_LINUX_FIRMWARE_QCOM_ADRENO=y +BR2_PACKAGE_QCOM_DB410C_FIRMWARE=y # Kernel BR2_LINUX_KERNEL=y diff --git a/package/Config.in b/package/Config.in index d7e79f4795..6ceff1107c 100644 --- a/package/Config.in +++ b/package/Config.in @@ -400,6 +400,7 @@ menu "Firmware" source "package/b43-firmware/Config.in" source "package/linux-firmware/Config.in" source "package/murata-cyw-fw/Config.in" + source "package/qcom-db410c-firmware/Config.in" source "package/rpi-bt-firmware/Config.in" source "package/rpi-firmware/Config.in" source "package/rpi-wifi-firmware/Config.in" diff --git a/package/qcom-db410c-firmware/Config.in b/package/qcom-db410c-firmware/Config.in new file mode 100644 index 0000000000..8ad768230b --- /dev/null +++ b/package/qcom-db410c-firmware/Config.in @@ -0,0 +1,5 @@ +config BR2_PACKAGE_QCOM_DB410C_FIRMWARE + bool "qcom-db410c-firmware" + help + Wifi/BT firmware for Qualcomm Dragonboard 410c SBC. + diff --git a/package/qcom-db410c-firmware/qcom-db410c-firmware.mk b/package/qcom-db410c-firmware/qcom-db410c-firmware.mk new file mode 100644 index 0000000000..5a1e6bbca4 --- /dev/null +++ b/package/qcom-db410c-firmware/qcom-db410c-firmware.mk @@ -0,0 +1,28 @@ + +QCOM_DB410C_FIRMWARE_VERSION = r1034.2.1 +QCOM_DB410C_FIRMWARE_BASE = linux-board-support-package-$(QCOM_DB410C_FIRMWARE_VERSION) +QCOM_DB410C_FIRMWARE_SOURCE = $(QCOM_DB410C_FIRMWARE_BASE).zip +QCOM_DB410C_FIRMWARE_SITE = https://releases.linaro.org/96boards/dragonboard410c/qualcomm/firmware + +QCOM_DB410C_FIRMWARE_LICENCE = Qualcomm firmware license +QCOM_DB410C_FIRMWARE_LICENSE_FILES = LICENSE + +QCOM_DB410C_FIRMWARE_INSTALL_TARGET = YES + +define QCOM_DB410C_FIRMWARE_EXTRACT_CMDS + $(UNZIP) -d $(@D) $(QCOM_DB410C_FIRMWARE_DL_DIR)/$(QCOM_DB410C_FIRMWARE_SOURCE) +endef + +define QCOM_DB410C_FIRMWARE_INSTALL_TARGET_CMDS + $(INSTALL) -d $(TARGET_DIR)/boot + cp $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/efs-seed/fs_image_linux.tar.gz.mbn.img $(TARGET_DIR)/boot/modem_fsg + + $(INSTALL) -d $(TARGET_DIR)/lib/firmware + cp -r $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/proprietary-linux/wlan $(TARGET_DIR)/lib/firmware/ + + $(INSTALL) -d $(TARGET_DIR)/lib/firmware/qcom/msm8916 + MTOOLS_SKIP_CHECK=1 mcopy -i $(@D)/$(QCOM_DB410C_FIRMWARE_BASE)/bootloaders-linux/NON-HLOS.bin \ + ::image/modem.* ::image/mba.mbn ::image/wcnss.* $(TARGET_DIR)/lib/firmware/qcom/msm8916 +endef + +$(eval $(generic-package))
Signed-off-by: Mike Frampton <mikeframpo@gmail.com> --- configs/qcom_db410c_defconfig | 1 + package/Config.in | 1 + package/qcom-db410c-firmware/Config.in | 5 ++++ .../qcom-db410c-firmware.mk | 28 +++++++++++++++++++ 4 files changed, 35 insertions(+) create mode 100644 package/qcom-db410c-firmware/Config.in create mode 100644 package/qcom-db410c-firmware/qcom-db410c-firmware.mk