From patchwork Wed Sep 9 19:32:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1360993 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=PalPUb/l; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BmsdP0WQ7z9sTN for ; Thu, 10 Sep 2020 05:33:45 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id A4E502263C; Wed, 9 Sep 2020 19:33:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FM-o+LqsiUZR; Wed, 9 Sep 2020 19:33:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 894C42E109; Wed, 9 Sep 2020 19:33:06 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 885D51BF4DA for ; Wed, 9 Sep 2020 19:33:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 8295A874C2 for ; Wed, 9 Sep 2020 19:33:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PAzcwZVhQWeG for ; Wed, 9 Sep 2020 19:33:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by hemlock.osuosl.org (Postfix) with ESMTPS id 6C1AB874B2 for ; Wed, 9 Sep 2020 19:33:01 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id t10so4209379wrv.1 for ; Wed, 09 Sep 2020 12:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QkpVzTAtX8zde78bh1lQMZTdspfJ+5lmuVYmM239HmI=; b=PalPUb/lvFiROnJEiyT8YmMOsMhhs1HOLKXsZ9qFXhHThn47tx4UlGgkqEDnAaLHVE 1Uv6odYnOK92qY2IyQS8aTIiCViUUgpIxLz5JK2gP2s1nHjFeBnrULhe3Xm0YSFYFBdp 1ysCPglrNRpvd/4MQhXKE/HsIxgOQ9no2nii38TDmkcIeJN2iNmTjonxB2kW/q7jj6LK f2Z+j/vvksF3eqBeW5an3YccP3CKLifRvbNA+U9Bx+VhSsETKni/ATat8+4sFA8vKm2G CuTd4UOGwQR/z5l5UZt2ryHE8AGbK4i8SA8DFHCzzG3uUdBJKT3SmByWxaHRiR8LcoOf Ju5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QkpVzTAtX8zde78bh1lQMZTdspfJ+5lmuVYmM239HmI=; b=swICVgNFJjo6LqUMGcVjErBmlcmJEkoksI581rSWY673aC4YHTfy/NgdjMpUmVa59Y /sP3HP9hDCEIrrZmO94e4z25EMEylzEZyDOO5mv72F1RbsNoTXoIjyqZV8MALs3YklFQ /95hg6vDuP1SVgL7bm9WduoONqnKQo2oH2y81UC/tZ5erzZGW2HQxda0dZJ3YjPR7TFK DeTCvoh4xvJoFJgpoyd9USu04Tud4I2BkGcnH13igtrybLIP1ti6JuBnvQcml8CE1xeg za/l6+/JolP2ZhEC43hxgoSj2LeJJC8PBN8RZlDrDRnlCaNaATKuS9KEuKHZMgi51M2B qnxA== X-Gm-Message-State: AOAM531h7z6qKmirKdn6L8MBohMJ5OeHyBIBteMJH8bXyQpLLkWu/GJe 2JU0ouNx+BsVoN8k76jWNpiO0PdKs9s= X-Google-Smtp-Source: ABdhPJxgO/wCpRKsJFlFx3ibyqb/6F5RQ5x3gmeDos//9fJ9qI26YCoagbBfEKE/ieuiZ3LUdtlG7A== X-Received: by 2002:adf:db52:: with SMTP id f18mr5300502wrj.397.1599679979453; Wed, 09 Sep 2020 12:32:59 -0700 (PDT) Received: from kali.home (2a01cb0881b76d00c2afd0dfa851d2b9.ipv6.abo.wanadoo.fr. [2a01:cb08:81b7:6d00:c2af:d0df:a851:d2b9]) by smtp.gmail.com with ESMTPSA id c18sm5802459wrx.63.2020.09.09.12.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 12:32:58 -0700 (PDT) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Wed, 9 Sep 2020 21:32:52 +0200 Message-Id: <20200909193252.1248281-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/1] package/gqview: fix build with gcc 10 X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrice Fontaine Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Fixes: - http://autobuild.buildroot.org/results/ab19e23cae603b2aa6e696e4937d106883e78b76 Signed-off-by: Fabrice Fontaine --- .../gqview/0002-fix-build-with-gcc-10.patch | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 package/gqview/0002-fix-build-with-gcc-10.patch diff --git a/package/gqview/0002-fix-build-with-gcc-10.patch b/package/gqview/0002-fix-build-with-gcc-10.patch new file mode 100644 index 0000000000..55791c78b9 --- /dev/null +++ b/package/gqview/0002-fix-build-with-gcc-10.patch @@ -0,0 +1,27 @@ +fix build with gcc 10 + +Define bar_exif_key_count and bar_exif_key_list as extern to avoid the +following build failure with gcc 10 (which defaults to -fno-common): + +/home/buildroot/autobuild/instance-2/output-1/host/lib/gcc/arm-buildroot-linux-gnueabihf/10.2.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: info.o:(.rodata+0x0): multiple definition of `bar_exif_key_count'; bar_exif.o:(.rodata+0x0): first defined here +/home/buildroot/autobuild/instance-2/output-1/host/lib/gcc/arm-buildroot-linux-gnueabihf/10.2.0/../../../../arm-buildroot-linux-gnueabihf/bin/ld: info.o:(.bss+0x0): multiple definition of `bar_exif_key_list'; bar_exif.o:(.data+0x0): first defined here + +Fixes: + - http://autobuild.buildroot.org/results/ab19e23cae603b2aa6e696e4937d106883e78b76 + +Signed-off-by: Fabrice Fontaine + +diff -Naur gqview-2.1.5.orig/src/bar_exif.h gqview-2.1.5/src/bar_exif.h +--- gqview-2.1.5.orig/src/bar_exif.h 2020-09-09 20:32:50.506755031 +0200 ++++ gqview-2.1.5/src/bar_exif.h 2020-09-09 20:33:30.370755818 +0200 +@@ -24,8 +24,8 @@ + + /* these are exposed for when duplication of the exif bar's text is needed */ + +-const gchar **bar_exif_key_list; +-const gint bar_exif_key_count; ++extern const gchar **bar_exif_key_list; ++extern const gint bar_exif_key_count; + + gchar *bar_exif_validate_text(gchar *text); +