| Message ID | 20200909074346.13037-1-jugurtha.belkalem@smile.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/1] package/freeopcua : new package | expand |
Hello, Thanks for this new contribution! On Wed, 9 Sep 2020 09:43:46 +0200 Jugurtha BELKALEM <jugurtha.belkalem@smile.fr> wrote: > diff --git a/package/freeopcua/Config.in b/package/freeopcua/Config.in > new file mode 100644 > index 0000000000..f210efe1b5 > --- /dev/null > +++ b/package/freeopcua/Config.in > @@ -0,0 +1,17 @@ > +config BR2_PACKAGE_FREEOPCUA > + bool "freeopcua" > + depends on BR2_PACKAGE_BOOST Please select the boost package, as it's not an obvious dependency. > + depends on BR2_PACKAGE_PYTHON3 Are you sure python on the target is necessary? This OPC-UA implementation is written in C++. It has Python bindings, but I suppose they are optional. Perhaps there is some confusion about the fact that some code is auto-generated from XML specification using Python... but that is at build time, i.e Python would only be needed on the build machine. Could you investigate this? > +FREEOPCUA_DEPENDENCIES = boost mbedtls python3 > + > +# Copy generated binaries and libraries to target > +# as this is not done by freeopcua buildsystem. > +define FREEOPCUA_INSTALL_BINARY_LIB > + cp $(BUILD_DIR)/freeopcua-$(FREEOPCUA_VERSION)/bin/* \ > + $(TARGET_DIR)/usr/bin/ > + > + cp $(BUILD_DIR)/freeopcua-$(FREEOPCUA_VERSION)/lib/* \ > + $(TARGET_DIR)/usr/lib/ > +endef > +FREEOPCUA_POST_INSTALL_TARGET_HOOKS += FREEOPCUA_INSTALL_BINARY_LIB The regular "make install" step doesn't install those libraries/binaries ? > +# Freeopcua uses some narrowing like int8 to char > +# which results in compilation error. > +FREEOPCUA_CONF_OPTS = \ > + -DCMAKE_CXX_FLAGS="-Wno-narrowing" \ You need: -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -Wno-narrowing" > + -DBUILD_EXAMPLE=OFF \ > + -DBUILD_TESTING=OFF These two options are already passed by the cmake-package infrastructure, so they are not needed here. Thomas
diff --git a/DEVELOPERS b/DEVELOPERS index 93a86811ba..dc6760f408 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -1424,6 +1424,7 @@ N: Joshua Henderson <joshua.henderson@microchip.com> F: package/qt5/qt5wayland/ N: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr> +F: package/freeopcua/ F: package/python-aiofiles/ F: package/python-crayons/ F: package/python-cycler/ diff --git a/package/Config.in b/package/Config.in index 02213310a8..14dab70a7f 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1682,6 +1682,7 @@ menu "Networking" source "package/filemq/Config.in" source "package/flickcurl/Config.in" source "package/fmlib/Config.in" + source "package/freeopcua/Config.in" source "package/freeradius-client/Config.in" source "package/gensio/Config.in" source "package/geoip/Config.in" diff --git a/package/freeopcua/Config.in b/package/freeopcua/Config.in new file mode 100644 index 0000000000..f210efe1b5 --- /dev/null +++ b/package/freeopcua/Config.in @@ -0,0 +1,17 @@ +config BR2_PACKAGE_FREEOPCUA + bool "freeopcua" + depends on BR2_PACKAGE_BOOST + depends on BR2_PACKAGE_PYTHON3 + select BR2_PACKAGE_BOOST_FILESYSTEM + select BR2_PACKAGE_BOOST_PROGRAM_OPTIONS + select BR2_PACKAGE_BOOST_PYTHON + select BR2_PACKAGE_BOOST_SYSTEM + select BR2_PACKAGE_BOOST_THREAD + select BR2_PACKAGE_LIBXML2 + select BR2_PACKAGE_MBEDTLS + help + LGPL OPC-UA server and client library written in + C++ and with a lot of code auto-generated from + xml specification using python. + + https://github.com/FreeOpcUa/freeopcua diff --git a/package/freeopcua/freeopcua.hash b/package/freeopcua/freeopcua.hash new file mode 100644 index 0000000000..986af5df99 --- /dev/null +++ b/package/freeopcua/freeopcua.hash @@ -0,0 +1,3 @@ +# Locally calculated +sha256 cbb199396f7a977929ca374310266bbd84613d09fb53c8946270718babad1622 freeopcua-d24d7806a71739b869f6d2465316184b49e37875.tar.gz +sha256 da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768 COPYING diff --git a/package/freeopcua/freeopcua.mk b/package/freeopcua/freeopcua.mk new file mode 100644 index 0000000000..291cc2514a --- /dev/null +++ b/package/freeopcua/freeopcua.mk @@ -0,0 +1,32 @@ +################################################################################ +# +# freeopcua +# +################################################################################ + +FREEOPCUA_VERSION = d24d7806a71739b869f6d2465316184b49e37875 +FREEOPCUA_SITE = $(call github,FreeOpcUa,freeopcua,$(FREEOPCUA_VERSION)) +FREEOPCUA_LICENSE = LGPL-3.0 +FREEOPCUA_LICENSE_FILES = COPYING + +FREEOPCUA_DEPENDENCIES = boost mbedtls python3 + +# Copy generated binaries and libraries to target +# as this is not done by freeopcua buildsystem. +define FREEOPCUA_INSTALL_BINARY_LIB + cp $(BUILD_DIR)/freeopcua-$(FREEOPCUA_VERSION)/bin/* \ + $(TARGET_DIR)/usr/bin/ + + cp $(BUILD_DIR)/freeopcua-$(FREEOPCUA_VERSION)/lib/* \ + $(TARGET_DIR)/usr/lib/ +endef +FREEOPCUA_POST_INSTALL_TARGET_HOOKS += FREEOPCUA_INSTALL_BINARY_LIB + +# Freeopcua uses some narrowing like int8 to char +# which results in compilation error. +FREEOPCUA_CONF_OPTS = \ + -DCMAKE_CXX_FLAGS="-Wno-narrowing" \ + -DBUILD_EXAMPLE=OFF \ + -DBUILD_TESTING=OFF + +$(eval $(cmake-package))