| Message ID | 20200624204347.797088-6-angelo@amarulasolutions.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Cups revamp | expand |
On 24/06/2020 22:43, Angelo Compagnucci wrote: > This patch is a backport from the rockchip tree. > > Author: Jeffy Chen <jeffy.chen@rock-chips.com> > Date: Tue Nov 13 18:25:34 2018 +0800 > > package: cups: Add lp user as default cups user > > Change-Id: Ic7434fe0a7b41b86b5b8b097fa29dd9718e29aa5 > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > > User lp is necessary for running the cups spooler. > Groups lpadmin grants administrative privileges to users. > > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> Applied to master, thanks. Regards, Arnout > --- > package/cups/cups.mk | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/package/cups/cups.mk b/package/cups/cups.mk > index acd8c2066b..e86374b027 100644 > --- a/package/cups/cups.mk > +++ b/package/cups/cups.mk > @@ -22,6 +22,9 @@ CUPS_CONF_OPTS = \ > --disable-gssapi \ > --disable-pam \ > --libdir=/usr/lib \ > + --with-cups-user=lp \ > + --with-cups-group=lp \ > + --with-system-groups="lpadmin sys root" \ > --with-rcdir=no > CUPS_CONFIG_SCRIPTS = cups-config > CUPS_DEPENDENCIES = \ > @@ -78,4 +81,11 @@ define CUPS_INSTALL_INIT_SYSV > $(TARGET_DIR)/etc/init.d/S81cupsd > endef > > +# lp user is needed to run cups spooler > +# lpadmin group membership grants administrative privileges > +define CUPS_USERS > + lp -1 lp -1 * /var/spool/lpd /bin/false - lp > + - - lpadmin -1 * - - - Printers admin group. > +endef > + > $(eval $(autotools-package)) >
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes: > On 24/06/2020 22:43, Angelo Compagnucci wrote: >> This patch is a backport from the rockchip tree. >> >> Author: Jeffy Chen <jeffy.chen@rock-chips.com> >> Date: Tue Nov 13 18:25:34 2018 +0800 >> >> package: cups: Add lp user as default cups user >> >> Change-Id: Ic7434fe0a7b41b86b5b8b097fa29dd9718e29aa5 >> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> >> >> User lp is necessary for running the cups spooler. >> Groups lpadmin grants administrative privileges to users. >> >> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks.
diff --git a/package/cups/cups.mk b/package/cups/cups.mk index acd8c2066b..e86374b027 100644 --- a/package/cups/cups.mk +++ b/package/cups/cups.mk @@ -22,6 +22,9 @@ CUPS_CONF_OPTS = \ --disable-gssapi \ --disable-pam \ --libdir=/usr/lib \ + --with-cups-user=lp \ + --with-cups-group=lp \ + --with-system-groups="lpadmin sys root" \ --with-rcdir=no CUPS_CONFIG_SCRIPTS = cups-config CUPS_DEPENDENCIES = \ @@ -78,4 +81,11 @@ define CUPS_INSTALL_INIT_SYSV $(TARGET_DIR)/etc/init.d/S81cupsd endef +# lp user is needed to run cups spooler +# lpadmin group membership grants administrative privileges +define CUPS_USERS + lp -1 lp -1 * /var/spool/lpd /bin/false - lp + - - lpadmin -1 * - - - Printers admin group. +endef + $(eval $(autotools-package))
This patch is a backport from the rockchip tree. Author: Jeffy Chen <jeffy.chen@rock-chips.com> Date: Tue Nov 13 18:25:34 2018 +0800 package: cups: Add lp user as default cups user Change-Id: Ic7434fe0a7b41b86b5b8b097fa29dd9718e29aa5 Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> User lp is necessary for running the cups spooler. Groups lpadmin grants administrative privileges to users. Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> --- package/cups/cups.mk | 10 ++++++++++ 1 file changed, 10 insertions(+)