diff mbox series

[RFC,v9,03/10] cpe-info: only report target pkgs

Message ID 20200616170341.45098-3-matthew.weber@rockwellcollins.com
State New
Headers show
Series [RFC,v9,01/10] cpe-info: new make target | expand

Commit Message

Matthew Weber June 16, 2020, 5:03 p.m. UTC
The reporting of host packages causes some duplication and complicates
what is really in the targets configuration. For the purpose of the
first version of this patchset, its assumed that host packages aren't
relevant for the configuration and we only report the target's
contents.

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
Changes

v4 -> v8
 - None

v3
 - Fixed host build error because cpe-info wasn't defined

v1 -> v2
[Thomas P
 - select if target vs selecting not host
---
 package/pkg-generic.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Yann E. MORIN June 21, 2020, 8:56 a.m. UTC | #1
Matt, All,

On 2020-06-16 12:03 -0500, Matt Weber spake thusly:
> The reporting of host packages causes some duplication and complicates
> what is really in the targets configuration. For the purpose of the
> first version of this patchset, its assumed that host packages aren't
> relevant for the configuration and we only report the target's
> contents.

Ah, I see this patch now, which addresses my concerns about hos
packages in the first patch.

So, I think we should keep the $(1)-cpe-info rule as -is, but filter-out
host packages as I suggested in the review of the first patch.

Regards,
Yann E. MORIN.

> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
> Changes
> 
> v4 -> v8
>  - None
> 
> v3
>  - Fixed host build error because cpe-info wasn't defined
> 
> v1 -> v2
> [Thomas P
>  - select if target vs selecting not host
> ---
>  package/pkg-generic.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 7d892ca1d6..efdde0ad94 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -984,10 +984,12 @@ endif
>  
>  $(1)-cpe-info: PKG=$(2)
>  $(1)-cpe-info:
> +ifeq ($$($(2)_TYPE),target)
>  ifneq ($$(call qstrip,$$($(2)_SOURCE)),)
>  	@$$(call MESSAGE,"Collecting cpe info")
>  	$(Q)$$(call cpe-manifest,$$($(2)_CPE_PREFIX):$$($(2)_CPE_ID):$(CPE_SUFFIX),$$($(2)_RAWNAME),$$($(2)_VERSION),$$($(2)_ACTUAL_SOURCE_SITE))
>  endif # ifneq ($$(call qstrip,$$($(2)_SOURCE)),)
> +endif # ifeq ($$($(2)_TYPE),target)
>  
>  # legal-info: declare dependencies and set values used later for the manifest
>  ifneq ($$($(2)_LICENSE_FILES),)
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Matthew Weber June 22, 2020, 11:35 a.m. UTC | #2
Yann,

On Sun, Jun 21, 2020 at 3:59 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> Matt, All,
>
> On 2020-06-16 12:03 -0500, Matt Weber spake thusly:
> > The reporting of host packages causes some duplication and complicates
> > what is really in the targets configuration. For the purpose of the
> > first version of this patchset, its assumed that host packages aren't
> > relevant for the configuration and we only report the target's
> > contents.
>
> Ah, I see this patch now, which addresses my concerns about hos
> packages in the first patch.
>
> So, I think we should keep the $(1)-cpe-info rule as -is, but filter-out
> host packages as I suggested in the review of the first patch.
>

Sure.

Regards,
Matt
diff mbox series

Patch

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 7d892ca1d6..efdde0ad94 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -984,10 +984,12 @@  endif
 
 $(1)-cpe-info: PKG=$(2)
 $(1)-cpe-info:
+ifeq ($$($(2)_TYPE),target)
 ifneq ($$(call qstrip,$$($(2)_SOURCE)),)
 	@$$(call MESSAGE,"Collecting cpe info")
 	$(Q)$$(call cpe-manifest,$$($(2)_CPE_PREFIX):$$($(2)_CPE_ID):$(CPE_SUFFIX),$$($(2)_RAWNAME),$$($(2)_VERSION),$$($(2)_ACTUAL_SOURCE_SITE))
 endif # ifneq ($$(call qstrip,$$($(2)_SOURCE)),)
+endif # ifeq ($$($(2)_TYPE),target)
 
 # legal-info: declare dependencies and set values used later for the manifest
 ifneq ($$($(2)_LICENSE_FILES),)