diff mbox series

[v2,04/14] package/systemd: cosmetic rearrange list of users

Message ID 20200615072055.2083-5-nolange79@gmail.com
State Accepted
Headers show
Series [v2,01/14] package/systemd: configure nss plugins in nsswitch.conf | expand

Commit Message

Norbert Lange June 15, 2020, 7:20 a.m. UTC
Group the udev users first, to make clear which software
requires them.

Signed-off-by: Norbert Lange <nolange79@gmail.com>
Reviewed-by: Jérémy Rosen <jeremy.rosen@smile.fr>
---
 package/systemd/systemd.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Yann E. MORIN July 18, 2020, 11:46 a.m. UTC | #1
Norbert, All,

On 2020-06-15 09:20 +0200, Norbert Lange spake thusly:
> Group the udev users first, to make clear which software
> requires them.
> 
> Signed-off-by: Norbert Lange <nolange79@gmail.com>
> Reviewed-by: Jérémy Rosen <jeremy.rosen@smile.fr>

I don;t care much about the separation: indeed, this is the systemd
package, and thus all users defined herein arwe needed by any one of
the systemd component. That they be sorted I don;t care much, as long as
the conditional ones come after the non-conditional ones.

If I had been slightly more pedant, I'd have re-ordered them
alphabetically. But oh well... ;-)

Applied to mster, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/systemd/systemd.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index ead4e70f95..6629c933cd 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -499,10 +499,12 @@ define SYSTEMD_INSTALL_IMAGES_CMDS
>  endef
>  
>  define SYSTEMD_USERS
> +	# udev user groups
>  	- - input -1 * - - - Input device group
> -	- - systemd-journal -1 * - - - Journal
>  	- - render -1 * - - - DRI rendering nodes
>  	- - kvm -1 * - - - kvm nodes
> +	# systemd user groups
> +	- - systemd-journal -1 * - - - Journal
>  	$(SYSTEMD_REMOTE_USER)
>  	$(SYSTEMD_COREDUMP_USER)
>  	$(SYSTEMD_NETWORKD_USER)
> -- 
> 2.27.0
>
diff mbox series

Patch

diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
index ead4e70f95..6629c933cd 100644
--- a/package/systemd/systemd.mk
+++ b/package/systemd/systemd.mk
@@ -499,10 +499,12 @@  define SYSTEMD_INSTALL_IMAGES_CMDS
 endef
 
 define SYSTEMD_USERS
+	# udev user groups
 	- - input -1 * - - - Input device group
-	- - systemd-journal -1 * - - - Journal
 	- - render -1 * - - - DRI rendering nodes
 	- - kvm -1 * - - - kvm nodes
+	# systemd user groups
+	- - systemd-journal -1 * - - - Journal
 	$(SYSTEMD_REMOTE_USER)
 	$(SYSTEMD_COREDUMP_USER)
 	$(SYSTEMD_NETWORKD_USER)