diff mbox series

[v2,4/7] package/docker-engine: needs more runtime dependencies

Message ID 20200530124735.1384078-5-francois.perrad@gadz.org
State Superseded
Headers show
Series Container - Guest | expand

Commit Message

Francois Perrad May 30, 2020, 12:47 p.m. UTC
fix error:
	failed to start daemon: Devices cgroup isn't mounted

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/docker-engine/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Christian Stewart June 6, 2020, 11:11 p.m. UTC | #1
Hi Francois,

On Sat, May 30, 2020 at 5:48 AM Francois Perrad <fperrad@gmail.com> wrote:
>
> fix error:
>         failed to start daemon: Devices cgroup isn't mounted

I don't see this error, and I don't have the cgroupfs-mount enabled.

With systemd, cgroups should be mounted automatically, at least as far
as I know.

> diff --git a/package/docker-engine/Config.in b/package/docker-engine/Config.in
> index 1fd229fcb..64afba30f 100644
> --- a/package/docker-engine/Config.in
> +++ b/package/docker-engine/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_DOCKER_ENGINE
>         depends on BR2_TOOLCHAIN_HAS_THREADS
>         depends on !BR2_TOOLCHAIN_USES_UCLIBC # docker-containerd -> runc
>         depends on BR2_USE_MMU # docker-containerd
> +       select BR2_PACKAGE_CGROUPFS_MOUNT # runtime dependency
>         select BR2_PACKAGE_DOCKER_CONTAINERD # runtime dependency
>         select BR2_PACKAGE_DOCKER_PROXY # runtime dependency
>         select BR2_PACKAGE_IPTABLES # runtime dependency

Best regards,
Christian Stewart
Francois Perrad June 8, 2020, 5:30 a.m. UTC | #2
Le dim. 7 juin 2020 à 01:12, Christian Stewart <christian@paral.in> a
écrit :

> Hi Francois,
>
> On Sat, May 30, 2020 at 5:48 AM Francois Perrad <fperrad@gmail.com> wrote:
> >
> > fix error:
> >         failed to start daemon: Devices cgroup isn't mounted
>
> I don't see this error, and I don't have the cgroupfs-mount enabled.
>
> With systemd, cgroups should be mounted automatically, at least as far
> as I know.
>
>
I see this error with a host using the old default SysV init (so without
systemd)
So, I will update the patch like this:
        select BR2_PACKAGE_CGROUPFS_MOUNT if !BR2_PACKAGE_SYSTEMD # runtime
dependenc

François

> diff --git a/package/docker-engine/Config.in
> b/package/docker-engine/Config.in
> > index 1fd229fcb..64afba30f 100644
> > --- a/package/docker-engine/Config.in
> > +++ b/package/docker-engine/Config.in
> > @@ -5,6 +5,7 @@ config BR2_PACKAGE_DOCKER_ENGINE
> >         depends on BR2_TOOLCHAIN_HAS_THREADS
> >         depends on !BR2_TOOLCHAIN_USES_UCLIBC # docker-containerd -> runc
> >         depends on BR2_USE_MMU # docker-containerd
> > +       select BR2_PACKAGE_CGROUPFS_MOUNT # runtime dependency
> >         select BR2_PACKAGE_DOCKER_CONTAINERD # runtime dependency
> >         select BR2_PACKAGE_DOCKER_PROXY # runtime dependency
> >         select BR2_PACKAGE_IPTABLES # runtime dependency
>
> Best regards,
> Christian Stewart
>
diff mbox series

Patch

diff --git a/package/docker-engine/Config.in b/package/docker-engine/Config.in
index 1fd229fcb..64afba30f 100644
--- a/package/docker-engine/Config.in
+++ b/package/docker-engine/Config.in
@@ -5,6 +5,7 @@  config BR2_PACKAGE_DOCKER_ENGINE
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on !BR2_TOOLCHAIN_USES_UCLIBC # docker-containerd -> runc
 	depends on BR2_USE_MMU # docker-containerd
+	select BR2_PACKAGE_CGROUPFS_MOUNT # runtime dependency
 	select BR2_PACKAGE_DOCKER_CONTAINERD # runtime dependency
 	select BR2_PACKAGE_DOCKER_PROXY # runtime dependency
 	select BR2_PACKAGE_IPTABLES # runtime dependency