diff mbox series

package/linux-firmware: add options for Broadcom BCM4366

Message ID 20200518083305.21239-1-zajec5@gmail.com
State Accepted
Headers show
Series package/linux-firmware: add options for Broadcom BCM4366 | expand

Commit Message

Rafał Miłecki May 18, 2020, 8:33 a.m. UTC
From: Rafał Miłecki <rafal@milecki.pl>

There are two groups of chipsets in the BCM4366 family requiring two
different firmware files. Each is quite big (over 1 MiB) so use
separated options for them.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
Yann, Yegor: my previous e-mail didn't reach ML because I wasn't
subscribed thus I'm resending it.
---
 package/linux-firmware/Config.in         | 10 ++++++++++
 package/linux-firmware/linux-firmware.mk | 12 ++++++++++++
 2 files changed, 22 insertions(+)

Comments

Rafał Miłecki Aug. 4, 2020, 10:47 a.m. UTC | #1
Hi,

On 18.05.2020 10:33, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> There are two groups of chipsets in the BCM4366 family requiring two
> different firmware files. Each is quite big (over 1 MiB) so use
> separated options for them.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> Yann, Yegor: my previous e-mail didn't reach ML because I wasn't
> subscribed thus I'm resending it.

Can someone review/accept my patch, please?
Thomas Petazzoni Oct. 17, 2020, 12:30 p.m. UTC | #2
On Mon, 18 May 2020 10:33:05 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:

> From: Rafał Miłecki <rafal@milecki.pl>
> 
> There are two groups of chipsets in the BCM4366 family requiring two
> different firmware files. Each is quite big (over 1 MiB) so use
> separated options for them.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> Yann, Yegor: my previous e-mail didn't reach ML because I wasn't
> subscribed thus I'm resending it.
> ---
>  package/linux-firmware/Config.in         | 10 ++++++++++
>  package/linux-firmware/linux-firmware.mk | 12 ++++++++++++
>  2 files changed, 22 insertions(+)

I've slightly tweaked the option names to be a bit more consistent with
existing option names, and applied. Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/linux-firmware/Config.in b/package/linux-firmware/Config.in
index eba58014b6..3746f6f463 100644
--- a/package/linux-firmware/Config.in
+++ b/package/linux-firmware/Config.in
@@ -128,6 +128,16 @@  config BR2_PACKAGE_LINUX_FIRMWARE_BRCM_BCM43XXX
 	help
 	  Firmware files for the Broadcom bcm43xxx, SoftMAC and FullMAC.
 
+config BR2_PACKAGE_LINUX_FIRMWARE_BRCM_4366B1
+	bool "Broadcom 4366b1"
+	help
+	  Firmware file for the Broadcom 4366b1 FullMAC chip.
+
+config BR2_PACKAGE_LINUX_FIRMWARE_BRCM_4366C0
+	bool "Broadcom 4366c0"
+	help
+	  Firmware file for the Broadcom 4366c0 FullMAC chip.
+
 config BR2_PACKAGE_LINUX_FIRMWARE_IWLWIFI_3160
 	bool "Intel iwlwifi 3160"
 	help
diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
index cbad8d592a..a80eafaf14 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -546,6 +546,18 @@  LINUX_FIRMWARE_FILES += \
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.broadcom_bcm43xx
 endif
 
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_BRCM_4366B1),y)
+LINUX_FIRMWARE_FILES += \
+	brcm/brcmfmac4366b-pcie.bin brcm/brcmfmac4366b-pcie.bin
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.broadcom_bcm43xx
+endif
+
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_BRCM_4366C0),y)
+LINUX_FIRMWARE_FILES += \
+	brcm/brcmfmac4366c-pcie.bin brcm/brcmfmac4366c-pcie.bin
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.broadcom_bcm43xx
+endif
+
 # ql2xxx
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_QLOGIC_2XXX),y)
 LINUX_FIRMWARE_FILES += \