diff mbox series

[1/1] package/pistache: force Release mode

Message ID 20200516121935.1235445-1-fontaine.fabrice@gmail.com
State New
Headers show
Series [1/1] package/pistache: force Release mode | expand

Commit Message

Fabrice Fontaine May 16, 2020, 12:19 p.m. UTC
Debug build without SSP will fail on:

/home/giuliobenetti/autobuild/run/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i586-buildroot-linux-musl/8.3.0/../../../../i586-buildroot-linux-musl/bin/ld: cannot find -lssp_nonshared
/home/giuliobenetti/autobuild/run/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/i586-buildroot-linux-musl/8.3.0/../../../../i586-buildroot-linux-musl/bin/ld: cannot find -lssp

because of the following lines in CMakeLists.txt:

if(CMAKE_BUILD_TYPE MATCHES "Debug")
    set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -g -O0 -fprofile-arcs -ftest-coverage -fstack-protector-all --param=ssp-buffer-size=4")
endif()

So force Release mode

Fixes:
 - http://autobuild.buildroot.org/results/3ed42be111cc8c3b3d1d4f6504ae548730ab6af6

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/pistache/pistache.mk | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thomas Petazzoni Oct. 17, 2020, 12:56 p.m. UTC | #1
On Sat, 16 May 2020 14:19:35 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> +# Force Release to fix build failure without SSP
> +PISTACHE_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release

In some packages, we use CMAKE_BUILD_TYPE=Buildroot, and in others
CMAKE_BUILD_TYPE=Release. Should we take a decision on which one makes
the most sense ?

Thanks,

Thomas
Fabrice Fontaine Oct. 17, 2020, 1:05 p.m. UTC | #2
Le sam. 17 oct. 2020 à 14:56, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> On Sat, 16 May 2020 14:19:35 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > +# Force Release to fix build failure without SSP
> > +PISTACHE_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release
>
> In some packages, we use CMAKE_BUILD_TYPE=Buildroot, and in others
> CMAKE_BUILD_TYPE=Release. Should we take a decision on which one makes
> the most sense ?
Release is a standard cmake value
(https://cmake.org/cmake/help/v3.0/variable/CMAKE_BUILD_TYPE.html). It
is "forced" in 5 packages.
Buildroot is not standard and is used by only 2 packages.
So I would vote for Release.
More globally, perhaps we should always set CMAKE_BUILD_TYPE to
Release in pkg-cmake independently of the BR2_ENABLE_DEBUG value.
This would allow us to remove all those workarounds.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice
diff mbox series

Patch

diff --git a/package/pistache/pistache.mk b/package/pistache/pistache.mk
index c182754cee..f258bae3bc 100644
--- a/package/pistache/pistache.mk
+++ b/package/pistache/pistache.mk
@@ -11,6 +11,9 @@  PISTACHE_LICENSE_FILES = LICENSE
 
 PISTACHE_INSTALL_STAGING = YES
 
+# Force Release to fix build failure without SSP
+PISTACHE_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release
+
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 PISTACHE_DEPENDENCIES += openssl
 PISTACHE_CONF_OPTS += -DPISTACHE_USE_SSL=ON