diff mbox series

[1/1] package/pigz: fix zlib dependency on host-pigz

Message ID 20200504094236.1113-1-lpdev@cordier.org
State Accepted
Headers show
Series [1/1] package/pigz: fix zlib dependency on host-pigz | expand

Commit Message

LP C May 4, 2020, 9:42 a.m. UTC
Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
---
 package/pigz/Config.in      | 1 -
 package/pigz/Config.in.host | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni May 9, 2020, 8:56 p.m. UTC | #1
On Mon,  4 May 2020 11:42:36 +0200
Louis-Paul Cordier <lpdev@cordier.org> wrote:

> Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
> ---
>  package/pigz/Config.in      | 1 -
>  package/pigz/Config.in.host | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/pigz/Config.in b/package/pigz/Config.in
> index a76146d8fc..af229060cf 100644
> --- a/package/pigz/Config.in
> +++ b/package/pigz/Config.in
> @@ -2,7 +2,6 @@ config BR2_PACKAGE_PIGZ
>  	bool "pigz"
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	select BR2_PACKAGE_ZLIB
> -	select BR2_PACKAGE_HOST_ZLIB

This was indeed wrong.

>  	help
>  	  pigz, which stands for parallel implementation of gzip, is a
>  	  fully functional replacement for gzip that exploits multiple
> diff --git a/package/pigz/Config.in.host b/package/pigz/Config.in.host
> index 9903cada7d..3e3e5ac656 100644
> --- a/package/pigz/Config.in.host
> +++ b/package/pigz/Config.in.host
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_HOST_PIGZ
>  	bool "host pigz"
> +	select BR2_PACKAGE_HOST_ZLIB

But this is also wrong. BR2_PACKAGE_HOST_ZLIB does not exist at all. So
I dropped this part of your patch, and applied to master.

Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/pigz/Config.in b/package/pigz/Config.in
index a76146d8fc..af229060cf 100644
--- a/package/pigz/Config.in
+++ b/package/pigz/Config.in
@@ -2,7 +2,6 @@  config BR2_PACKAGE_PIGZ
 	bool "pigz"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_ZLIB
-	select BR2_PACKAGE_HOST_ZLIB
 	help
 	  pigz, which stands for parallel implementation of gzip, is a
 	  fully functional replacement for gzip that exploits multiple
diff --git a/package/pigz/Config.in.host b/package/pigz/Config.in.host
index 9903cada7d..3e3e5ac656 100644
--- a/package/pigz/Config.in.host
+++ b/package/pigz/Config.in.host
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_HOST_PIGZ
 	bool "host pigz"
+	select BR2_PACKAGE_HOST_ZLIB
 	help
 	  pigz, which stands for parallel implementation of gzip, is a
 	  fully functional replacement for gzip that exploits multiple