From patchwork Tue Apr 21 13:08:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Weber X-Patchwork-Id: 1274249 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=rockwellcollins.com Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4963mg3j69z9sSM for ; Tue, 21 Apr 2020 23:09:06 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2989488431; Tue, 21 Apr 2020 13:09:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o7dZNivnAqLf; Tue, 21 Apr 2020 13:08:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id BCDCC8841F; Tue, 21 Apr 2020 13:08:57 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 7EC211BF34E for ; Tue, 21 Apr 2020 13:08:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7BA6486A9E for ; Tue, 21 Apr 2020 13:08:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 01a_naW697VQ for ; Tue, 21 Apr 2020 13:08:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from da1vs05.rockwellcollins.com (da1vs05.rockwellcollins.com [205.175.227.130]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 4CCEB845A0 for ; Tue, 21 Apr 2020 13:08:55 +0000 (UTC) IronPort-SDR: qNlFra9D45ZeWpaAftNhR6qBctF2CWrvCy7zAYr06DV7siXAJK/WnaBCdOFODDpiYTaChSXUvL je/jIyw44hJVqWixnYeV3wy5Uq6TfDt7aX38eAV9K0vkCo+vmjLFGD9zpNw1LGoh1+ZO4rPBZ3 uV2MY38F55gXYTPXhRCyOeu2C3TOZA2KfMDcIKfPomGbOfPl0V/H1Mq/hOw9w8d5Zkpi+Uun3X 96jY/TKK3ff3DpZCjvr3TE6AO0qiix4LD55NNoSZeGSXs1pyImE22hwIh00Fh0QJcliXb51A40 2ms= Received: from ofwda1n02.rockwellcollins.com (HELO dtulimr01.rockwellcollins.com) ([205.175.227.14]) by da1vs05.rockwellcollins.com with ESMTP; 21 Apr 2020 08:08:54 -0500 X-Received: from biscuits.rockwellcollins.lab (biscuits.rockwellcollins.lab [10.148.119.137]) by dtulimr01.rockwellcollins.com (Postfix) with ESMTP id 143636039B; Tue, 21 Apr 2020 08:08:54 -0500 (CDT) From: Matt Weber To: buildroot@buildroot.org Date: Tue, 21 Apr 2020 08:08:53 -0500 Message-Id: <20200421130853.34356-1-matthew.weber@rockwellcollins.com> X-Mailer: git-send-email 2.17.1 Subject: [Buildroot] [PATCH] package/swupdate: note init script tokenizing limitation X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matt Weber MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Command line options reference: https://sbabic.github.io/swupdate/_sources/swupdate.txt Signed-off-by: Matthew Weber --- I didn't find a good way around this without completely changing how the upstream scripts were working or requiring a full shell. --- package/swupdate/swupdate.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/swupdate/swupdate.sh b/package/swupdate/swupdate.sh index 17d99ef0d4..31ec536373 100644 --- a/package/swupdate/swupdate.sh +++ b/package/swupdate/swupdate.sh @@ -5,6 +5,9 @@ # Override these variables in sourced script(s) located # in /usr/lib/swupdate/conf.d or /etc/swupdate/conf.d +# NOTE: There are substrings used in some swupdate commands which will +# need to be wrapped in a script to prevent tokenizing +# ( -p/-P post/pre cmds are good examples) SWUPDATE_ARGS="-v ${SWUPDATE_EXTRA_ARGS}" SWUPDATE_WEBSERVER_ARGS="" SWUPDATE_SURICATTA_ARGS=""