Message ID | 20200415063008.2237470-6-fontaine.fabrice@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | [v3,1/6] package/collectd: drop autoreconf | expand |
Hello, On Wed, Apr 15, 2020 at 9:29 AM Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > > buddyinfo is available since version 5.11.0 and > https://github.com/collectd/collectd/commit/cb19ecf90d89a79836b8b5236d2b66277dd79c5f > > It is currently enabled by default > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > Changes v1 -> v2 (after review of Asaf Kahlon): > - Add missing COLLECTD_ prefix for buddyinfo option in Config.in > > package/collectd/Config.in | 5 +++++ > package/collectd/collectd.mk | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/package/collectd/Config.in b/package/collectd/Config.in > index 3fc07a9014..54b218754a 100644 > --- a/package/collectd/Config.in > +++ b/package/collectd/Config.in > @@ -128,6 +128,11 @@ config BR2_PACKAGE_COLLECTD_BIND > help > Collects BIND DNS statistics. > > +config BR2_PACKAGE_COLLECTD_BUDDYINFO > + bool "buddyinfo" > + help > + Statistics from buddyinfo file about memory fragmentation. > + > config BR2_PACKAGE_COLLECTD_CAPABILITIES > bool "capabilities" > depends on BR2_aarch64 || BR2_i386 || BR2_x86_64 # dmidecode > diff --git a/package/collectd/collectd.mk b/package/collectd/collectd.mk > index f04ccdb2ff..6bd1754ad7 100644 > --- a/package/collectd/collectd.mk > +++ b/package/collectd/collectd.mk > @@ -51,6 +51,7 @@ COLLECTD_CONF_OPTS += \ > $(if $(BR2_PACKAGE_COLLECTD_APCUPS),--enable-apcups,--disable-apcups) \ > $(if $(BR2_PACKAGE_COLLECTD_BATTERY),--enable-battery,--disable-battery) \ > $(if $(BR2_PACKAGE_COLLECTD_BIND),--enable-bind,--disable-bind) \ > + $(if $(BR2_PACKAGE_COLLECTD_BUDDYINFO),--enable-buddyinfo,--disable-buddyinfo) \ > $(if $(BR2_PACKAGE_COLLECTD_CAPABILITIES),--enable-capabilities,--disable-capabilities) \ > $(if $(BR2_PACKAGE_COLLECTD_CEPH),--enable-ceph,--disable-ceph) \ > $(if $(BR2_PACKAGE_COLLECTD_CHRONY),--enable-chrony,--disable-chrony) \ > -- > 2.25.1 > Reviewed-by: Asaf Kahlon <asafka7@gmail.com> Regards, Asaf.
On Wed, 15 Apr 2020 08:30:08 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > buddyinfo is available since version 5.11.0 and > https://github.com/collectd/collectd/commit/cb19ecf90d89a79836b8b5236d2b66277dd79c5f > > It is currently enabled by default > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > Changes v1 -> v2 (after review of Asaf Kahlon): > - Add missing COLLECTD_ prefix for buddyinfo option in Config.in Applied to master, thanks. Thomas
diff --git a/package/collectd/Config.in b/package/collectd/Config.in index 3fc07a9014..54b218754a 100644 --- a/package/collectd/Config.in +++ b/package/collectd/Config.in @@ -128,6 +128,11 @@ config BR2_PACKAGE_COLLECTD_BIND help Collects BIND DNS statistics. +config BR2_PACKAGE_COLLECTD_BUDDYINFO + bool "buddyinfo" + help + Statistics from buddyinfo file about memory fragmentation. + config BR2_PACKAGE_COLLECTD_CAPABILITIES bool "capabilities" depends on BR2_aarch64 || BR2_i386 || BR2_x86_64 # dmidecode diff --git a/package/collectd/collectd.mk b/package/collectd/collectd.mk index f04ccdb2ff..6bd1754ad7 100644 --- a/package/collectd/collectd.mk +++ b/package/collectd/collectd.mk @@ -51,6 +51,7 @@ COLLECTD_CONF_OPTS += \ $(if $(BR2_PACKAGE_COLLECTD_APCUPS),--enable-apcups,--disable-apcups) \ $(if $(BR2_PACKAGE_COLLECTD_BATTERY),--enable-battery,--disable-battery) \ $(if $(BR2_PACKAGE_COLLECTD_BIND),--enable-bind,--disable-bind) \ + $(if $(BR2_PACKAGE_COLLECTD_BUDDYINFO),--enable-buddyinfo,--disable-buddyinfo) \ $(if $(BR2_PACKAGE_COLLECTD_CAPABILITIES),--enable-capabilities,--disable-capabilities) \ $(if $(BR2_PACKAGE_COLLECTD_CEPH),--enable-ceph,--disable-ceph) \ $(if $(BR2_PACKAGE_COLLECTD_CHRONY),--enable-chrony,--disable-chrony) \
buddyinfo is available since version 5.11.0 and https://github.com/collectd/collectd/commit/cb19ecf90d89a79836b8b5236d2b66277dd79c5f It is currently enabled by default Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- Changes v1 -> v2 (after review of Asaf Kahlon): - Add missing COLLECTD_ prefix for buddyinfo option in Config.in package/collectd/Config.in | 5 +++++ package/collectd/collectd.mk | 1 + 2 files changed, 6 insertions(+)