| Message ID | 20200326144436.529906-4-gary.bisson@boundarydevices.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | imx: update Boundary Devices boards support | expand |
Hello Gary, I was about to apply, but there are a few things that could be improved. See below. On Thu, 26 Mar 2020 15:44:36 +0100 Gary Bisson <gary.bisson@boundarydevices.com> wrote: > NXP i.MX8MMini based SBC with 2GB of LPDDR4 and 8GB eMMC. > > More details on the platform here: > https://boundarydevices.com/product/nitrogen8m-mini > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > --- > configs/nitrogen8mm_defconfig | 56 +++++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 configs/nitrogen8mm_defconfig Could you update board/boundary/common/readme.txt to also list this platform as being supported, and any other note that might be relevant ? > +BR2_TARGET_GENERIC_GETTY=y > +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc1" > +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh" > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh" Could you drop this script and use support/scripts/genimage.sh ? Indeed, it does the same thing, and in fact support/scripts/genimage.sh got fixed to use an empty rootpath and avoid a useless extra copy (commit 31d1fb27b0e62a6542112a7476ff188f2f7b8d38). It would be good to do that in a preparation commit for all existing Boundary Devices boards. Thanks! Thomas
Hi Thomas, On Thu, Mar 26, 2020 at 09:57:14PM +0100, Thomas Petazzoni wrote: > Hello Gary, > > I was about to apply, but there are a few things that could be > improved. See below. > > On Thu, 26 Mar 2020 15:44:36 +0100 > Gary Bisson <gary.bisson@boundarydevices.com> wrote: > > > NXP i.MX8MMini based SBC with 2GB of LPDDR4 and 8GB eMMC. > > > > More details on the platform here: > > https://boundarydevices.com/product/nitrogen8m-mini > > > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > > --- > > configs/nitrogen8mm_defconfig | 56 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > create mode 100644 configs/nitrogen8mm_defconfig > > Could you update board/boundary/common/readme.txt to also list this > platform as being supported, and any other note that might be relevant ? Yes good catch I'll make sure to update it. > > +BR2_TARGET_GENERIC_GETTY=y > > +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc1" > > +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh" > > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh" > > Could you drop this script and use support/scripts/genimage.sh ? > Indeed, it does the same thing, and in fact support/scripts/genimage.sh > got fixed to use an empty rootpath and avoid a useless extra copy > (commit 31d1fb27b0e62a6542112a7476ff188f2f7b8d38). Sure will do, didn't know about that script ;) > It would be good to do that in a preparation commit for all existing > Boundary Devices boards. Yep I'll align all boards to use that script. Thanks, Gary
diff --git a/configs/nitrogen8mm_defconfig b/configs/nitrogen8mm_defconfig new file mode 100644 index 0000000000..a7aa55c527 --- /dev/null +++ b/configs/nitrogen8mm_defconfig @@ -0,0 +1,56 @@ +# Architecture +BR2_aarch64=y +BR2_cortex_a53=y + +# System +BR2_TARGET_GENERIC_GETTY=y +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc1" +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh" +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh" +BR2_ROOTFS_POST_SCRIPT_ARGS="${UBOOT_DIR}/arch/arm/dts/imx8mm-nitrogen8mm.dtb" +BR2_PACKAGE_HOST_GENIMAGE=y +BR2_PACKAGE_HOST_IMX_MKIMAGE=y +BR2_PACKAGE_HOST_UBOOT_TOOLS=y +BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT=y + +# Filesystem +BR2_TARGET_ROOTFS_EXT2=y +BR2_TARGET_ROOTFS_EXT2_4=y + +# Linux headers same as kernel, a 4.14 series +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y + +# DDR training binaries +BR2_PACKAGE_FREESCALE_IMX=y +BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM=y +BR2_PACKAGE_FIRMWARE_IMX=y + +# ARM Trusted Firmware +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL=y +# Latest revision of branch boundary-imx_4.14.98_2.3.0 +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION="https://github.com/boundarydevices/imx-atf/archive/99e07a29.tar.gz" +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="imx8mm" +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y + +# Bootloader +BR2_TARGET_UBOOT=y +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nitrogen8mm_2g" +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y +BR2_TARGET_UBOOT_CUSTOM_TARBALL=y +# Latest revision of branch boundary-imx_v2018.07 +BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="https://github.com/boundarydevices/u-boot-imx6/archive/26bfd1de.tar.gz" +BR2_TARGET_UBOOT_FORMAT_CUSTOM=y +BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot-nodtb.bin" +BR2_TARGET_UBOOT_NEEDS_DTC=y +BR2_TARGET_UBOOT_SPL=y + +# Kernel +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_CUSTOM_TARBALL=y +# Latest revision of branch boundary-imx_4.14.x_2.0.0_ga +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="https://github.com/boundarydevices/linux-imx6/archive/208127fd.tar.gz" +BR2_LINUX_KERNEL_DEFCONFIG="boundary" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_INSTALL_TARGET=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/imx8mm-nitrogen8mm freescale/imx8mm-nitrogen8mm-m4 freescale/imx8mm-nitrogen8mm_rev2 freescale/imx8mm-nitrogen8mm_rev2-m4 freescale/imx8mm-nitrogen8mm_som freescale/imx8mm-nitrogen8mm_som-m4"
NXP i.MX8MMini based SBC with 2GB of LPDDR4 and 8GB eMMC. More details on the platform here: https://boundarydevices.com/product/nitrogen8m-mini Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> --- configs/nitrogen8mm_defconfig | 56 +++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 configs/nitrogen8mm_defconfig