| Message ID | 20200310081637.3288-1-kevin.lhopital@bootlin.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | package/ed: Bump to version 1.16 | expand |
Kévin, All, On 2020-03-10 09:16 +0100, Kévin L'hôpital spake thusly: > Signed-off-by: Kévin L'hôpital <kevin.lhopital@bootlin.com> Thanks for this patch. However I have a very minor comment, see below... > --- > package/ed/ed.hash | 4 ++-- > package/ed/ed.mk | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/package/ed/ed.hash b/package/ed/ed.hash > index 96c814d3c2..2544676b06 100644 > --- a/package/ed/ed.hash > +++ b/package/ed/ed.hash > @@ -1,4 +1,4 @@ > -# From http://lists.gnu.org/archive/html/bug-ed/2019-01/msg00010.html > -sha256 ad4489c0ad7a108c514262da28e6c2a426946fb408a3977ef1ed34308bdfd174 ed-1.15.tar.lz > +# From https://lists.gnu.org/archive/html/bug-ed/2020-02/msg00002.html > +sha256 cfc07a14ab048a758473ce222e784fbf031485bcd54a76f74acfee1f390d8b2c ed-1.16.tar.lz We're now trying to converge all our hash files to a common coding style, which is using two spaces btween fields: sha256 cfc07a14ab048a758473ce222e784fbf031485bcd54a76f74acfee1f390d8b2c ed-1.16.tar.lz > # Locally calculated > sha256 f03a12bef9dfb7281864a0dd965166d4f4ec7a66633df2bc72fa4363e57de02c COPYING Ditto for the hashes for license files. Care to fix and respin, please? (Usually, I'd have fixed while applying, but I have understood that it's part of your baptism of fire, so... ;-] ). Regards, Yann E. MORIN. > diff --git a/package/ed/ed.mk b/package/ed/ed.mk > index 6ef8f951cf..deb900e283 100644 > --- a/package/ed/ed.mk > +++ b/package/ed/ed.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -ED_VERSION = 1.15 > +ED_VERSION = 1.16 > ED_SITE = $(BR2_GNU_MIRROR)/ed > ED_SOURCE = ed-$(ED_VERSION).tar.lz > ED_LICENSE = GPL-3.0+ > -- > 2.17.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Le Tue, 17 Mar 2020 22:51:21 +0100, "Yann E. MORIN" <yann.morin.1998@free.fr> a écrit : Hello, > Kévin, All, > > On 2020-03-10 09:16 +0100, Kévin L'hôpital spake thusly: > > Signed-off-by: Kévin L'hôpital <kevin.lhopital@bootlin.com> > > Thanks for this patch. However I have a very minor comment, see > below... > > > --- > > package/ed/ed.hash | 4 ++-- > > package/ed/ed.mk | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/package/ed/ed.hash b/package/ed/ed.hash > > index 96c814d3c2..2544676b06 100644 > > --- a/package/ed/ed.hash > > +++ b/package/ed/ed.hash > > @@ -1,4 +1,4 @@ > > -# From > > http://lists.gnu.org/archive/html/bug-ed/2019-01/msg00010.html > > -sha256 > > ad4489c0ad7a108c514262da28e6c2a426946fb408a3977ef1ed34308bdfd174 > > ed-1.15.tar.lz +# From > > https://lists.gnu.org/archive/html/bug-ed/2020-02/msg00002.html > > +sha256 > > cfc07a14ab048a758473ce222e784fbf031485bcd54a76f74acfee1f390d8b2c > > ed-1.16.tar.lz > > We're now trying to converge all our hash files to a common coding > style, which is using two spaces btween fields: > sha256 > cfc07a14ab048a758473ce222e784fbf031485bcd54a76f74acfee1f390d8b2c > ed-1.16.tar.lz > > > # Locally calculated > > sha256 > > f03a12bef9dfb7281864a0dd965166d4f4ec7a66633df2bc72fa4363e57de02c > > COPYING > > Ditto for the hashes for license files. > > Care to fix and respin, please? > Thanks for the review, I will fix this. > (Usually, I'd have fixed while applying, but I have understood that > it's part of your baptism of fire, so... ;-] ). > Aha, all right, no problem ;-) Best regards, L'hôpital Kévin
diff --git a/package/ed/ed.hash b/package/ed/ed.hash index 96c814d3c2..2544676b06 100644 --- a/package/ed/ed.hash +++ b/package/ed/ed.hash @@ -1,4 +1,4 @@ -# From http://lists.gnu.org/archive/html/bug-ed/2019-01/msg00010.html -sha256 ad4489c0ad7a108c514262da28e6c2a426946fb408a3977ef1ed34308bdfd174 ed-1.15.tar.lz +# From https://lists.gnu.org/archive/html/bug-ed/2020-02/msg00002.html +sha256 cfc07a14ab048a758473ce222e784fbf031485bcd54a76f74acfee1f390d8b2c ed-1.16.tar.lz # Locally calculated sha256 f03a12bef9dfb7281864a0dd965166d4f4ec7a66633df2bc72fa4363e57de02c COPYING diff --git a/package/ed/ed.mk b/package/ed/ed.mk index 6ef8f951cf..deb900e283 100644 --- a/package/ed/ed.mk +++ b/package/ed/ed.mk @@ -4,7 +4,7 @@ # ################################################################################ -ED_VERSION = 1.15 +ED_VERSION = 1.16 ED_SITE = $(BR2_GNU_MIRROR)/ed ED_SOURCE = ed-$(ED_VERSION).tar.lz ED_LICENSE = GPL-3.0+
Signed-off-by: Kévin L'hôpital <kevin.lhopital@bootlin.com> --- package/ed/ed.hash | 4 ++-- package/ed/ed.mk | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)