| Message ID | 20200210064742.551472-1-joel@jms.id.au |
|---|---|
| State | Accepted |
| Headers | show |
| Series | package/eudev: Fix monitor starting | expand |
>>>>> "Joel" == Joel Stanley <joel@jms.id.au> writes: Hi, > When the kernel has CONFIG_SHMEM disabled /dev is a ramfs (instead of a > tmpfs) and the name_to_handle_at system call is not supported. This > causes eudev's monitor application to exit on startup. > Upstream eudev has added this fix which is not yet part of a release. > Signed-off-by: Joel Stanley <joel@jms.id.au> Extended the subject with to say '.. Fix monitor starting for kernels w/o CONFIG_SHMEM' and committed, thanks.
>>>>> "Joel" == Joel Stanley <joel@jms.id.au> writes: > When the kernel has CONFIG_SHMEM disabled /dev is a ramfs (instead of a > tmpfs) and the name_to_handle_at system call is not supported. This > causes eudev's monitor application to exit on startup. > Upstream eudev has added this fix which is not yet part of a release. > Signed-off-by: Joel Stanley <joel@jms.id.au> Committed to 2019.02.x and 2019.11.x, thanks.
diff --git a/package/eudev/0001-src-libudev-libudev-monitor.c-do-not-check-if-dev-is.patch b/package/eudev/0001-src-libudev-libudev-monitor.c-do-not-check-if-dev-is.patch new file mode 100644 index 000000000000..3027ad7f17b7 --- /dev/null +++ b/package/eudev/0001-src-libudev-libudev-monitor.c-do-not-check-if-dev-is.patch @@ -0,0 +1,33 @@ +From 799591c57368bbe47667f5b696050247a766b117 Mon Sep 17 00:00:00 2001 +From: "Anthony G. Basile" <blueness@gentoo.org> +Date: Mon, 6 Jan 2020 11:14:47 -0500 +Subject: [PATCH] src/libudev/libudev-monitor.c: do not check if /dev is tmpfs + +This check fails for buildroot systems where /dev is not mounted +as a tmpfs filesystem. Dropping this check should be safe even +on regular systems. + +This solves issue #172. + +Signed-off-by: Anthony G. Basile <blueness@gentoo.org> +Signed-off-by: Joel Stanley <joel@jms.id.au> +--- + src/libudev/libudev-monitor.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/libudev/libudev-monitor.c b/src/libudev/libudev-monitor.c +index 614149c6243c..060ba733f33b 100644 +--- a/src/libudev/libudev-monitor.c ++++ b/src/libudev/libudev-monitor.c +@@ -186,7 +186,7 @@ struct udev_monitor *udev_monitor_new_from_netlink_fd(struct udev *udev, const c + * We do not set a netlink multicast group here, so the socket + * will not receive any messages. + */ +- if (access(UDEV_ROOT_RUN "/udev/control", F_OK) < 0 || !udev_has_devtmpfs(udev)) { ++ if (access(UDEV_ROOT_RUN "/udev/control", F_OK) < 0) { + log_debug("the udev service seems not to be active, disable the monitor"); + group = UDEV_MONITOR_NONE; + } else +-- +2.25.0 +
When the kernel has CONFIG_SHMEM disabled /dev is a ramfs (instead of a tmpfs) and the name_to_handle_at system call is not supported. This causes eudev's monitor application to exit on startup. Upstream eudev has added this fix which is not yet part of a release. Signed-off-by: Joel Stanley <joel@jms.id.au> --- ...dev-monitor.c-do-not-check-if-dev-is.patch | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 package/eudev/0001-src-libudev-libudev-monitor.c-do-not-check-if-dev-is.patch