diff mbox series

package/asn1c: new host package

Message ID 20200110211420.7704-1-sergio.prado@e-labworks.com
State New
Headers show
Series package/asn1c: new host package | expand

Commit Message

Sergio Prado Jan. 10, 2020, 9:14 p.m. UTC
The asn1c is a free, open source compiler of ASN.1 specifications into C
source code.

Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
---
 DEVELOPERS                   |  1 +
 package/Config.in.host       |  1 +
 package/asn1c/Config.in.host | 11 +++++++++++
 package/asn1c/asn1c.hash     |  5 +++++
 package/asn1c/asn1c.mk       | 12 ++++++++++++
 5 files changed, 30 insertions(+)
 create mode 100644 package/asn1c/Config.in.host
 create mode 100644 package/asn1c/asn1c.hash
 create mode 100644 package/asn1c/asn1c.mk

Comments

Sergio Prado Feb. 27, 2020, 8:54 a.m. UTC | #1
Hi,

Does anyone had a chance to review this patch? Do I need to rebase it and
send again?

Sergio Prado
Embedded Labworks


Em sex., 10 de jan. de 2020 às 18:14, Sergio Prado <
sergio.prado@e-labworks.com> escreveu:

> The asn1c is a free, open source compiler of ASN.1 specifications into C
> source code.
>
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
> ---
>  DEVELOPERS                   |  1 +
>  package/Config.in.host       |  1 +
>  package/asn1c/Config.in.host | 11 +++++++++++
>  package/asn1c/asn1c.hash     |  5 +++++
>  package/asn1c/asn1c.mk       | 12 ++++++++++++
>  5 files changed, 30 insertions(+)
>  create mode 100644 package/asn1c/Config.in.host
>  create mode 100644 package/asn1c/asn1c.hash
>  create mode 100644 package/asn1c/asn1c.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 80843dd1a113..287e222cdf57 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2241,6 +2241,7 @@ N:        Sergio Prado <sergio.prado@e-labworks.com>
>  F:     board/toradex/apalis-imx6/
>  F:     configs/toradex_apalis_imx6_defconfig
>  F:     package/aoetools/
> +F:     package/asn1c/
>  F:     package/curlpp/
>  F:     package/daq/
>  F:     package/libgdiplus/
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 62e860d7c36c..a012ffaa38e9 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -2,6 +2,7 @@ menu "Host utilities"
>
>         source "package/aespipe/Config.in.host"
>         source "package/android-tools/Config.in.host"
> +       source "package/asn1c/Config.in.host"
>         source "package/btrfs-progs/Config.in.host"
>         source "package/cargo/Config.in.host"
>         source "package/cbootimage/Config.in.host"
> diff --git a/package/asn1c/Config.in.host b/package/asn1c/Config.in.host
> new file mode 100644
> index 000000000000..951f5f66915e
> --- /dev/null
> +++ b/package/asn1c/Config.in.host
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_HOST_ASN1C
> +       bool "host asn1c"
> +       help
> +         ASN.1 stands for Abstract Syntax Notation One and allows
> +         to describe complex data structures independently of any
> +         particular programming language.
> +
> +         The asn1c is a free, open source compiler of ASN.1
> +         specifications into C source code.
> +
> +         http://lionet.info/asn1c
> diff --git a/package/asn1c/asn1c.hash b/package/asn1c/asn1c.hash
> new file mode 100644
> index 000000000000..a4fd3beffa53
> --- /dev/null
> +++ b/package/asn1c/asn1c.hash
> @@ -0,0 +1,5 @@
> +# Locally computed:
> +sha256 8007440b647ef2dd9fb73d931c33ac11764e6afb2437dbe638bb4e5fc82386b9
> asn1c-0.9.28.tar.gz
> +
> +# Hash for license files:
> +sha256 bcc636802a52ace2255212be15fb707084af87061b5cfd37eb84dcf6a02cc48b
> LICENSE
> diff --git a/package/asn1c/asn1c.mk b/package/asn1c/asn1c.mk
> new file mode 100644
> index 000000000000..314462a92bf9
> --- /dev/null
> +++ b/package/asn1c/asn1c.mk
> @@ -0,0 +1,12 @@
>
> +################################################################################
> +#
> +# asn1c
> +#
>
> +################################################################################
> +
> +ASN1C_VERSION = 0.9.28
> +ASN1C_SITE =
> https://github.com/vlm/asn1c/releases/download/v$(ASN1C_VERSION)
> +ASN1C_LICENSE
> <https://github.com/vlm/asn1c/releases/download/v$(ASN1C_VERSION)+ASN1C_LICENSE>
> = BSD-2-Clause
> +ASN1C_LICENSE_FILES = LICENSE
> +
> +$(eval $(host-autotools-package))
> --
> 2.17.1
>
>
Heiko Thiery April 17, 2020, 1:28 p.m. UTC | #2
HI Sergio,

I tested the package with: utils/test-pkg -p host-asn1c
                             br-arm-full [1/6]: OK
                  br-arm-cortex-a9-glibc [2/6]: OK
                   br-arm-cortex-m4-full [3/6]: OK
                          br-x86-64-musl [4/6]: OK
                      br-arm-full-static [5/6]: OK
                            sourcery-arm [6/6]: OK

and it builds.

Just some small comment below:

Am Fr., 10. Jan. 2020 um 22:21 Uhr schrieb Sergio Prado
<sergio.prado@e-labworks.com>:
>
> The asn1c is a free, open source compiler of ASN.1 specifications into C
> source code.
>
> Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>

Reviewed-by: Heiko Thiery <heiko.thiery@gmail.com>

> ---
>  DEVELOPERS                   |  1 +
>  package/Config.in.host       |  1 +
>  package/asn1c/Config.in.host | 11 +++++++++++
>  package/asn1c/asn1c.hash     |  5 +++++
>  package/asn1c/asn1c.mk       | 12 ++++++++++++
>  5 files changed, 30 insertions(+)
>  create mode 100644 package/asn1c/Config.in.host
>  create mode 100644 package/asn1c/asn1c.hash
>  create mode 100644 package/asn1c/asn1c.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 80843dd1a113..287e222cdf57 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2241,6 +2241,7 @@ N:        Sergio Prado <sergio.prado@e-labworks.com>
>  F:     board/toradex/apalis-imx6/
>  F:     configs/toradex_apalis_imx6_defconfig
>  F:     package/aoetools/
> +F:     package/asn1c/
>  F:     package/curlpp/
>  F:     package/daq/
>  F:     package/libgdiplus/
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 62e860d7c36c..a012ffaa38e9 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -2,6 +2,7 @@ menu "Host utilities"
>
>         source "package/aespipe/Config.in.host"
>         source "package/android-tools/Config.in.host"
> +       source "package/asn1c/Config.in.host"
>         source "package/btrfs-progs/Config.in.host"
>         source "package/cargo/Config.in.host"
>         source "package/cbootimage/Config.in.host"
> diff --git a/package/asn1c/Config.in.host b/package/asn1c/Config.in.host
> new file mode 100644
> index 000000000000..951f5f66915e
> --- /dev/null
> +++ b/package/asn1c/Config.in.host
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_HOST_ASN1C
> +       bool "host asn1c"
> +       help
> +         ASN.1 stands for Abstract Syntax Notation One and allows
> +         to describe complex data structures independently of any
> +         particular programming language.
> +
> +         The asn1c is a free, open source compiler of ASN.1
> +         specifications into C source code.
> +
> +         http://lionet.info/asn1c
> diff --git a/package/asn1c/asn1c.hash b/package/asn1c/asn1c.hash
> new file mode 100644
> index 000000000000..a4fd3beffa53
> --- /dev/null
> +++ b/package/asn1c/asn1c.hash
> @@ -0,0 +1,5 @@
> +# Locally computed:
> +sha256 8007440b647ef2dd9fb73d931c33ac11764e6afb2437dbe638bb4e5fc82386b9  asn1c-0.9.28.tar.gz
> +
> +# Hash for license files:
> +sha256 bcc636802a52ace2255212be15fb707084af87061b5cfd37eb84dcf6a02cc48b  LICENSE
> diff --git a/package/asn1c/asn1c.mk b/package/asn1c/asn1c.mk
> new file mode 100644
> index 000000000000..314462a92bf9
> --- /dev/null
> +++ b/package/asn1c/asn1c.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# asn1c
> +#
> +################################################################################
> +
> +ASN1C_VERSION = 0.9.28
> +ASN1C_SITE = https://github.com/vlm/asn1c/releases/download/v$(ASN1C_VERSION)

You can use the github macro to set the <pkg>_SITE variable:
ASN1C_SITE = $(call github,vlm,asn1c,v$(ASN1C_VERSION))

> +ASN1C_LICENSE = BSD-2-Clause
> +ASN1C_LICENSE_FILES = LICENSE
> +
> +$(eval $(host-autotools-package))
> --
> 2.17.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Sergio Prado April 17, 2020, 6:20 p.m. UTC | #3
Hi Heiko,

Thanks a lot for the review. I'll send V2.

Best regards,

Sergio Prado
Embedded Labworks

Em sex., 17 de abr. de 2020 às 10:28, Heiko Thiery <heiko.thiery@gmail.com>
escreveu:

> HI Sergio,
>
> I tested the package with: utils/test-pkg -p host-asn1c
>                              br-arm-full [1/6]: OK
>                   br-arm-cortex-a9-glibc [2/6]: OK
>                    br-arm-cortex-m4-full [3/6]: OK
>                           br-x86-64-musl [4/6]: OK
>                       br-arm-full-static [5/6]: OK
>                             sourcery-arm [6/6]: OK
>
> and it builds.
>
> Just some small comment below:
>
> Am Fr., 10. Jan. 2020 um 22:21 Uhr schrieb Sergio Prado
> <sergio.prado@e-labworks.com>:
> >
> > The asn1c is a free, open source compiler of ASN.1 specifications into C
> > source code.
> >
> > Signed-off-by: Sergio Prado <sergio.prado@e-labworks.com>
>
> Reviewed-by: Heiko Thiery <heiko.thiery@gmail.com>
>
> > ---
> >  DEVELOPERS                   |  1 +
> >  package/Config.in.host       |  1 +
> >  package/asn1c/Config.in.host | 11 +++++++++++
> >  package/asn1c/asn1c.hash     |  5 +++++
> >  package/asn1c/asn1c.mk       | 12 ++++++++++++
> >  5 files changed, 30 insertions(+)
> >  create mode 100644 package/asn1c/Config.in.host
> >  create mode 100644 package/asn1c/asn1c.hash
> >  create mode 100644 package/asn1c/asn1c.mk
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 80843dd1a113..287e222cdf57 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -2241,6 +2241,7 @@ N:        Sergio Prado <
> sergio.prado@e-labworks.com>
> >  F:     board/toradex/apalis-imx6/
> >  F:     configs/toradex_apalis_imx6_defconfig
> >  F:     package/aoetools/
> > +F:     package/asn1c/
> >  F:     package/curlpp/
> >  F:     package/daq/
> >  F:     package/libgdiplus/
> > diff --git a/package/Config.in.host b/package/Config.in.host
> > index 62e860d7c36c..a012ffaa38e9 100644
> > --- a/package/Config.in.host
> > +++ b/package/Config.in.host
> > @@ -2,6 +2,7 @@ menu "Host utilities"
> >
> >         source "package/aespipe/Config.in.host"
> >         source "package/android-tools/Config.in.host"
> > +       source "package/asn1c/Config.in.host"
> >         source "package/btrfs-progs/Config.in.host"
> >         source "package/cargo/Config.in.host"
> >         source "package/cbootimage/Config.in.host"
> > diff --git a/package/asn1c/Config.in.host b/package/asn1c/Config.in.host
> > new file mode 100644
> > index 000000000000..951f5f66915e
> > --- /dev/null
> > +++ b/package/asn1c/Config.in.host
> > @@ -0,0 +1,11 @@
> > +config BR2_PACKAGE_HOST_ASN1C
> > +       bool "host asn1c"
> > +       help
> > +         ASN.1 stands for Abstract Syntax Notation One and allows
> > +         to describe complex data structures independently of any
> > +         particular programming language.
> > +
> > +         The asn1c is a free, open source compiler of ASN.1
> > +         specifications into C source code.
> > +
> > +         http://lionet.info/asn1c
> > diff --git a/package/asn1c/asn1c.hash b/package/asn1c/asn1c.hash
> > new file mode 100644
> > index 000000000000..a4fd3beffa53
> > --- /dev/null
> > +++ b/package/asn1c/asn1c.hash
> > @@ -0,0 +1,5 @@
> > +# Locally computed:
> > +sha256
> 8007440b647ef2dd9fb73d931c33ac11764e6afb2437dbe638bb4e5fc82386b9
> asn1c-0.9.28.tar.gz
> > +
> > +# Hash for license files:
> > +sha256
> bcc636802a52ace2255212be15fb707084af87061b5cfd37eb84dcf6a02cc48b  LICENSE
> > diff --git a/package/asn1c/asn1c.mk b/package/asn1c/asn1c.mk
> > new file mode 100644
> > index 000000000000..314462a92bf9
> > --- /dev/null
> > +++ b/package/asn1c/asn1c.mk
> > @@ -0,0 +1,12 @@
> >
> +################################################################################
> > +#
> > +# asn1c
> > +#
> >
> +################################################################################
> > +
> > +ASN1C_VERSION = 0.9.28
> > +ASN1C_SITE =
> https://github.com/vlm/asn1c/releases/download/v$(ASN1C_VERSION)
>
> You can use the github macro to set the <pkg>_SITE variable:
> ASN1C_SITE = $(call github,vlm,asn1c,v$(ASN1C_VERSION))
>
> > +ASN1C_LICENSE = BSD-2-Clause
> > +ASN1C_LICENSE_FILES = LICENSE
> > +
> > +$(eval $(host-autotools-package))
> > --
> > 2.17.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> BR,
> Heiko
>
Baruch Siach April 19, 2020, 3:41 a.m. UTC | #4
Hi Heiko, Sergio,

On Fri, Apr 17 2020, Heiko Thiery wrote:
>> +ASN1C_VERSION = 0.9.28
>> +ASN1C_SITE = https://github.com/vlm/asn1c/releases/download/v$(ASN1C_VERSION)
>
> You can use the github macro to set the <pkg>_SITE variable:
> ASN1C_SITE = $(call github,vlm,asn1c,v$(ASN1C_VERSION))

When the package author provides a tarball we usually prefer to use it.

  If the package you wish to add does have a release section on GitHub,
  the maintainer may have uploaded a release tarball, or the release may
  just point to the automatically generated tarball from the git tag. If
  there is a release tarball uploaded by the maintainer, we prefer to use
  that since it may be slightly different (e.g. it contains a configure
  script so we don’t need to do AUTORECONF).

This is quoted from
https://buildroot.org/downloads/manual/manual.html#github-download-url

In this case the tarball indeed contains a pre-generated configure
script.

baruch

--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
Heiko Thiery April 19, 2020, 5:39 a.m. UTC | #5
Hi Baruch, Hi Sergio,

Am So., 19. Apr. 2020 um 05:41 Uhr schrieb Baruch Siach <baruch@tkos.co.il>:
>
> Hi Heiko, Sergio,
>
> On Fri, Apr 17 2020, Heiko Thiery wrote:
> >> +ASN1C_VERSION = 0.9.28
> >> +ASN1C_SITE = https://github.com/vlm/asn1c/releases/download/v$(ASN1C_VERSION)
> >
> > You can use the github macro to set the <pkg>_SITE variable:
> > ASN1C_SITE = $(call github,vlm,asn1c,v$(ASN1C_VERSION))
>
> When the package author provides a tarball we usually prefer to use it.
>
>   If the package you wish to add does have a release section on GitHub,
>   the maintainer may have uploaded a release tarball, or the release may
>   just point to the automatically generated tarball from the git tag. If
>   there is a release tarball uploaded by the maintainer, we prefer to use
>   that since it may be slightly different (e.g. it contains a configure
>   script so we don’t need to do AUTORECONF).
>
> This is quoted from
> https://buildroot.org/downloads/manual/manual.html#github-download-url
>
> In this case the tarball indeed contains a pre-generated configure
> script.
>

You're right. The released version should be preferred.

> baruch
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Sorry for that mistake.
Sergio Prado April 19, 2020, 12:47 p.m. UTC | #6
Hi Heiko, Baruch,

So it looks like I don't need to rework the patch, thanks.

Best regards,

Sergio Prado
Embedded Labworks
Mobile: +55 11 97123-3420


Em dom., 19 de abr. de 2020 às 02:39, Heiko Thiery <heiko.thiery@gmail.com>
escreveu:

> Hi Baruch, Hi Sergio,
>
> Am So., 19. Apr. 2020 um 05:41 Uhr schrieb Baruch Siach <baruch@tkos.co.il
> >:
> >
> > Hi Heiko, Sergio,
> >
> > On Fri, Apr 17 2020, Heiko Thiery wrote:
> > >> +ASN1C_VERSION = 0.9.28
> > >> +ASN1C_SITE =
> https://github.com/vlm/asn1c/releases/download/v$(ASN1C_VERSION)
> > >
> > > You can use the github macro to set the <pkg>_SITE variable:
> > > ASN1C_SITE = $(call github,vlm,asn1c,v$(ASN1C_VERSION))
> >
> > When the package author provides a tarball we usually prefer to use it.
> >
> >   If the package you wish to add does have a release section on GitHub,
> >   the maintainer may have uploaded a release tarball, or the release may
> >   just point to the automatically generated tarball from the git tag. If
> >   there is a release tarball uploaded by the maintainer, we prefer to use
> >   that since it may be slightly different (e.g. it contains a configure
> >   script so we don’t need to do AUTORECONF).
> >
> > This is quoted from
> > https://buildroot.org/downloads/manual/manual.html#github-download-url
> >
> > In this case the tarball indeed contains a pre-generated configure
> > script.
> >
>
> You're right. The released version should be preferred.
>
> > baruch
> >
> > --
> >      http://baruch.siach.name/blog/                  ~. .~   Tk Open
> Systems
> >
> =}------------------------------------------------ooO--U--Ooo------------{=
> >    - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
>
> Sorry for that mistake.
>
> --
> Heiko
>
diff mbox series

Patch

diff --git a/DEVELOPERS b/DEVELOPERS
index 80843dd1a113..287e222cdf57 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2241,6 +2241,7 @@  N:	Sergio Prado <sergio.prado@e-labworks.com>
 F:	board/toradex/apalis-imx6/
 F:	configs/toradex_apalis_imx6_defconfig
 F:	package/aoetools/
+F:	package/asn1c/
 F:	package/curlpp/
 F:	package/daq/
 F:	package/libgdiplus/
diff --git a/package/Config.in.host b/package/Config.in.host
index 62e860d7c36c..a012ffaa38e9 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -2,6 +2,7 @@  menu "Host utilities"
 
 	source "package/aespipe/Config.in.host"
 	source "package/android-tools/Config.in.host"
+	source "package/asn1c/Config.in.host"
 	source "package/btrfs-progs/Config.in.host"
 	source "package/cargo/Config.in.host"
 	source "package/cbootimage/Config.in.host"
diff --git a/package/asn1c/Config.in.host b/package/asn1c/Config.in.host
new file mode 100644
index 000000000000..951f5f66915e
--- /dev/null
+++ b/package/asn1c/Config.in.host
@@ -0,0 +1,11 @@ 
+config BR2_PACKAGE_HOST_ASN1C
+	bool "host asn1c"
+	help
+	  ASN.1 stands for Abstract Syntax Notation One and allows
+	  to describe complex data structures independently of any
+	  particular programming language.
+
+	  The asn1c is a free, open source compiler of ASN.1
+	  specifications into C source code.
+
+	  http://lionet.info/asn1c
diff --git a/package/asn1c/asn1c.hash b/package/asn1c/asn1c.hash
new file mode 100644
index 000000000000..a4fd3beffa53
--- /dev/null
+++ b/package/asn1c/asn1c.hash
@@ -0,0 +1,5 @@ 
+# Locally computed:
+sha256 8007440b647ef2dd9fb73d931c33ac11764e6afb2437dbe638bb4e5fc82386b9  asn1c-0.9.28.tar.gz
+
+# Hash for license files:
+sha256 bcc636802a52ace2255212be15fb707084af87061b5cfd37eb84dcf6a02cc48b  LICENSE
diff --git a/package/asn1c/asn1c.mk b/package/asn1c/asn1c.mk
new file mode 100644
index 000000000000..314462a92bf9
--- /dev/null
+++ b/package/asn1c/asn1c.mk
@@ -0,0 +1,12 @@ 
+################################################################################
+#
+# asn1c
+#
+################################################################################
+
+ASN1C_VERSION = 0.9.28
+ASN1C_SITE = https://github.com/vlm/asn1c/releases/download/v$(ASN1C_VERSION)
+ASN1C_LICENSE = BSD-2-Clause
+ASN1C_LICENSE_FILES = LICENSE
+
+$(eval $(host-autotools-package))