diff mbox series

[1/2] board/imx6-sabresd: Fix the Qt5 display names

Message ID 20191223122253.8238-1-festevam@gmail.com
State Accepted
Headers show
Series [1/2] board/imx6-sabresd: Fix the Qt5 display names | expand

Commit Message

Fabio Estevam Dec. 23, 2019, 12:22 p.m. UTC
The correct syntax that Qt5 understands for display names is
"HDMI1" and "LVDS1", so fix it accordingly.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni Dec. 23, 2019, 8:02 p.m. UTC | #1
On Mon, 23 Dec 2019 09:22:52 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> The correct syntax that Qt5 understands for display names is
> "HDMI1" and "LVDS1", so fix it accordingly.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Both applied. Thanks!

Thomas
Peter Korsgaard Dec. 25, 2019, 9:46 p.m. UTC | #2
>>>>> "Fabio" == Fabio Estevam <festevam@gmail.com> writes:

 > The correct syntax that Qt5 understands for display names is
 > "HDMI1" and "LVDS1", so fix it accordingly.

 > Signed-off-by: Fabio Estevam <festevam@gmail.com>

Committed to 2019.11.x, thanks.
Michael Nazzareno Trimarchi Dec. 25, 2019, 9:48 p.m. UTC | #3
Hi Fabio and Jagan

On Mon, Dec 23, 2019 at 1:23 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> The correct syntax that Qt5 understands for display names is
> "HDMI1" and "LVDS1", so fix it accordingly.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json b/board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json
> index d5d063af87..fe92ce5b29 100644
> --- a/board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json
> +++ b/board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json
> @@ -4,11 +4,11 @@
>    "pbuffers": true,
>    "outputs": [
>      {
> -      "name": "HDMI-1",
> +      "name": "HDMI1",
>        "mode": "off"
>      },
>      {
> -      "name": "LVDS-1",
> +      "name": "LVDS1",
>        "mode": "1024x768"
>      }
>    ]

Do the engicam board has the same problem? I can not test right now

Michael
> --
> 2.17.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Fabio Estevam Dec. 25, 2019, 10 p.m. UTC | #4
Hi Michael,

On Wed, Dec 25, 2019 at 6:49 PM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:

> Do the engicam board has the same problem? I can not test right now

Yes, I can send a fix tomorrow for the engicam .json files.
Michael Nazzareno Trimarchi Dec. 25, 2019, 10:06 p.m. UTC | #5
Hi

On Wed, Dec 25, 2019 at 11:00 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Michael,
>
> On Wed, Dec 25, 2019 at 6:49 PM Michael Nazzareno Trimarchi
> <michael@amarulasolutions.com> wrote:
>
> > Do the engicam board has the same problem? I can not test right now
>
> Yes, I can send a fix tomorrow for the engicam .json files.

Good, I can't just test right now. I have already here but I think
that we need to test it

Michael
diff mbox series

Patch

diff --git a/board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json b/board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json
index d5d063af87..fe92ce5b29 100644
--- a/board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json
+++ b/board/freescale/imx6-sabresd/rootfs_overlay/root/sabresd.json
@@ -4,11 +4,11 @@ 
   "pbuffers": true,
   "outputs": [
     {
-      "name": "HDMI-1",
+      "name": "HDMI1",
       "mode": "off"
     },
     {
-      "name": "LVDS-1",
+      "name": "LVDS1",
       "mode": "1024x768"
     }
   ]