diff mbox series

[1/2] package/openvmtools: non-executable udev rules

Message ID 20191129142248.6053-1-p.debruijn@unilogic.nl
State Accepted
Headers show
Series [1/2] package/openvmtools: non-executable udev rules | expand

Commit Message

Pascal de Bruijn Nov. 29, 2019, 2:22 p.m. UTC 
Fixes: /usr/lib/udev/rules.d/99-vmware-scsi-udev.rules is marked executable.

Source: https://github.com/vmware/open-vm-tools/pull/376

Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
---
 .../0009-Set-permissions-on-rules-file.patch       | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/openvmtools/0009-Set-permissions-on-rules-file.patch

Comments

Peter Korsgaard Dec. 1, 2019, 6:02 p.m. UTC | #1 
>>>>> "Pascal" == Pascal de Bruijn <p.debruijn@unilogic.nl> writes:

 > Fixes: /usr/lib/udev/rules.d/99-vmware-scsi-udev.rules is marked executable.
 > Source: https://github.com/vmware/open-vm-tools/pull/376

 > Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>

Committed after extending the commit message, thanks.
diff mbox series

Patch

diff --git a/package/openvmtools/0009-Set-permissions-on-rules-file.patch b/package/openvmtools/0009-Set-permissions-on-rules-file.patch
new file mode 100644
index 0000000..6a37c16
--- /dev/null
+++ b/package/openvmtools/0009-Set-permissions-on-rules-file.patch
@@ -0,0 +1,23 @@ 
+From c3ef6a8285132871ad10f9300d8afff55d8d6de2 Mon Sep 17 00:00:00 2001
+From: puneetse <22071208+puneetse@users.noreply.github.com>
+Date: Wed, 16 Oct 2019 10:09:38 -0700
+Subject: [PATCH] Set permissions on rules file
+
+udevs rules should not be executable otherwise udev will log a warning in the journal
+
+Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
+---
+ udev/Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/udev/Makefile.am b/udev/Makefile.am
+index 68fbc3e27..8b9a4d716 100644
+--- a/udev/Makefile.am
++++ b/udev/Makefile.am
+@@ -17,5 +17,5 @@
+ 
+ install-data-local:
+ 	$(INSTALL) -d $(DESTDIR)$(UDEVRULESDIR)
+-	$(INSTALL) $(srcdir)/99-vmware-scsi-udev.rules $(DESTDIR)$(UDEVRULESDIR)
++	$(INSTALL) -m 0644 $(srcdir)/99-vmware-scsi-udev.rules $(DESTDIR)$(UDEVRULESDIR)
+