diff mbox series

package/modem-manager: bump to version 1.12.0

Message ID 20191107114003.1038623-1-aleksander@aleksander.es
State Accepted
Headers show
Series package/modem-manager: bump to version 1.12.0 | expand

Commit Message

Aleksander Morgado Nov. 7, 2019, 11:40 a.m. UTC
Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---
 package/modem-manager/modem-manager.hash | 2 +-
 package/modem-manager/modem-manager.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Carlos Santos Nov. 7, 2019, 12:32 p.m. UTC | #1
On Thu, Nov 7, 2019 at 8:40 AM Aleksander Morgado
<aleksander@aleksander.es> wrote:
>
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> ---
>  package/modem-manager/modem-manager.hash | 2 +-
>  package/modem-manager/modem-manager.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
> index fc826a6121..b1fef98fe2 100644
> --- a/package/modem-manager/modem-manager.hash
> +++ b/package/modem-manager/modem-manager.hash
> @@ -1,4 +1,4 @@
>  # Locally computed
> -sha256  cbe174078dbdf3f746a55f0004353d3c27da2a31da553036d90fc7dc34a0169a  ModemManager-1.10.8.tar.xz
> +sha256  3daca86164145fffb589939433f596c13fa077c9a187c0d5820fdd5b4e4a6424  ModemManager-1.12.0.tar.xz
>  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
>  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index a5f3d63560..b5aa7914f6 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>
> -MODEM_MANAGER_VERSION = 1.10.8
> +MODEM_MANAGER_VERSION = 1.12.0
>  MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
>  MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
>  MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> --
> 2.24.0
>

I see "telit: fix crash if AT$GPSP=? is supported but no GPS data
port" in the Changelog. Is this a critical fix? If not, it should be
applied do next, since the 2019.11 release cycle has started.

Anyway,

Reviewed-by: Carlos Santos <unixmania@gmail.com>
Aleksander Morgado Nov. 7, 2019, 12:37 p.m. UTC | #2
On Thu, Nov 7, 2019 at 1:32 PM Carlos Santos <unixmania@gmail.com> wrote:
>
> On Thu, Nov 7, 2019 at 8:40 AM Aleksander Morgado
> <aleksander@aleksander.es> wrote:
> >
> > Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> > ---
> >  package/modem-manager/modem-manager.hash | 2 +-
> >  package/modem-manager/modem-manager.mk   | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
> > index fc826a6121..b1fef98fe2 100644
> > --- a/package/modem-manager/modem-manager.hash
> > +++ b/package/modem-manager/modem-manager.hash
> > @@ -1,4 +1,4 @@
> >  # Locally computed
> > -sha256  cbe174078dbdf3f746a55f0004353d3c27da2a31da553036d90fc7dc34a0169a  ModemManager-1.10.8.tar.xz
> > +sha256  3daca86164145fffb589939433f596c13fa077c9a187c0d5820fdd5b4e4a6424  ModemManager-1.12.0.tar.xz
> >  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
> >  sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
> > diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> > index a5f3d63560..b5aa7914f6 100644
> > --- a/package/modem-manager/modem-manager.mk
> > +++ b/package/modem-manager/modem-manager.mk
> > @@ -4,7 +4,7 @@
> >  #
> >  ################################################################################
> >
> > -MODEM_MANAGER_VERSION = 1.10.8
> > +MODEM_MANAGER_VERSION = 1.12.0
> >  MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> >  MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> >  MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> > --
> > 2.24.0
> >
>
> I see "telit: fix crash if AT$GPSP=? is supported but no GPS data
> port" in the Changelog. Is this a critical fix? If not, it should be
> applied do next, since the 2019.11 release cycle has started.
>

That commit you pointed out is not applicable to the 1.10.8 release
that we had before.

The 1.12.0 release is a major stable release, with lots of new changes
w.r.t. the old 1.10.x stable releases, see:
https://lists.freedesktop.org/archives/modemmanager-devel/2019-November/007476.html

It may be better applied to next then? I'm not sure how the release
cycles look like in buildroot, truth be told... :/
Thomas Petazzoni Nov. 7, 2019, 9:34 p.m. UTC | #3
On Thu, 7 Nov 2019 09:32:02 -0300
Carlos Santos <unixmania@gmail.com> wrote:

> On Thu, Nov 7, 2019 at 8:40 AM Aleksander Morgado
> <aleksander@aleksander.es> wrote:
> >
> > Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> > ---
> >  package/modem-manager/modem-manager.hash | 2 +-
> >  package/modem-manager/modem-manager.mk   | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)

For some reason, I don't see in my mailbox the original e-mail from
Aleksander, but the patch was in patchwork. Anyway, I've applied to
next. Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/modem-manager/modem-manager.hash b/package/modem-manager/modem-manager.hash
index fc826a6121..b1fef98fe2 100644
--- a/package/modem-manager/modem-manager.hash
+++ b/package/modem-manager/modem-manager.hash
@@ -1,4 +1,4 @@ 
 # Locally computed
-sha256  cbe174078dbdf3f746a55f0004353d3c27da2a31da553036d90fc7dc34a0169a  ModemManager-1.10.8.tar.xz
+sha256  3daca86164145fffb589939433f596c13fa077c9a187c0d5820fdd5b4e4a6424  ModemManager-1.12.0.tar.xz
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LIB
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
index a5f3d63560..b5aa7914f6 100644
--- a/package/modem-manager/modem-manager.mk
+++ b/package/modem-manager/modem-manager.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-MODEM_MANAGER_VERSION = 1.10.8
+MODEM_MANAGER_VERSION = 1.12.0
 MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
 MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
 MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)