[14/15] package/targetcli-fb: adapt to preset-all

Message ID	20191103165640.21819-15-jeremy.rosen@smile.fr
State	Superseded
Headers	show Return-Path: <buildroot-bounces@busybox.net> From: =?utf-8?b?SsOpcsOpbXkgUm9zZW4=?= <jeremy.rosen@smile.fr> To: buildroot@buildroot.org Date: Sun, 3 Nov 2019 17:56:39 +0100 Message-Id: <20191103165640.21819-15-jeremy.rosen@smile.fr> In-Reply-To: <20191103165640.21819-1-jeremy.rosen@smile.fr> References: <20191103165640.21819-1-jeremy.rosen@smile.fr> MIME-Version: 1.0 Subject: [Buildroot] [PATCH 14/15] package/targetcli-fb: adapt to preset-all Precedence: list Cc: =?utf-8?b?SsOpcsOpbXkgUm9zZW4=?= <jeremy.rosen@smile.fr> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net>
Series	use host-systemd to enable units \| expand [00/15] use host-systemd to enable units [01/15] new recipe : host-systemd [02/15] use host-systemctl preset all to enable units [03/15] fix tty handling [04/15] fix trivial packages with buildroot-provided services [05/15] fix trivial cases, upstream-provided services [06/15] package/avahi: adapt to preset-all [07/15] package/connman: adapt to preset-all [08/15] package/dante: adapt to preset-all [09/15] package/linuxptp adapt to preset-all [10/15] package/docker-engine: adapt to preset-all [11/15] package/network-manager: adapt to preset-all [12/15] package/wpa_supplicant: adapt for preset-all [13/15] package/sysklogd: adapt to preset-all [14/15] package/targetcli-fb: adapt to preset-all [15/15] package/tor: adapt to preset-all

Message ID

20191103165640.21819-15-jeremy.rosen@smile.fr

State

Superseded

Headers

From: =?utf-8?b?SsOpcsOpbXkgUm9zZW4=?= <jeremy.rosen@smile.fr>
To: buildroot@buildroot.org
Date: Sun,  3 Nov 2019 17:56:39 +0100
Message-Id: <20191103165640.21819-15-jeremy.rosen@smile.fr>
In-Reply-To: <20191103165640.21819-1-jeremy.rosen@smile.fr>
References: <20191103165640.21819-1-jeremy.rosen@smile.fr>
MIME-Version: 1.0
Subject: [Buildroot] [PATCH 14/15] package/targetcli-fb: adapt to preset-all
Precedence: list
Cc: =?utf-8?b?SsOpcsOpbXkgUm9zZW4=?= <jeremy.rosen@smile.fr>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Errors-To: buildroot-bounces@busybox.net
Sender: "buildroot" <buildroot-bounces@busybox.net>

Series

use host-systemd to enable units | expand

Commit Message

Jérémy ROSEN Nov. 3, 2019, 4:56 p.m. UTC

the service was not enabled, we now need to disable it explicitely

Signed-off-by: Jérémy Rosen <jeremy.rosen@smile.fr>
---
 package/targetcli-fb/50-targetcli-fb.preset | 1 +
 package/targetcli-fb/targetcli-fb.mk        | 2 ++
 2 files changed, 3 insertions(+)
 create mode 100644 package/targetcli-fb/50-targetcli-fb.preset

Comments

James Hilliard Nov. 3, 2019, 5:34 p.m. UTC | #1

On Sun, Nov 3, 2019 at 11:57 AM Jérémy Rosen <jeremy.rosen@smile.fr> wrote:
>
> the service was not enabled, we now need to disable it explicitly
Is there a reason we should not have this enabled? It not being enable looks to
be a bug.
>
> Signed-off-by: Jérémy Rosen <jeremy.rosen@smile.fr>
> ---
>  package/targetcli-fb/50-targetcli-fb.preset | 1 +
>  package/targetcli-fb/targetcli-fb.mk        | 2 ++
>  2 files changed, 3 insertions(+)
>  create mode 100644 package/targetcli-fb/50-targetcli-fb.preset
>
> diff --git a/package/targetcli-fb/50-targetcli-fb.preset b/package/targetcli-fb/50-targetcli-fb.preset
> new file mode 100644
> index 0000000000..572ee4fb93
> --- /dev/null
> +++ b/package/targetcli-fb/50-targetcli-fb.preset
> @@ -0,0 +1 @@
> +disable target.service.service
> diff --git a/package/targetcli-fb/targetcli-fb.mk b/package/targetcli-fb/targetcli-fb.mk
> index 75643446d2..5e50643bc9 100644
> --- a/package/targetcli-fb/targetcli-fb.mk
> +++ b/package/targetcli-fb/targetcli-fb.mk
> @@ -21,6 +21,8 @@ endef
>  define TARGETCLI_FB_INSTALL_INIT_SYSTEMD
>         $(INSTALL) -m 0644 -D package/targetcli-fb/target.service \
>                 $(TARGET_DIR)/usr/lib/systemd/system/target.service
> +       $(INSTALL) -D -m 644 package/targetcli-fb/50-targetcli-fb.preset \
> +               $(TARGET_DIR)/usr/lib/systemd/system-preset/50-targetcli-fb.preset
>  endef
>
>  # Targetcli stores its configuration in /etc/target/saveconfig.json
> --
> 2.24.0.rc1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

diff --git a/package/targetcli-fb/50-targetcli-fb.preset b/package/targetcli-fb/50-targetcli-fb.preset
new file mode 100644
index 0000000000..572ee4fb93
--- /dev/null
+++ b/package/targetcli-fb/50-targetcli-fb.preset
@@ -0,0 +1 @@ 
+disable target.service.service
diff --git a/package/targetcli-fb/targetcli-fb.mk b/package/targetcli-fb/targetcli-fb.mk
index 75643446d2..5e50643bc9 100644
--- a/package/targetcli-fb/targetcli-fb.mk
+++ b/package/targetcli-fb/targetcli-fb.mk
@@ -21,6 +21,8 @@  endef
 define TARGETCLI_FB_INSTALL_INIT_SYSTEMD
 	$(INSTALL) -m 0644 -D package/targetcli-fb/target.service \
 		$(TARGET_DIR)/usr/lib/systemd/system/target.service
+	$(INSTALL) -D -m 644 package/targetcli-fb/50-targetcli-fb.preset \
+		$(TARGET_DIR)/usr/lib/systemd/system-preset/50-targetcli-fb.preset
 endef
 
 # Targetcli stores its configuration in /etc/target/saveconfig.json

[14/15] package/targetcli-fb: adapt to preset-all

Commit Message

Comments

Patch