diff mbox series

package/python-autobahn: add missing dependency on C++

Message ID 20191029203701.9558-1-arnout@mind.be
State Accepted
Commit a0e9caf40d7080c91279f2dbd6036c13d8ccd65a
Headers show
Series package/python-autobahn: add missing dependency on C++ | expand

Commit Message

Arnout Vandecappelle Oct. 29, 2019, 8:37 p.m. UTC
The indirect dependency via python-cryptography was not set in the
Config.in.

Detected with randconfig.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/python-autobahn/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Peter Korsgaard Nov. 1, 2019, 7:19 a.m. UTC | #1
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > The indirect dependency via python-cryptography was not set in the
 > Config.in.

 > Detected with randconfig.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

You forgot to propagate this to the reverse dependencies (daphne,
channels, channels-redis).

Committed with that fixes, thanks.

 > ---
 >  package/python-autobahn/Config.in | 4 ++++
 >  1 file changed, 4 insertions(+)

 > diff --git a/package/python-autobahn/Config.in b/package/python-autobahn/Config.in
 > index e08d5d58a1..ba54d8b12f 100644
 > --- a/package/python-autobahn/Config.in
 > +++ b/package/python-autobahn/Config.in
 > @@ -1,5 +1,6 @@
 >  config BR2_PACKAGE_PYTHON_AUTOBAHN
 >  	bool "python-autobahn"
 > +	depends on BR2_INSTALL_LIBSTDCPP # python-cryptography -> python-pyasn
 >  	select BR2_PACKAGE_PYTHON_CRYPTOGRAPHY # runtime
 >  	select BR2_PACKAGE_PYTHON_SIX # runtime
 >  	select BR2_PACKAGE_PYTHON_TXAIO # runtime
 > @@ -8,3 +9,6 @@ config BR2_PACKAGE_PYTHON_AUTOBAHN
 >  	  framework.
 
 >  	  https://pypi.python.org/pypi/autobahn
 > +
 > +comment "python-autobahn needs a toolchain w/ C++"
 > +	depends on !BR2_INSTALL_LIBSTDCPP
 > -- 
 > 2.21.0

 > _______________________________________________
 > buildroot mailing list
 > buildroot@busybox.net
 > http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Nov. 6, 2019, 10:42 p.m. UTC | #2
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > The indirect dependency via python-cryptography was not set in the
 > Config.in.

 > Detected with randconfig.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed to 2019.08.x (2019.02.x has an older autobahn not using cryptography), thanks.
diff mbox series

Patch

diff --git a/package/python-autobahn/Config.in b/package/python-autobahn/Config.in
index e08d5d58a1..ba54d8b12f 100644
--- a/package/python-autobahn/Config.in
+++ b/package/python-autobahn/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_PYTHON_AUTOBAHN
 	bool "python-autobahn"
+	depends on BR2_INSTALL_LIBSTDCPP # python-cryptography -> python-pyasn
 	select BR2_PACKAGE_PYTHON_CRYPTOGRAPHY # runtime
 	select BR2_PACKAGE_PYTHON_SIX # runtime
 	select BR2_PACKAGE_PYTHON_TXAIO # runtime
@@ -8,3 +9,6 @@  config BR2_PACKAGE_PYTHON_AUTOBAHN
 	  framework.
 
 	  https://pypi.python.org/pypi/autobahn
+
+comment "python-autobahn needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP