| Message ID | 20191004183132.15564-16-asafka7@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/python-pysnmp-apps: bump to version 0.5.3 | expand |
On Fri, 4 Oct 2019 21:31:22 +0300 Asaf Kahlon <asafka7@gmail.com> wrote: > Also add hash for license file. > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > --- > package/python-pysnmp-apps/python-pysnmp-apps.hash | 8 +++++--- > package/python-pysnmp-apps/python-pysnmp-apps.mk | 5 ++--- > 2 files changed, 7 insertions(+), 6 deletions(-) I have applied. However, your patch made me re-read the LICENSE file, and it's BSD-2-Clause, while our .mk file says it's BSD-3-Clause. Since it's a bug not introduced by your patch, I applied your patch as-is. Could you send a follow-up patch fixing the _LICENSE variable in the .mk file ? This way, we can backport it to our LTS branch. Thanks, Thomas
Hello, I've sent a follow-up patch with the _LICENSE update. Moreover, when I look at the github repository of this application I see the application is now called to snmpclitools and the original repository seems to be empty (just a readme with a reference to the new one). What is the desired solution for that case? Should we just add the new package or should we also remove the current pysnmp-apps package? Thanks, Asaf. On Sun, Oct 6, 2019 at 12:08 AM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Fri, 4 Oct 2019 21:31:22 +0300 > Asaf Kahlon <asafka7@gmail.com> wrote: > > > Also add hash for license file. > > > > Signed-off-by: Asaf Kahlon <asafka7@gmail.com> > > --- > > package/python-pysnmp-apps/python-pysnmp-apps.hash | 8 +++++--- > > package/python-pysnmp-apps/python-pysnmp-apps.mk | 5 ++--- > > 2 files changed, 7 insertions(+), 6 deletions(-) > > I have applied. However, your patch made me re-read the LICENSE file, > and it's BSD-2-Clause, while our .mk file says it's BSD-3-Clause. Since > it's a bug not introduced by your patch, I applied your patch as-is. > Could you send a follow-up patch fixing the _LICENSE variable in the > .mk file ? This way, we can backport it to our LTS branch. > > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
Hello, On Tue, 8 Oct 2019 07:43:50 +0300 Asaf Kahlon <asafka7@gmail.com> wrote: > I've sent a follow-up patch with the _LICENSE update. Thanks! > Moreover, when I look at the github repository of this application I > see the application is now called to snmpclitools and the original > repository seems to be empty (just a readme with a reference to the > new one). > What is the desired solution for that case? Should we just add the new > package or should we also remove the current pysnmp-apps package? Both: we add the new package, and remove python-pysnmp-apps. Thanks! Thomas
diff --git a/package/python-pysnmp-apps/python-pysnmp-apps.hash b/package/python-pysnmp-apps/python-pysnmp-apps.hash index 2b865cbce9..42120486d9 100644 --- a/package/python-pysnmp-apps/python-pysnmp-apps.hash +++ b/package/python-pysnmp-apps/python-pysnmp-apps.hash @@ -1,3 +1,5 @@ -# md5 from https://pypi.python.org/pypi/pysnmp-apps/json, sha256 locally computed -md5 7fc08e2d81a77d558b38be5e49ff833e pysnmp-apps-0.4.1.tar.gz -sha256 57accb8c2fcb255b4da85af07ef9cd6a266dc5143b2834419ec8a39a879edeb7 pysnmp-apps-0.4.1.tar.gz +# md5, sha256 from https://pypi.org/pypi/pysnmp-apps/json +md5 ed3e4d421bb0e1806298120313efccc2 pysnmp-apps-0.5.3.tar.gz +sha256 bf4ea6f3054a25b05e255d29e0b57a8aa8102f509048e3a9c0d93ddc86aff570 pysnmp-apps-0.5.3.tar.gz +# Locally computed sha256 checksums +sha256 f82128f64d567c333936a12b99a21d0e8cd66ce628d51ce0a7770cc38dc7fe43 LICENSE.txt diff --git a/package/python-pysnmp-apps/python-pysnmp-apps.mk b/package/python-pysnmp-apps/python-pysnmp-apps.mk index 79c436fa73..ee494eba0f 100644 --- a/package/python-pysnmp-apps/python-pysnmp-apps.mk +++ b/package/python-pysnmp-apps/python-pysnmp-apps.mk @@ -4,13 +4,12 @@ # ################################################################################ -PYTHON_PYSNMP_APPS_VERSION = 0.4.1 +PYTHON_PYSNMP_APPS_VERSION = 0.5.3 PYTHON_PYSNMP_APPS_SOURCE = pysnmp-apps-$(PYTHON_PYSNMP_APPS_VERSION).tar.gz -PYTHON_PYSNMP_APPS_SITE = https://pypi.python.org/packages/source/p/pysnmp-apps +PYTHON_PYSNMP_APPS_SITE = https://files.pythonhosted.org/packages/c2/1a/26f5f3732df2c7d34663a7f2fa6534b5b4ffae73a4a440b75864ec826ba6 PYTHON_PYSNMP_APPS_SETUP_TYPE = setuptools PYTHON_PYSNMP_APPS_LICENSE = BSD-3-Clause PYTHON_PYSNMP_APPS_LICENSE_FILES = LICENSE.txt - PYTHON_PYSNMP_APPS_DEPENDENCIES = python-pysnmp $(eval $(python-package))
Also add hash for license file. Signed-off-by: Asaf Kahlon <asafka7@gmail.com> --- package/python-pysnmp-apps/python-pysnmp-apps.hash | 8 +++++--- package/python-pysnmp-apps/python-pysnmp-apps.mk | 5 ++--- 2 files changed, 7 insertions(+), 6 deletions(-)