From patchwork Fri Aug 2 08:29:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnout Vandecappelle X-Patchwork-Id: 1141029 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mind.be Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mind-be.20150623.gappssmtp.com header.i=@mind-be.20150623.gappssmtp.com header.b="OTzMCjkV"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 460L1m6hLtz9s7T for ; Fri, 2 Aug 2019 18:29:48 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 4114D2046D; Fri, 2 Aug 2019 08:29:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6DBAkk-KZxOw; Fri, 2 Aug 2019 08:29:44 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 9A6AA20472; Fri, 2 Aug 2019 08:29:44 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 588C31BF232 for ; Fri, 2 Aug 2019 08:29:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 549C22046D for ; Fri, 2 Aug 2019 08:29:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V0k8L3wESsIY for ; Fri, 2 Aug 2019 08:29:40 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by silver.osuosl.org (Postfix) with ESMTPS id 43B6520472 for ; Fri, 2 Aug 2019 08:29:38 +0000 (UTC) Received: by mail-wr1-f49.google.com with SMTP id g17so76254447wrr.5 for ; Fri, 02 Aug 2019 01:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mind-be.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Vac1gfDxz5IoWXlg29b7pnuXkk51nBn42HqFCbwQtgw=; b=OTzMCjkVVlRnxDC0YZewv8mAQN/qP19RPG+33ApNyb590EDhV6XbOSvnavNgydYodZ 1bFjiyxx5H8AmPC/5OwR+3Y9p1wR5MpBLwBiUTPFJN2bYGN8lZiGG77I1cAq5Xo2tuaH qnvriqZiRBiNHra5pf6Bsmy8g/Sg63oDdOBmedLxvMyPZ3++WUDM8HxeQ5J6hBNKJVAM eBjMDcULpzWptdvuePcPS7hd3AV2ADTmF49a2clwZa00blKkclus2KkOB2MwMcZovklJ U75S6Tc6xYpFTma445JeMBTo06jIHo+M7bVPME8Foz8bDJZVYQ+eN46zLx8RdxnNorEM cm/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Vac1gfDxz5IoWXlg29b7pnuXkk51nBn42HqFCbwQtgw=; b=gAcU9Z6v3pTRkFicoONrGLB5s/4uF11TLF+LhAx/Nj9TIxP7S20JHevwK+xANFTOI/ jMLdHH78g4RtKWAXL+K6SiDcf3fHAxQrqTJ459wisOKjFWOIbiX6pYLqx/WOvis55LHI 1AQvvHuGUidYubWm4qirg90yRVMU2MQW/cXMGN5adRUrR1Tz7/Ub2nsCFMwHX9Cg0DqM u1YHeTQYyEQ4JM79BR46/+F9uN5LklPVketLTySOriLpkey+rohQjlnCuOJvKFeANMDB 4wMENufGtGorYDtmTftUL0GE+D8mEo8qT/xMo9HttECkosWks+Qdqce3cJ8TIU/yNubr YX0A== X-Gm-Message-State: APjAAAUXvq0l8+xZUr2dWKpYhiq47tZt2rHfgxPDLCNtrxXIBGTaaWdL IdJ6Ov4SSrp4tjiEylQyFzs0ZNh5QKY= X-Google-Smtp-Source: APXvYqx3M0/LVNWJpidXaQdxJwPAsMHfhWJnqqiB4J+pBazIZbgpcPgFFUKcrMQ3Xtb9eFwgwJFopA== X-Received: by 2002:a5d:4206:: with SMTP id n6mr78605436wrq.110.1564734576402; Fri, 02 Aug 2019 01:29:36 -0700 (PDT) Received: from arnoutx1.home ([2a01:cb19:8acf:5600:3b0f:2669:24db:51d0]) by smtp.gmail.com with ESMTPSA id y16sm160208913wrg.85.2019.08.02.01.29.35 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 02 Aug 2019 01:29:35 -0700 (PDT) From: "Arnout Vandecappelle (Essensium/Mind)" To: buildroot@buildroot.org Date: Fri, 2 Aug 2019 10:29:34 +0200 Message-Id: <20190802082935.26747-1-arnout@mind.be> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/2] utils/checkpackagelib: CommentsMenusPackagesOrder: properly initialize levels X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Fix an issue introduced by Arnout while committing. Jerzy originally initialized the menu_of_packages, package and print_package_warning members like they should be, but Arnout thought it wasn't needed and removed that. It is actually needed, to make sure the top level (level 0) works. Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/264383157 Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- utils/checkpackagelib/lib_config.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utils/checkpackagelib/lib_config.py b/utils/checkpackagelib/lib_config.py index 26349fb681..225f92af13 100644 --- a/utils/checkpackagelib/lib_config.py +++ b/utils/checkpackagelib/lib_config.py @@ -61,9 +61,9 @@ class AttributesOrder(_CheckFunction): class CommentsMenusPackagesOrder(_CheckFunction): - menu_of_packages = [] - package = [] - print_package_warning = [] + menu_of_packages = [""] + package = [""] + print_package_warning = [True] def before(self): self.state = ""