diff mbox series

[v2,6/6] package/gstreamer1/gst1-rtsp-server: convert package type to meson

Message ID 20190710153634.25235-7-aduskett@gmail.com
State Changes Requested
Headers show
Series gstreamer1: convert packages to meson | expand

Commit Message

Adam Duskett July 10, 2019, 3:36 p.m. UTC
From: Adam Duskett <Aduskett@gmail.com>

GStreamer 1.16.0 is the last version to support autotools, and will be removed
in the next version.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Peter Seiderer July 10, 2019, 9:22 p.m. UTC | #1
Hello Adam,

On Wed, 10 Jul 2019 11:36:34 -0400, aduskett@gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
>
> GStreamer 1.16.0 is the last version to support autotools, and will be removed
> in the next version.

See previous patch...

>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
>  package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk b/package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk
> index 34869863d9..bd2d7c741e 100644
> --- a/package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk
> +++ b/package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk
> @@ -16,6 +16,11 @@ GST1_RTSP_SERVER_DEPENDENCIES = \
>  	gst1-plugins-base \
>  	gst1-plugins-good
>
> +GST1_RTSP_SERVER_CONF_OPTS += \
> +	-Dexamples=disabled \
> +	-Dtests=disabled \
> +	-Dintrospection=disabled

Missing:

+	-Dgobject-cast-checks=disabled \
+	-Dglib-asserts=disabled \
+	-Dglib-checks=disabled \

> +
>  ifeq ($(BR2_PACKAGE_LIBCGROUP),y)
>  GST1_RTSP_SERVER_DEPENDENCIES += libcgroup
>  endif
> @@ -24,4 +29,4 @@ ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD),y)
>  GST1_RTSP_SERVER_DEPENDENCIES += gst1-plugins-bad
>  endif

Please add:

# These plugins are listed in the order from meson_options.txt
GST1_RTSP_SERVER_CONF_OPTS = \
	-Drtspclientsink=enabled

Regards,
Peter

>
> -$(eval $(autotools-package))
> +$(eval $(meson-package))
diff mbox series

Patch

diff --git a/package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk b/package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk
index 34869863d9..bd2d7c741e 100644
--- a/package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk
+++ b/package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk
@@ -16,6 +16,11 @@  GST1_RTSP_SERVER_DEPENDENCIES = \
 	gst1-plugins-base \
 	gst1-plugins-good
 
+GST1_RTSP_SERVER_CONF_OPTS += \
+	-Dexamples=disabled \
+	-Dtests=disabled \
+	-Dintrospection=disabled
+
 ifeq ($(BR2_PACKAGE_LIBCGROUP),y)
 GST1_RTSP_SERVER_DEPENDENCIES += libcgroup
 endif
@@ -24,4 +29,4 @@  ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD),y)
 GST1_RTSP_SERVER_DEPENDENCIES += gst1-plugins-bad
 endif
 
-$(eval $(autotools-package))
+$(eval $(meson-package))