Message ID | 20190614210346.121013-21-giulio.benetti@micronovasrl.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <buildroot-bounces@busybox.net> X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=micronovasrl.com Authentication-Results: ozlabs.org; dkim=fail reason="key not found in DNS" (0-bit key; unprotected) header.d=micronovasrl.com header.i=@micronovasrl.com header.b="SJppvtfC"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45QY6Z458wz9s3Z for <incoming-buildroot@patchwork.ozlabs.org>; Sat, 15 Jun 2019 07:05:42 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id F3DB52302C; Fri, 14 Jun 2019 21:05:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eAI8R8F3D+gJ; Fri, 14 Jun 2019 21:05:39 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id A9C50230A4; Fri, 14 Jun 2019 21:05:39 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 671571BF291 for <buildroot@lists.busybox.net>; Fri, 14 Jun 2019 21:05:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6169686AB7 for <buildroot@lists.busybox.net>; Fri, 14 Jun 2019 21:05:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q0GlCkbDSLND for <buildroot@lists.busybox.net>; Fri, 14 Jun 2019 21:05:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.micronovasrl.com (mail.micronovasrl.com [212.103.203.10]) by fraxinus.osuosl.org (Postfix) with ESMTP id A0EF286AB0 for <buildroot@buildroot.org>; Fri, 14 Jun 2019 21:05:37 +0000 (UTC) Received: from mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) by mail.micronovasrl.com (Postfix) with ESMTP id BC0F5B00EBF for <buildroot@buildroot.org>; Fri, 14 Jun 2019 23:05:36 +0200 (CEST) Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=micronovasrl.com; h=references:in-reply-to:x-mailer:message-id:date:date:subject :subject:to:from:from; s=dkim; t=1560546335; x=1561410336; bh=zf QOh8of6JnGV27y0+kB8y3l1QM4LvHDIqhbtniKpYs=; b=SJppvtfCvL1UjV66co sI9SeFe3Riz4WTW80ovTHyCaYxEKRhe6ehaRCCE6AA3gbfleAp2N+J9FY0yEdlyj 0DRGvkDXXhtE9Vsdge3tBUL75cgwDat49qxvs+1Ds0VpI759JjBteMcoV+CoQ/n2 Mf9faeHLAOepIDy3oZ4b5Z0v0= X-Virus-Scanned: Debian amavisd-new at mail.micronovasrl.com Received: from mail.micronovasrl.com ([127.0.0.1]) by mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8PHen-VOp3EO for <buildroot@buildroot.org>; Fri, 14 Jun 2019 23:05:35 +0200 (CEST) Received: from ubuntu.localdomain (88-149-228-83.v4.ngi.it [88.149.228.83]) by mail.micronovasrl.com (Postfix) with ESMTPSA id 8CBA9B015D6; Fri, 14 Jun 2019 23:04:11 +0200 (CEST) From: Giulio Benetti <giulio.benetti@micronovasrl.com> To: buildroot@buildroot.org Date: Fri, 14 Jun 2019 23:03:39 +0200 Message-Id: <20190614210346.121013-21-giulio.benetti@micronovasrl.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190614210346.121013-1-giulio.benetti@micronovasrl.com> References: <20190614210346.121013-1-giulio.benetti@micronovasrl.com> Subject: [Buildroot] [PATCH 20/27] package/dmalloc: re-enable package on microblaze X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot <buildroot.busybox.net> List-Unsubscribe: <http://lists.busybox.net/mailman/options/buildroot>, <mailto:buildroot-request@busybox.net?subject=unsubscribe> List-Archive: <http://lists.busybox.net/pipermail/buildroot/> List-Post: <mailto:buildroot@busybox.net> List-Help: <mailto:buildroot-request@busybox.net?subject=help> List-Subscribe: <http://lists.busybox.net/mailman/listinfo/buildroot>, <mailto:buildroot-request@busybox.net?subject=subscribe> Cc: Joseph Kogut <joseph.kogut@gmail.com>, Bernd Kuhls <bernd.kuhls@t-online.de>, Sergio Prado <sergio.prado@e-labworks.com>, Marcin Bis <marcin@bis.org.pl>, Maxime Ripard <maxime.ripard@bootlin.com>, Davide Viti <zinosat@tiscali.it>, Peter Seiderer <ps.report@gmx.net>, =?utf-8?q?Ga=C3=ABl_Portay?= <gael.portay@collabora.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Jeremy Rosen <jeremy.rosen@openwide.fr>, Romain Naour <romain.naour@gmail.com>, Fabrice Fontaine <fontaine.fabrice@gmail.com>, "Yann E . MORIN" <yann.morin.1998@free.fr>, Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net> |
Series |
[01/27] package/keyutils: re-enable package on microblaze
|
expand
|
diff --git a/package/dmalloc/Config.in b/package/dmalloc/Config.in index e5be109332..0c01970b04 100644 --- a/package/dmalloc/Config.in +++ b/package/dmalloc/Config.in @@ -1,9 +1,5 @@ config BR2_PACKAGE_DMALLOC bool "dmalloc" - # On some packages, Microblaze gcc has issues when debugging - # symbols are enabled: "Error: operation combines symbols in - # different segments". - depends on !(BR2_microblaze && BR2_ENABLE_DEBUG) help A debug memory allocation library which is a drop in replacement for the system's malloc, realloc, calloc, free and diff --git a/package/dmalloc/dmalloc.mk b/package/dmalloc/dmalloc.mk index 6ebb44c5c0..38b2c02027 100644 --- a/package/dmalloc/dmalloc.mk +++ b/package/dmalloc/dmalloc.mk @@ -35,6 +35,10 @@ ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y) DMALLOC_CFLAGS += -marm endif +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_63261),y) +DMALLOC_CFLAGS += -O0 +endif + DMALLOC_CONF_ENV = CFLAGS="$(DMALLOC_CFLAGS)" define DMALLOC_POST_PATCH
With Microblaze Gcc version < 8.x build gives: 'Error: operation combines symbols in different segments' This is due to bug 63261: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63261. To avoid this, the dmalloc package has a !BR2_microblaze dependency. However, gcc bug 63261 only triggers when optimization is enabled, so we can work around the issue by passing -O0, which is what we do in other Buildroot packages to work around this bug. So, this commit passes -O0 when BR2_TOOLCHAIN_HAS_GCC_BUG_63261, and re-enables dmalloc on Microblaze. Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> --- package/dmalloc/Config.in | 4 ---- package/dmalloc/dmalloc.mk | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-)