| Message ID | 20190610101924.9124-2-juju@cotds.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | configs/imx8mmpico: new defconfig | expand |
Hi Julien, On 10/06/2019 12:19, Julien Olivain wrote: > The i.MX8MMini is slightly different from the i.MX8M. The main > difference of interrest here is that the i.MX8MMini has no HDMI > support. The boot image must not include the HDMI signed firmware, > which is why we need this new configuration option. > > Signed-off-by: Julien Olivain <juju@cotds.org> > --- > package/freescale-imx/Config.in | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in > index fcceacdc9e..f010aab87b 100644 > --- a/package/freescale-imx/Config.in > +++ b/package/freescale-imx/Config.in > @@ -43,6 +43,9 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 > config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M > bool "imx8m" > > +config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM > + bool "imx8mm" > + > config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X > bool "imx8x" > endchoice > @@ -77,7 +80,8 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU > default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q || \ > BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S || \ > BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 || \ > - BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M > + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M || \ > + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM Here, you set BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU, but you don't add a value for BR2_PACKAGE_FREESCALE_IMX_PLATFORM, which will be used by the imx-lib package. Now, I don't think the imx-lib package is even relevant for imx8, but it *can* be built... Or maybe we should revisit the conditions on that package. Also, in imx-gpu-viv/Config.in, for IMX8M, only the wayland output is enabled, but now for IMX8MM, you allow all outputs. Is that intended? Anyway, these things can be fixed up in follow-up patches, if needed, so I've applied the entire series to master, thanks. Regards, Arnout > > source "package/freescale-imx/imx-alsa-plugins/Config.in" > source "package/freescale-imx/imx-codec/Config.in" >
diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in index fcceacdc9e..f010aab87b 100644 --- a/package/freescale-imx/Config.in +++ b/package/freescale-imx/Config.in @@ -43,6 +43,9 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M bool "imx8m" +config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM + bool "imx8mm" + config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8X bool "imx8x" endchoice @@ -77,7 +80,8 @@ config BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU default y if BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q || \ BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6S || \ BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 || \ - BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M || \ + BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8MM source "package/freescale-imx/imx-alsa-plugins/Config.in" source "package/freescale-imx/imx-codec/Config.in"
The i.MX8MMini is slightly different from the i.MX8M. The main difference of interrest here is that the i.MX8MMini has no HDMI support. The boot image must not include the HDMI signed firmware, which is why we need this new configuration option. Signed-off-by: Julien Olivain <juju@cotds.org> --- package/freescale-imx/Config.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)