diff mbox series

[1/1] package/python-xlib: bump to version 0.25

Message ID 20190219003956.112503-1-joseph.kogut@gmail.com
State Superseded
Headers show
Series [1/1] package/python-xlib: bump to version 0.25 | expand

Commit Message

Joseph Kogut Feb. 19, 2019, 12:39 a.m. UTC
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
Changes v1 -> v2:
- Fix LICENSE checksum

 package/python-xlib/python-xlib.hash | 9 +++++----
 package/python-xlib/python-xlib.mk   | 4 ++--
 2 files changed, 7 insertions(+), 6 deletions(-)

--
2.20.1

Comments

Thomas Petazzoni Feb. 19, 2019, 8:25 a.m. UTC | #1
Hello Joseph,

Thanks for this new iteration!

This patch should be [PATCH v2], you can use "git format-patch -v2" to
do this. Having such versions in the subject prefix is really useful
for the people reviewing/merging the patches.

On Mon, 18 Feb 2019 16:39:56 -0800
Joseph Kogut <joseph.kogut@gmail.com> wrote:

> Changes v1 -> v2:
> - Fix LICENSE checksum

And what are the changes in the license file ? The entire reason for
having those hashes is to notice when the license terms are changed. If
we blindly update the hash without looking at the license file changes,
the hash is a bit useless.

Could you update the commit log to explain that the hash of the license
file is changed, and what are the changes in the license file ? If it's
just a simple update of the copyright date, just say so.

Thanks a lot!

Thomas
diff mbox series

Patch

diff --git a/package/python-xlib/python-xlib.hash b/package/python-xlib/python-xlib.hash
index 2c4861af5c..e51461fc2b 100644
--- a/package/python-xlib/python-xlib.hash
+++ b/package/python-xlib/python-xlib.hash
@@ -1,4 +1,5 @@ 
-# md5 from https://pypi.python.org/pypi/python-xlib/json, sha256 locally computed
-md5 cdf342aa145c2be0ccae46cfb7b62551 python-xlib-0.21.tar.bz2
-sha256 25aad0056172920552c01a163e979b02336abaf47b0792dae9c93ecb29500431 python-xlib-0.21.tar.bz2
-sha256 9b872a8a070b8ad329c4bd380fb1bf0000f564c75023ec8e1e6803f15364b9e9 LICENSE
+# md5, sha256 from https://pypi.org/pypi/python-xlib/json
+md5 ded820dc8e943106bd660801ed7a82f7 python-xlib-0.25.tar.bz2
+sha256 204f280b549352af6cbdaff43405186822ae05749518dd9be209bd88a0088f99 python-xlib-0.25.tar.bz2
+# Locally computed sha256 checksums
+sha256 06eb1c441443cf15ac84f309003f4c43c62246939d37c75fc3e056c2d34cd300 LICENSE
diff --git a/package/python-xlib/python-xlib.mk b/package/python-xlib/python-xlib.mk
index 0ce6e43422..3ffc4e2ee1 100644
--- a/package/python-xlib/python-xlib.mk
+++ b/package/python-xlib/python-xlib.mk
@@ -4,9 +4,9 @@ 
 #
 ################################################################################

-PYTHON_XLIB_VERSION = 0.21
+PYTHON_XLIB_VERSION = 0.25
 PYTHON_XLIB_SOURCE = python-xlib-$(PYTHON_XLIB_VERSION).tar.bz2
-PYTHON_XLIB_SITE = https://pypi.python.org/packages/eb/de/b0eaaea7b8512dc41504db071824eef30293ff55c58d83081ebaebe85a38
+PYTHON_XLIB_SITE = https://files.pythonhosted.org/packages/3c/d9/51fc07ae57f6a44e62e2ee04bd501d763ac169ff05c838403ec7ae556992
 PYTHON_XLIB_SETUP_TYPE = setuptools
 PYTHON_XLIB_LICENSE = LGPL-2.1+
 PYTHON_XLIB_LICENSE_FILES = LICENSE