| Message ID | 20181226223112.24456-7-nerv@dawncrow.de |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/9] board/freescale/imx8mqevk: Fix typos in readme | expand |
Hi André, On Wed, Dec 26, 2018 at 8:34 PM André Hentschel <nerv@dawncrow.de> wrote: > > Signed-off-by: André Hentschel <nerv@dawncrow.de> Please add a simple commit log and state the imx8 variants that will be supported.
Am 27.12.18 um 16:40 schrieb Fabio Estevam: > Hi André, > > On Wed, Dec 26, 2018 at 8:34 PM André Hentschel <nerv@dawncrow.de> wrote: >> >> Signed-off-by: André Hentschel <nerv@dawncrow.de> > > Please add a simple commit log and state the imx8 variants that will > be supported. Thanks for having a look. I'll test it as soon as I have access to the board again. For the meantime my updated changes can be found here (untested): https://github.com/AndreRH/buildroot/tree/c2810022babfef0b1236237e463f34a3ce32bc82
Hi André, On Sat, Dec 29, 2018 at 12:20 PM André Hentschel <nerv@dawncrow.de> wrote: > Thanks for having a look. > I'll test it as soon as I have access to the board again. > For the meantime my updated changes can be found here (untested): > https://github.com/AndreRH/buildroot/tree/c2810022babfef0b1236237e463f34a3ce32bc82 Nice work! Looking forward to seeing more imx8 SoCs supported in Buildroot :-)
diff --git a/package/imx-mkimage/imx-mkimage.mk b/package/imx-mkimage/imx-mkimage.mk index cde4fefcea..36e25c2a7c 100644 --- a/package/imx-mkimage/imx-mkimage.mk +++ b/package/imx-mkimage/imx-mkimage.mk @@ -11,15 +11,25 @@ IMX_MKIMAGE_LICENSE = GPL-2.0+ IMX_MKIMAGE_LICENSE_FILES = iMX8dv/COPYING HOST_IMX_MKIMAGE_DEPENDENCIES = host-zlib +ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M),y) define HOST_IMX_MKIMAGE_BUILD_CMDS - # Currently this only supports iMX8M. When more hardware is available - # this needs to be selectable based on iMX8-version (iMX8M,iMXQ etc). $(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)/iMX8M -f soc.mak mkimage_imx8 endef +else +define HOST_IMX_MKIMAGE_BUILD_CMDS + $(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D) MKIMG=mkimage_imx8 mkimage_imx8 +endef +endif +ifeq ($(BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M),y) define HOST_IMX_MKIMAGE_INSTALL_CMDS $(INSTALL) -D -m 755 $(@D)/iMX8M/mkimage_imx8 $(HOST_DIR)/bin/mkimage_imx8 $(INSTALL) -D -m 755 $(@D)/iMX8M/mkimage_fit_atf.sh $(HOST_DIR)/bin/mkimage_fit_atf.sh endef +else +define HOST_IMX_MKIMAGE_INSTALL_CMDS + $(INSTALL) -D -m 755 $(@D)/mkimage_imx8 $(HOST_DIR)/bin/mkimage_imx8 +endef +endif $(eval $(host-generic-package))
Signed-off-by: André Hentschel <nerv@dawncrow.de> --- package/imx-mkimage/imx-mkimage.mk | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)