diff mbox series

[2/2] webkitgtk: fix host dependencies

Message ID 20181225080009.25780-2-francois.perrad@gadz.org
State Accepted
Headers show
Series [1/2] webkitgtk: remove an old workaround | expand

Commit Message

Francois Perrad Dec. 25, 2018, 8 a.m. UTC
python 2.7 is required by the cmake stuff.
bison & flex are not used in the webkitgtk tree.

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/webkitgtk/webkitgtk.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Adrian Perez de Castro Dec. 25, 2018, 5:57 p.m. UTC | #1
Hello François,

Thanks for seding these cleanups, they look good to me.

On Tue, 25 Dec 2018 09:00:09 +0100, Francois Perrad <fperrad@gmail.com> wrote:
> python 2.7 is required by the cmake stuff.
> bison & flex are not used in the webkitgtk tree.
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

Acked-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/webkitgtk/webkitgtk.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index e03fd969e..80daadd15 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -12,7 +12,7 @@ WEBKITGTK_LICENSE = LGPL-2.1+, BSD-2-Clause
>  WEBKITGTK_LICENSE_FILES = \
>  	Source/WebCore/LICENSE-APPLE \
>  	Source/WebCore/LICENSE-LGPL-2.1
> -WEBKITGTK_DEPENDENCIES = host-ruby host-flex host-bison host-gperf \
> +WEBKITGTK_DEPENDENCIES = host-ruby host-python host-gperf \
>  	enchant harfbuzz icu jpeg libgcrypt libgtk3 libsecret libsoup \
>  	libtasn1 libxml2 libxslt sqlite webp woff2
>  WEBKITGTK_CONF_OPTS = \
Peter Korsgaard Jan. 1, 2019, 4 p.m. UTC | #2
>>>>> "Francois" == Francois Perrad <fperrad@gmail.com> writes:

 > python 2.7 is required by the cmake stuff.
 > bison & flex are not used in the webkitgtk tree.

 > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

Committed to 2018.02.x and 2018.11.x, thanks.
diff mbox series

Patch

diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index e03fd969e..80daadd15 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -12,7 +12,7 @@  WEBKITGTK_LICENSE = LGPL-2.1+, BSD-2-Clause
 WEBKITGTK_LICENSE_FILES = \
 	Source/WebCore/LICENSE-APPLE \
 	Source/WebCore/LICENSE-LGPL-2.1
-WEBKITGTK_DEPENDENCIES = host-ruby host-flex host-bison host-gperf \
+WEBKITGTK_DEPENDENCIES = host-ruby host-python host-gperf \
 	enchant harfbuzz icu jpeg libgcrypt libgtk3 libsecret libsoup \
 	libtasn1 libxml2 libxslt sqlite webp woff2
 WEBKITGTK_CONF_OPTS = \