diff mbox series

[1/2] package/llvm: bump to version 7.0.1

Message ID 20181224115041.426-1-valentinkorenblit@gmail.com
State Changes Requested
Headers show
Series [1/2] package/llvm: bump to version 7.0.1 | expand

Commit Message

Valentin Korenblit Dec. 24, 2018, 11:50 a.m. UTC 
llvmpipe tested on Raspberry Pi 3
---
 package/llvm/llvm.hash | 2 +-
 package/llvm/llvm.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Romain Naour Dec. 24, 2018, 1:01 p.m. UTC | #1 
Hi Valentin,

Le 24/12/2018 à 12:50, Valentin Korenblit a écrit :
> llvmpipe tested on Raspberry Pi 3

Thanks for your work and testing on llvm/clang update.

Maybe you can add a small comment about the ABI issue discovered in llvm 7:
http://lists.llvm.org/pipermail/llvm-announce/2018-December/000081.html

and:
https://bugs.llvm.org/show_bug.cgi?id=39427

Best regards,
Romain

> ---
>  package/llvm/llvm.hash | 2 +-
>  package/llvm/llvm.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/llvm/llvm.hash b/package/llvm/llvm.hash
> index 200907fc89..531361ae10 100644
> --- a/package/llvm/llvm.hash
> +++ b/package/llvm/llvm.hash
> @@ -1,3 +1,3 @@
>  # locally calculated
> -sha256 8bc1f844e6cbde1b652c19c1edebc1864456fd9c78b8c1bea038e51b363fe222 llvm-7.0.0.src.tar.xz
> +sha256 a38dfc4db47102ec79dcc2aa61e93722c5f6f06f0a961073bd84b78fb949419b llvm-7.0.1.src.tar.xz
>  sha256 0303dfeaac87b80d2d1e543aa38d5be77b0eac93c3d04fe7e3c8eaa71a778667 LICENSE.TXT
> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> index 1f9bd447f5..f33ec11fbf 100644
> --- a/package/llvm/llvm.mk
> +++ b/package/llvm/llvm.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -LLVM_VERSION = 7.0.0
> +LLVM_VERSION = 7.0.1
>  LLVM_SITE = http://llvm.org/releases/$(LLVM_VERSION)
>  LLVM_SOURCE = llvm-$(LLVM_VERSION).src.tar.xz
>  LLVM_LICENSE = NCSA
>
Romain Naour Dec. 24, 2018, 1:07 p.m. UTC | #2 
Valentin,

En privé:

Le 24/12/2018 à 14:01, Romain Naour a écrit :
> Hi Valentin,
> 
> Le 24/12/2018 à 12:50, Valentin Korenblit a écrit :
>> llvmpipe tested on Raspberry Pi 3
> 
> Thanks for your work and testing on llvm/clang update.
> 
> Maybe you can add a small comment about the ABI issue discovered in llvm 7:
> http://lists.llvm.org/pipermail/llvm-announce/2018-December/000081.html
> 
> and:
> https://bugs.llvm.org/show_bug.cgi?id=39427
> 
> Best regards,
> Romain
> 
>> ---
>>  package/llvm/llvm.hash | 2 +-
>>  package/llvm/llvm.mk   | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/llvm/llvm.hash b/package/llvm/llvm.hash
>> index 200907fc89..531361ae10 100644
>> --- a/package/llvm/llvm.hash
>> +++ b/package/llvm/llvm.hash
>> @@ -1,3 +1,3 @@
>>  # locally calculated
>> -sha256 8bc1f844e6cbde1b652c19c1edebc1864456fd9c78b8c1bea038e51b363fe222 llvm-7.0.0.src.tar.xz
>> +sha256 a38dfc4db47102ec79dcc2aa61e93722c5f6f06f0a961073bd84b78fb949419b llvm-7.0.1.src.tar.xz
>>  sha256 0303dfeaac87b80d2d1e543aa38d5be77b0eac93c3d04fe7e3c8eaa71a778667 LICENSE.TXT
>> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
>> index 1f9bd447f5..f33ec11fbf 100644
>> --- a/package/llvm/llvm.mk
>> +++ b/package/llvm/llvm.mk
>> @@ -4,7 +4,7 @@
>>  #
>>  ################################################################################
>>  

Tu n'a pas mis à jour ta branche sur master :p

Il y a un nouveau commentaire dans le .mk

# LLVM and Clang should be version bumped together

>> -LLVM_VERSION = 7.0.0
>> +LLVM_VERSION = 7.0.1

Du coup tes patches ne s'appliquent pas :p
C'est dommage car tu as fait le plus difficile et ta contribution ne peux pas
être mergée tel quel pour un détail.

Dès que tu as 5min, peux tu renvoyer une v2 stp ?

Passe de bonnes fêtes.

Romain

>>  LLVM_SITE = http://llvm.org/releases/$(LLVM_VERSION)
>>  LLVM_SOURCE = llvm-$(LLVM_VERSION).src.tar.xz
>>  LLVM_LICENSE = NCSA
>>
>
Thomas Petazzoni Dec. 24, 2018, 2:18 p.m. UTC | #3 
Hello,

On Mon, 24 Dec 2018 14:07:24 +0100, Romain Naour wrote:
> Valentin,
> 
> En privé:

I think sending the message in private kind of failed :-)

Thomas
Thomas Petazzoni Dec. 26, 2018, 8:26 p.m. UTC | #4 
Hello,

On Mon, 24 Dec 2018 12:50:40 +0100, Valentin Korenblit wrote:
> llvmpipe tested on Raspberry Pi 3

This patch (and the clang one) is missing your Signed-off-by. Could you
resend after adding your SoB ?

Best regards,

Thomams
diff mbox series

Patch

diff --git a/package/llvm/llvm.hash b/package/llvm/llvm.hash
index 200907fc89..531361ae10 100644
--- a/package/llvm/llvm.hash
+++ b/package/llvm/llvm.hash
@@ -1,3 +1,3 @@ 
 # locally calculated
-sha256 8bc1f844e6cbde1b652c19c1edebc1864456fd9c78b8c1bea038e51b363fe222 llvm-7.0.0.src.tar.xz
+sha256 a38dfc4db47102ec79dcc2aa61e93722c5f6f06f0a961073bd84b78fb949419b llvm-7.0.1.src.tar.xz
 sha256 0303dfeaac87b80d2d1e543aa38d5be77b0eac93c3d04fe7e3c8eaa71a778667 LICENSE.TXT
diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index 1f9bd447f5..f33ec11fbf 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-LLVM_VERSION = 7.0.0
+LLVM_VERSION = 7.0.1
 LLVM_SITE = http://llvm.org/releases/$(LLVM_VERSION)
 LLVM_SOURCE = llvm-$(LLVM_VERSION).src.tar.xz
 LLVM_LICENSE = NCSA