From patchwork Mon Dec 17 23:43:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnout Vandecappelle X-Patchwork-Id: 1014881 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mind.be Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mind-be.20150623.gappssmtp.com header.i=@mind-be.20150623.gappssmtp.com header.b="X4ZsN9dc"; dkim-atps=neutral Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43Jd4w6vT6z9s2P for ; Tue, 18 Dec 2018 10:43:11 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 017B722888; Mon, 17 Dec 2018 23:43:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZiiQvX+KLExL; Mon, 17 Dec 2018 23:43:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id F0A8122116; Mon, 17 Dec 2018 23:43:07 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 18A741BF303 for ; Mon, 17 Dec 2018 23:43:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 1608A878F1 for ; Mon, 17 Dec 2018 23:43:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b-n6We-gT6bX for ; Mon, 17 Dec 2018 23:43:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by hemlock.osuosl.org (Postfix) with ESMTPS id 9ADA08782A for ; Mon, 17 Dec 2018 23:43:05 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id d39so12242560edb.12 for ; Mon, 17 Dec 2018 15:43:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mind-be.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hDVgFeL3JlxCvrcwvxr4tWcthWpkB+BlHeErj9EkQno=; b=X4ZsN9dciIiHLOnza/i4Dkqy2Rapao6b0t7fvjY9tSZUFNq+Y9DFc30YlLiv8Ziqti 8WWaI5muuo79Z+wUA8I8aTB5JcJaSG4/yHM0/8yFF5D+p5xaLkFnUCN2dB3l+79vyJVv lh9GSZJZyFJ6/RV+vO1mpzQqcDwWeo1a7VjttdTF2yiwo2xj4TSpbcQ4uKvXeLyjdnZm LJtTDwXPBMGWp2dqlBxb51Ho2mgiu9MVC0mRWwRkS3dh8VLVXnBE2tB5pWqknBhEHcYA AwUFJns0IJMzv/Bici+4SfGj6phygftwx3hUmcCf0FWhemdvnYA0OkjMVbUKS644Gxav g5IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hDVgFeL3JlxCvrcwvxr4tWcthWpkB+BlHeErj9EkQno=; b=XCRmk1SbkRfs4Y76nW2mfPynFTEw3/HaxK532V5us0u1+KyEKqpFzQb+PSVbCsIYOZ GMdftowVrwcgupss30ooVFFDsVChWyygLuEQfc0VIKXKuAt8lz7pukOL4E1d1dmVjtlO pkwz1OXDWbh9PLqvGbN+8BReW8QDHarTkvmme19W8MieH9LTb+wmJxF0cJbz8Cf0D8mn A9zkeSK3Tz1FdmMihu68UcLvhVTdDqUuN07ZZynWI85F8cSRhUFNWZc0oWXIG08i0B0s mOyIr7phOPozydxebu24GdcbsViY7doXLSBqZqoXYLtIBDxjoJFmpGh2y7Xr9TeOjOVj uvvA== X-Gm-Message-State: AA+aEWY8SL4yxIWjwF83XYlVquPGhyo67L1KZ5h1Wz4xxvOcWjXUt8Wc hqmlDVI1KTwvlY0UTiFzQiLj1s65kO5V+w== X-Google-Smtp-Source: AFSGD/WunAdCUa7igrHzGyRU2hFfFJCgO0g8k7DUsXjRWnbbiCheuQTFQb9GIHvjusYmm/kW5N308g== X-Received: by 2002:a50:ae8f:: with SMTP id e15mr14824788edd.250.1545090183634; Mon, 17 Dec 2018 15:43:03 -0800 (PST) Received: from localhost.localdomain (d51a4e7a0.access.telenet.be. [81.164.231.160]) by smtp.gmail.com with ESMTPSA id 24sm4023959eds.97.2018.12.17.15.43.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Dec 2018 15:43:03 -0800 (PST) From: "Arnout Vandecappelle (Essensium/Mind)" To: buildroot@buildroot.org Date: Tue, 18 Dec 2018 00:43:01 +0100 Message-Id: <20181217234301.7111-1-arnout@mind.be> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Subject: [Buildroot] [PATCH] swupdate: pass full TARGET_CONFIGURE_OPTS X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Korsgaard Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Although we set CONFIG_CROSS_COMPILE to TARGET_CROSS in swupdate's .config file, swupdate's build system just appends 'cc' to it, not 'gcc'. Some external toolchains don't provide a cc -> gcc symlink, leading to errors like: /bin/sh: .../host/bin/arm-none-linux-gnueabi-cc: No such file or directory We can just pass TARGET_CONFIGURE_OPTS which explicitly sets CC=, like we do for all other packages. Although this makes setting CONFIG_CROSS_COMPILE redundant, it's nice to keep it as well for consistency. Fixes: http://autobuild.buildroot.net/results/e302d0edb59ff7617b5f2d21f06eb65ae04981fe http://autobuild.buildroot.net/results/dbb69acadc20b4bb559311348eca276c1e6343f7 Signed-off-by: Arnout Vandecappelle (Essensium/Mind) Cc: Peter Korsgaard --- package/swupdate/swupdate.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/swupdate/swupdate.mk b/package/swupdate/swupdate.mk index 6285437aaa..27a53e3837 100644 --- a/package/swupdate/swupdate.mk +++ b/package/swupdate/swupdate.mk @@ -118,7 +118,7 @@ define SWUPDATE_KCONFIG_FIXUP_CMDS endef define SWUPDATE_BUILD_CMDS - $(TARGET_MAKE_ENV) $(SWUPDATE_MAKE_ENV) $(MAKE) -C $(@D) + $(TARGET_CONFIGURE_OPTS) $(SWUPDATE_MAKE_ENV) $(MAKE) -C $(@D) endef define SWUPDATE_INSTALL_TARGET_CMDS