Message ID | 20181103045624.31059-5-ricardo.martincoski@gmail.com |
---|---|
State | Changes Requested |
Headers | show
Return-Path: <buildroot-bounces@busybox.net> X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="r5ExcvSv"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42n6Bb2gwwzB4Y5 for <incoming-buildroot@patchwork.ozlabs.org>; Sat, 3 Nov 2018 15:57:43 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 14EC788552; Sat, 3 Nov 2018 04:57:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W5ao7Jt+UXvo; Sat, 3 Nov 2018 04:57:38 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 58AF9885ED; Sat, 3 Nov 2018 04:57:37 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 395751BF5A8 for <buildroot@lists.busybox.net>; Sat, 3 Nov 2018 04:57:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3566586E90 for <buildroot@lists.busybox.net>; Sat, 3 Nov 2018 04:57:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l48nBUkbJ3FQ for <buildroot@lists.busybox.net>; Sat, 3 Nov 2018 04:57:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by fraxinus.osuosl.org (Postfix) with ESMTPS id A0BB486D9B for <buildroot@buildroot.org>; Sat, 3 Nov 2018 04:57:34 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id o125so6456272qkf.3 for <buildroot@buildroot.org>; Fri, 02 Nov 2018 21:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=p7VWkrDGsJhtJMDpR/Ibz1XHSipCaZmkHLTvyy6P3i0=; b=r5ExcvSvmTMMfueSC90EwCyh6YPR2Rrw7ABZM4cJqk8jG/mi0lbXEFIlMpZbgGsmyP nClKgiczH9R4pzrpvGSu3su/dAsTIDVcDXYvf0eD8qg7k6RqaChht/+lHf9Q2ubWTwRf hnAZSsRYOItKLhfGPI70KPLW8iAlrOvx4/9i5UMrbB9ikjHhLSi4hXZo7st0+NHWRtM9 JS8gb8BlXT83NF1yp4WYzFct+UIzNBIj3KPiJ4OZc4LTyQRMU1GgQKncGcdGVXJL2/hN UhLGLjKvqEJZgDBXCYUsXYw0cobdzjiZdOZDwPMbJZDT+9gZb2IiEXBFkVuGEdsD3UxQ duMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=p7VWkrDGsJhtJMDpR/Ibz1XHSipCaZmkHLTvyy6P3i0=; b=GMSlH2aV7BnVQN64b1KLtmHuB4V6KtaXDh009FRMuC1Hc0RDQisMWvixphdf9+pAZA pk6VcT2Nq7ajtlhGnp3436XSqkjCamRqd08nzVwcE9NwBXRe/d2Tl0SvU9i+wAP2RvfS jFiyY4T/VfHHpt5EOT+1ta+lSmmEfnVZjTygQq7rv7EcwtvUsigsll/CqvCTJbzxL3wm FWgyhAxwKLptPU9iH63wQzJ9f+LX6MCinad1PegX3gsTkNCHmTa1CwkQ1yCNZaV8xLvI mjN4SdoAkrN+lUMPPfVxpHWoPU+FvLL9w1Byr2QwT3BPTS4uzk+2A9k5h/J0FKMyICIG KSSg== X-Gm-Message-State: AGRZ1gI7KhWh6/9n92olgpUdKf0hXRdPpBV1sjy3ss484PgG1QEhg3rL wh5T1pIgI7q0rcrAze0j9YSeg9tE X-Google-Smtp-Source: AJdET5dsI6o9uKnwXy5i3EhBQeLxAweRb/qw5xhoucaastT80+H/XgfzyK25t+T4PDob8x372K0rjQ== X-Received: by 2002:a37:5e86:: with SMTP id s128-v6mr13181635qkb.69.1541221053626; Fri, 02 Nov 2018 21:57:33 -0700 (PDT) Received: from ultri5.home ([179.181.159.8]) by smtp.gmail.com with ESMTPSA id g129-v6sm9337126qkd.33.2018.11.02.21.57.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Nov 2018 21:57:33 -0700 (PDT) From: Ricardo Martincoski <ricardo.martincoski@gmail.com> To: buildroot@buildroot.org Date: Sat, 3 Nov 2018 01:56:23 -0300 Message-Id: <20181103045624.31059-5-ricardo.martincoski@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181103045624.31059-1-ricardo.martincoski@gmail.com> References: <20181103045624.31059-1-ricardo.martincoski@gmail.com> Subject: [Buildroot] [PATCH 4/5] check-package: ignore external.mk X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot <buildroot.busybox.net> List-Unsubscribe: <http://lists.busybox.net/mailman/options/buildroot>, <mailto:buildroot-request@busybox.net?subject=unsubscribe> List-Archive: <http://lists.busybox.net/pipermail/buildroot/> List-Post: <mailto:buildroot@busybox.net> List-Help: <mailto:buildroot-request@busybox.net?subject=help> List-Subscribe: <http://lists.busybox.net/mailman/listinfo/buildroot>, <mailto:buildroot-request@busybox.net?subject=subscribe> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Ricardo Martincoski <ricardo.martincoski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net> |
Series |
Fix bug 11271 and add test for check-package
|
expand
|
diff --git a/utils/check-package b/utils/check-package index aa6993dabd..ebd82cba95 100755 --- a/utils/check-package +++ b/utils/check-package @@ -71,6 +71,9 @@ def get_lib_from_filename(fname): return None if DO_NOT_CHECK_INTREE.match(fname): return None + else: + if os.path.basename(fname) == "external.mk" and os.path.exists(fname[:-2] + "desc"): + return None if CONFIG_IN_FILENAME.search(fname): return checkpackagelib.lib_config if fname.endswith(".hash"):
The external.mk file in a br2-external usually contains raw makefile targets. This file is common code and not a package recipe so it should not be tested against the code-style of a package .mk file. When using this script to check files in a br2-external tree, usually the user is responsible for not passing files that check-package do not understand. But external.mk is special because it is part of the br2-external structure, so it is likely someone expects it to be checkable by an in-tree script. Instead of adding another blob to the manual, just ignore this file. Only do that when a br2-external is being tested (so with option -b passed to the script) and also check that it is on the root path of the br2-external to allow someone to have a package called external. Reported on bug #11271. Reported-by: Vitaliy Lotorev <lotorev@gmail.com> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- utils/check-package | 3 +++ 1 file changed, 3 insertions(+)