diff mbox series

[1/1] python-crossbar: drop Python 2 support

Message ID 20181016234457.6786-1-ricardo.martincoski@gmail.com
State Accepted
Headers show
Series [1/1] python-crossbar: drop Python 2 support | expand

Commit Message

Ricardo Martincoski Oct. 16, 2018, 11:44 p.m. UTC
Upstream is now Python 3 only.

Quoting the maintainer [1]: "the last version of crossbar with python 2
support: pip install crossbar==18.4.1".

[1] https://github.com/crossbario/crossbar/issues/1332

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>
Cc: Mauro Condarelli <mc5686@mclink.it>
Cc: Yegor Yefremov <yegorslists@googlemail.com>
---
NOTES:

This is only for master branch. Other branches are not affected.

There are newer releases available via pip2 but they are broken in
runtime. Some people complained about this on [1].

Based on "f4972e2e8c python-django: bump to version 2.1.2" I assume we
don't need any legacy handling for this case.

I followed the convention from the manual:
4. Any dependencies on the toolchain in depends on form
5. Any dependencies on other packages in depends on form
---
 package/python-crossbar/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Petazzoni Oct. 17, 2018, 7:48 p.m. UTC | #1
Hello,

On Tue, 16 Oct 2018 20:44:57 -0300, Ricardo Martincoski wrote:
> Upstream is now Python 3 only.
> 
> Quoting the maintainer [1]: "the last version of crossbar with python 2
> support: pip install crossbar==18.4.1".
> 
> [1] https://github.com/crossbario/crossbar/issues/1332
> 
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Asaf Kahlon <asafka7@gmail.com>
> Cc: Mauro Condarelli <mc5686@mclink.it>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> NOTES:

Applied to master, thanks.

Thomas
diff mbox series

Patch

diff --git a/package/python-crossbar/Config.in b/package/python-crossbar/Config.in
index 2f9de6e0b5..526d9871be 100644
--- a/package/python-crossbar/Config.in
+++ b/package/python-crossbar/Config.in
@@ -1,6 +1,7 @@ 
 config BR2_PACKAGE_PYTHON_CROSSBAR
 	bool "python-crossbar"
 	depends on BR2_INSTALL_LIBSTDCPP # python-cryptography
+	depends on BR2_PACKAGE_PYTHON3
 	# All the following dependencies are runtime dependencies
 	select BR2_PACKAGE_PYTHON_ATTRS
 	select BR2_PACKAGE_PYTHON_AUTOBAHN
@@ -48,3 +49,4 @@  config BR2_PACKAGE_PYTHON_CROSSBAR
 
 comment "python-crossbar needs a toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_PYTHON3