diff mbox series

[1/1] python-django: bump version to 2.1.1

Message ID 20180921150825.1986-1-aduskett@gmail.com
State Changes Requested
Headers show
Series [1/1] python-django: bump version to 2.1.1 | expand

Commit Message

Adam Duskett Sept. 21, 2018, 3:08 p.m. UTC 
Tested with python3.7
Fixes http://autobuild.buildroot.net/results/7ea/7ea58b0909ea1871b3735f8671686ce0eece2e7c/build-end.log

Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
 package/python-django/python-django.hash | 7 ++++---
 package/python-django/python-django.mk   | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

Comments

Asaf Kahlon Sept. 21, 2018, 3:32 p.m. UTC | #1 
Hello,

I don't use django regularly, but it seems django needs pytz (
https://github.com/django/django/blob/2.1.1/setup.py).
Moreover, django has dropped support in python2 since 2.0 (
https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django),
so I guess the definition in Config.in should be changed to depend
on BR2_PACKAGE_PYTHON3.

Asaf.

On Fri, Sep 21, 2018 at 6:08 PM Adam Duskett <aduskett@gmail.com> wrote:

> Tested with python3.7
> Fixes
> http://autobuild.buildroot.net/results/7ea/7ea58b0909ea1871b3735f8671686ce0eece2e7c/build-end.log
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
> ---
>  package/python-django/python-django.hash | 7 ++++---
>  package/python-django/python-django.mk   | 4 ++--
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/package/python-django/python-django.hash
> b/package/python-django/python-django.hash
> index bc7aed9479..c472e69500 100644
> --- a/package/python-django/python-django.hash
> +++ b/package/python-django/python-django.hash
> @@ -1,3 +1,4 @@
> -# From https://www.djangoproject.com/m/pgp/Django-1.11.15.checksum.txt
> -sha256 b18235d82426f09733d2de9910cee975cf52ff05e5f836681eb957d105a05a40
> Django-1.11.15.tar.gz
> -sha256 b846415d1b514e9c1dff14a22deb906d794bc546ca6129f950a18cd091e2a669
> LICENSE
> +# # From https://pypi.org/pypi/Django/json
> +md5 06e7c47864e0a38cd99ddabb152b9e9b Django-2.1.1.tar.gz
> +sha256  e1cc1cd6b658aa4e052f5f2b148bfda08091d7c3558529708342e37e4e33f72c
> Django-2.1.1.tar.gz
> +sha256  b846415d1b514e9c1dff14a22deb906d794bc546ca6129f950a18cd091e2a669
> LICENSE
> diff --git a/package/python-django/python-django.mk
> b/package/python-django/python-django.mk
> index ae604dbc97..151f5d86c2 100644
> --- a/package/python-django/python-django.mk
> +++ b/package/python-django/python-django.mk
> @@ -4,10 +4,10 @@
>  #
>
>  ################################################################################
>
> -PYTHON_DJANGO_VERSION = 1.11.15
> +PYTHON_DJANGO_VERSION = 2.1.1
>  PYTHON_DJANGO_SOURCE = Django-$(PYTHON_DJANGO_VERSION).tar.gz
>  # The official Django site has an unpractical URL
> -PYTHON_DJANGO_SITE =
> https://files.pythonhosted.org/packages/43/b5/b44286e56a5211d37b4058dcd5e62835afa5ce5aa6a38b56bd04c0d01cbc
> +PYTHON_DJANGO_SITE =
> https://files.pythonhosted.org/packages/14/c8/b6f5c67cf34ae7586258af110e53657da671325b146fcc67ac64a4daace5
>  PYTHON_DJANGO_LICENSE = BSD-3-Clause
>  PYTHON_DJANGO_LICENSE_FILES = LICENSE
>  PYTHON_DJANGO_SETUP_TYPE = setuptools
> --
> 2.17.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">Hello,</div><div dir="ltr"><br></div><div dir="ltr">I don&#39;t use django regularly, but it seems django needs pytz (<a href="https://github.com/django/django/blob/2.1.1/setup.py" target="_blank">https://github.com/django/django/blob/2.1.1/setup.py</a>).</div><div>Moreover, django has dropped support in python2 since 2.0 (<a href="https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django" target="_blank">https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django</a>), so I guess the definition in Config.in should be changed to depend on BR2_PACKAGE_PYTHON3.</div><div><br></div><div>Asaf.</div></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 21, 2018 at 6:08 PM Adam Duskett &lt;<a href="mailto:aduskett@gmail.com" target="_blank">aduskett@gmail.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Tested with python3.7<br>
Fixes <a href="http://autobuild.buildroot.net/results/7ea/7ea58b0909ea1871b3735f8671686ce0eece2e7c/build-end.log" rel="noreferrer" target="_blank">http://autobuild.buildroot.net/results/7ea/7ea58b0909ea1871b3735f8671686ce0eece2e7c/build-end.log</a><br>
<br>
Signed-off-by: Adam Duskett &lt;<a href="mailto:aduskett@gmail.com" target="_blank">aduskett@gmail.com</a>&gt;<br>
---<br>
 package/python-django/python-django.hash | 7 ++++---<br>
 package/python-django/<a href="http://python-django.mk" rel="noreferrer" target="_blank">python-django.mk</a>   | 4 ++--<br>
 2 files changed, 6 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/package/python-django/python-django.hash b/package/python-django/python-django.hash<br>
index bc7aed9479..c472e69500 100644<br>
--- a/package/python-django/python-django.hash<br>
+++ b/package/python-django/python-django.hash<br>
@@ -1,3 +1,4 @@<br>
-# From <a href="https://www.djangoproject.com/m/pgp/Django-1.11.15.checksum.txt" rel="noreferrer" target="_blank">https://www.djangoproject.com/m/pgp/Django-1.11.15.checksum.txt</a><br>
-sha256 b18235d82426f09733d2de9910cee975cf52ff05e5f836681eb957d105a05a40  Django-1.11.15.tar.gz<br>
-sha256 b846415d1b514e9c1dff14a22deb906d794bc546ca6129f950a18cd091e2a669  LICENSE<br>
+# # From <a href="https://pypi.org/pypi/Django/json" rel="noreferrer" target="_blank">https://pypi.org/pypi/Django/json</a><br>
+md5 06e7c47864e0a38cd99ddabb152b9e9b Django-2.1.1.tar.gz<br>
+sha256  e1cc1cd6b658aa4e052f5f2b148bfda08091d7c3558529708342e37e4e33f72c  Django-2.1.1.tar.gz<br>
+sha256  b846415d1b514e9c1dff14a22deb906d794bc546ca6129f950a18cd091e2a669  LICENSE<br>
diff --git a/package/python-django/<a href="http://python-django.mk" rel="noreferrer" target="_blank">python-django.mk</a> b/package/python-django/<a href="http://python-django.mk" rel="noreferrer" target="_blank">python-django.mk</a><br>
index ae604dbc97..151f5d86c2 100644<br>
--- a/package/python-django/<a href="http://python-django.mk" rel="noreferrer" target="_blank">python-django.mk</a><br>
+++ b/package/python-django/<a href="http://python-django.mk" rel="noreferrer" target="_blank">python-django.mk</a><br>
@@ -4,10 +4,10 @@<br>
 #<br>
 ################################################################################<br>
<br>
-PYTHON_DJANGO_VERSION = 1.11.15<br>
+PYTHON_DJANGO_VERSION = 2.1.1<br>
 PYTHON_DJANGO_SOURCE = Django-$(PYTHON_DJANGO_VERSION).tar.gz<br>
 # The official Django site has an unpractical URL<br>
-PYTHON_DJANGO_SITE = <a href="https://files.pythonhosted.org/packages/43/b5/b44286e56a5211d37b4058dcd5e62835afa5ce5aa6a38b56bd04c0d01cbc" rel="noreferrer" target="_blank">https://files.pythonhosted.org/packages/43/b5/b44286e56a5211d37b4058dcd5e62835afa5ce5aa6a38b56bd04c0d01cbc</a><br>
+PYTHON_DJANGO_SITE = <a href="https://files.pythonhosted.org/packages/14/c8/b6f5c67cf34ae7586258af110e53657da671325b146fcc67ac64a4daace5" rel="noreferrer" target="_blank">https://files.pythonhosted.org/packages/14/c8/b6f5c67cf34ae7586258af110e53657da671325b146fcc67ac64a4daace5</a><br>
 PYTHON_DJANGO_LICENSE = BSD-3-Clause<br>
 PYTHON_DJANGO_LICENSE_FILES = LICENSE<br>
 PYTHON_DJANGO_SETUP_TYPE = setuptools<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
buildroot mailing list<br>
<a href="mailto:buildroot@busybox.net" target="_blank">buildroot@busybox.net</a><br>
<a href="http://lists.busybox.net/mailman/listinfo/buildroot" rel="noreferrer" target="_blank">http://lists.busybox.net/mailman/listinfo/buildroot</a><br>
</blockquote></div></div>
Thomas Petazzoni Sept. 22, 2018, 4:53 p.m. UTC | #2 
Hello,

On Fri, 21 Sep 2018 18:32:51 +0300, Asaf Kahlon wrote:

> I don't use django regularly, but it seems django needs pytz (
> https://github.com/django/django/blob/2.1.1/setup.py).
> Moreover, django has dropped support in python2 since 2.0 (
> https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django),
> so I guess the definition in Config.in should be changed to depend
> on BR2_PACKAGE_PYTHON3.

Thanks Asaf for this review, much appreciated.

Adam: I have marked your patch as Changes Requested in patchwork. Could
you send an updated version that takes into account the comments made
by Asaf ?

Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/python-django/python-django.hash b/package/python-django/python-django.hash
index bc7aed9479..c472e69500 100644
--- a/package/python-django/python-django.hash
+++ b/package/python-django/python-django.hash
@@ -1,3 +1,4 @@ 
-# From https://www.djangoproject.com/m/pgp/Django-1.11.15.checksum.txt
-sha256	b18235d82426f09733d2de9910cee975cf52ff05e5f836681eb957d105a05a40  Django-1.11.15.tar.gz
-sha256	b846415d1b514e9c1dff14a22deb906d794bc546ca6129f950a18cd091e2a669  LICENSE
+# # From https://pypi.org/pypi/Django/json
+md5 06e7c47864e0a38cd99ddabb152b9e9b Django-2.1.1.tar.gz
+sha256  e1cc1cd6b658aa4e052f5f2b148bfda08091d7c3558529708342e37e4e33f72c  Django-2.1.1.tar.gz
+sha256  b846415d1b514e9c1dff14a22deb906d794bc546ca6129f950a18cd091e2a669  LICENSE
diff --git a/package/python-django/python-django.mk b/package/python-django/python-django.mk
index ae604dbc97..151f5d86c2 100644
--- a/package/python-django/python-django.mk
+++ b/package/python-django/python-django.mk
@@ -4,10 +4,10 @@ 
 #
 ################################################################################
 
-PYTHON_DJANGO_VERSION = 1.11.15
+PYTHON_DJANGO_VERSION = 2.1.1
 PYTHON_DJANGO_SOURCE = Django-$(PYTHON_DJANGO_VERSION).tar.gz
 # The official Django site has an unpractical URL
-PYTHON_DJANGO_SITE = https://files.pythonhosted.org/packages/43/b5/b44286e56a5211d37b4058dcd5e62835afa5ce5aa6a38b56bd04c0d01cbc
+PYTHON_DJANGO_SITE = https://files.pythonhosted.org/packages/14/c8/b6f5c67cf34ae7586258af110e53657da671325b146fcc67ac64a4daace5
 PYTHON_DJANGO_LICENSE = BSD-3-Clause
 PYTHON_DJANGO_LICENSE_FILES = LICENSE
 PYTHON_DJANGO_SETUP_TYPE = setuptools