| Message ID | 20180719073253.22433-6-gary.bisson@boundarydevices.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Boundary Devices Nitrogen8M support | expand |
Hello, On Thu, 19 Jul 2018 09:32:53 +0200, Gary Bisson wrote: > NXP i.MX8MQ based SBC with 2GB of LPDDR4 and 8GB eMMC. > > More details on the platform here: > https://boundarydevices.com/product/nitrogen8m > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > --- > configs/nitrogen8m_defconfig | 54 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 configs/nitrogen8m_defconfig DEVELOPERS entry + .gitlab-ci.yml update are missing. > +# System > +BR2_TARGET_GENERIC_GETTY=y > +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0" > +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh" > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh" > +BR2_ROOTFS_POST_SCRIPT_ARGS="${UBOOT_DIR}/arch/arm/dts/imx8mq-nitrogen8m.dtb" UBOOT_DIR is properly going to be expanded by the post-build script ? Thanks, Thomas
Hi, On Thu, Jul 19, 2018 at 10:10:00AM +0200, Thomas Petazzoni wrote: > Hello, > > On Thu, 19 Jul 2018 09:32:53 +0200, Gary Bisson wrote: > > NXP i.MX8MQ based SBC with 2GB of LPDDR4 and 8GB eMMC. > > > > More details on the platform here: > > https://boundarydevices.com/product/nitrogen8m > > > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > > --- > > configs/nitrogen8m_defconfig | 54 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 configs/nitrogen8m_defconfig > > DEVELOPERS entry + .gitlab-ci.yml update are missing. DEVELOPERS should be fine since I have: F: configs/nitrogen* .gitlab-ci.yml was forgotten indeed, I'll add it to V2. > > +# System > > +BR2_TARGET_GENERIC_GETTY=y > > +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0" > > +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh" > > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh" > > +BR2_ROOTFS_POST_SCRIPT_ARGS="${UBOOT_DIR}/arch/arm/dts/imx8mq-nitrogen8m.dtb" > > UBOOT_DIR is properly going to be expanded by the post-build script ? My understanding is that the Makefile is expanding it already. What I know for sure is that I receive the proper value in the script. Regards, Gary
Hello, On Thu, 19 Jul 2018 10:23:44 +0200, Gary Bisson wrote: > > DEVELOPERS entry + .gitlab-ci.yml update are missing. > > DEVELOPERS should be fine since I have: > F: configs/nitrogen* Ah, yes, my bad. > > > +# System > > > +BR2_TARGET_GENERIC_GETTY=y > > > +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0" > > > +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh" > > > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh" > > > +BR2_ROOTFS_POST_SCRIPT_ARGS="${UBOOT_DIR}/arch/arm/dts/imx8mq-nitrogen8m.dtb" > > > > UBOOT_DIR is properly going to be expanded by the post-build script ? > > My understanding is that the Makefile is expanding it already. What I > know for sure is that I receive the proper value in the script. OK, thanks! Thomas
On 19-07-18 10:23, Gary Bisson wrote: > Hi, > > On Thu, Jul 19, 2018 at 10:10:00AM +0200, Thomas Petazzoni wrote: >> Hello, >> >> On Thu, 19 Jul 2018 09:32:53 +0200, Gary Bisson wrote: >>> NXP i.MX8MQ based SBC with 2GB of LPDDR4 and 8GB eMMC. >>> >>> More details on the platform here: >>> https://boundarydevices.com/product/nitrogen8m >>> >>> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> >>> --- >>> configs/nitrogen8m_defconfig | 54 ++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 54 insertions(+) >>> create mode 100644 configs/nitrogen8m_defconfig >> >> DEVELOPERS entry + .gitlab-ci.yml update are missing. > > DEVELOPERS should be fine since I have: > F: configs/nitrogen* > > .gitlab-ci.yml was forgotten indeed, I'll add it to V2. > >>> +# System >>> +BR2_TARGET_GENERIC_GETTY=y >>> +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0" >>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh" >>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh" >>> +BR2_ROOTFS_POST_SCRIPT_ARGS="${UBOOT_DIR}/arch/arm/dts/imx8mq-nitrogen8m.dtb" >> >> UBOOT_DIR is properly going to be expanded by the post-build script ? > > My understanding is that the Makefile is expanding it already. What I > know for sure is that I receive the proper value in the script. Too late because it's already commitfed, but - you should use $(), not ${}. With ${} it looks as if it's an environment variable, but it's actually a make variable. Regards, Arnout
Hi Arnout, On Thu, Jul 26, 2018 at 10:20:32AM +0200, Arnout Vandecappelle wrote: > > > On 19-07-18 10:23, Gary Bisson wrote: > > Hi, > > > > On Thu, Jul 19, 2018 at 10:10:00AM +0200, Thomas Petazzoni wrote: > >> Hello, > >> > >> On Thu, 19 Jul 2018 09:32:53 +0200, Gary Bisson wrote: > >>> NXP i.MX8MQ based SBC with 2GB of LPDDR4 and 8GB eMMC. > >>> > >>> More details on the platform here: > >>> https://boundarydevices.com/product/nitrogen8m > >>> > >>> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > >>> --- > >>> configs/nitrogen8m_defconfig | 54 ++++++++++++++++++++++++++++++++++++ > >>> 1 file changed, 54 insertions(+) > >>> create mode 100644 configs/nitrogen8m_defconfig > >> > >> DEVELOPERS entry + .gitlab-ci.yml update are missing. > > > > DEVELOPERS should be fine since I have: > > F: configs/nitrogen* > > > > .gitlab-ci.yml was forgotten indeed, I'll add it to V2. > > > >>> +# System > >>> +BR2_TARGET_GENERIC_GETTY=y > >>> +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0" > >>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh" > >>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh" > >>> +BR2_ROOTFS_POST_SCRIPT_ARGS="${UBOOT_DIR}/arch/arm/dts/imx8mq-nitrogen8m.dtb" > >> > >> UBOOT_DIR is properly going to be expanded by the post-build script ? > > > > My understanding is that the Makefile is expanding it already. What I > > know for sure is that I receive the proper value in the script. > Too late because it's already commitfed, but - you should use $(), not ${}. > With ${} it looks as if it's an environment variable, but it's actually a make > variable. Should I submit a patch or can it wait until next version bump? Regards, Gary
On 26-07-18 10:51, Gary Bisson wrote: > Hi Arnout, > > On Thu, Jul 26, 2018 at 10:20:32AM +0200, Arnout Vandecappelle wrote: >> >> >> On 19-07-18 10:23, Gary Bisson wrote: >>> Hi, >>> >>> On Thu, Jul 19, 2018 at 10:10:00AM +0200, Thomas Petazzoni wrote: >>>> Hello, >>>> >>>> On Thu, 19 Jul 2018 09:32:53 +0200, Gary Bisson wrote: >>>>> NXP i.MX8MQ based SBC with 2GB of LPDDR4 and 8GB eMMC. >>>>> >>>>> More details on the platform here: >>>>> https://boundarydevices.com/product/nitrogen8m >>>>> >>>>> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> >>>>> --- >>>>> configs/nitrogen8m_defconfig | 54 ++++++++++++++++++++++++++++++++++++ >>>>> 1 file changed, 54 insertions(+) >>>>> create mode 100644 configs/nitrogen8m_defconfig >>>> >>>> DEVELOPERS entry + .gitlab-ci.yml update are missing. >>> >>> DEVELOPERS should be fine since I have: >>> F: configs/nitrogen* >>> >>> .gitlab-ci.yml was forgotten indeed, I'll add it to V2. >>> >>>>> +# System >>>>> +BR2_TARGET_GENERIC_GETTY=y >>>>> +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0" >>>>> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh" >>>>> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh" >>>>> +BR2_ROOTFS_POST_SCRIPT_ARGS="${UBOOT_DIR}/arch/arm/dts/imx8mq-nitrogen8m.dtb" >>>> >>>> UBOOT_DIR is properly going to be expanded by the post-build script ? >>> >>> My understanding is that the Makefile is expanding it already. What I >>> know for sure is that I receive the proper value in the script. >> Too late because it's already commitfed, but - you should use $(), not ${}. >> With ${} it looks as if it's an environment variable, but it's actually a make >> variable. > > Should I submit a patch or can it wait until next version bump? It can wait, but if you do it in a version bump people might complain that it's an independent issue you're fixing in the same patch :-) Regards, Arnout
diff --git a/configs/nitrogen8m_defconfig b/configs/nitrogen8m_defconfig new file mode 100644 index 0000000000..9b758f0b97 --- /dev/null +++ b/configs/nitrogen8m_defconfig @@ -0,0 +1,54 @@ +# Architecture +BR2_aarch64=y +BR2_cortex_a53=y + +# System +BR2_TARGET_GENERIC_GETTY=y +BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0" +BR2_ROOTFS_POST_BUILD_SCRIPT="board/freescale/common/imx/imx8-bootloader-prepare.sh board/boundarydevices/common/post-build.sh" +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/boundarydevices/common/post-image.sh" +BR2_ROOTFS_POST_SCRIPT_ARGS="${UBOOT_DIR}/arch/arm/dts/imx8mq-nitrogen8m.dtb" +BR2_PACKAGE_HOST_GENIMAGE=y +BR2_PACKAGE_HOST_IMX_MKIMAGE=y +BR2_PACKAGE_HOST_UBOOT_TOOLS=y +BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT=y + +# Filesystem +BR2_TARGET_ROOTFS_EXT2=y +BR2_TARGET_ROOTFS_EXT2_4=y + +# Linux headers same as kernel, a 4.9 series +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y + +# DDR training binaries +BR2_PACKAGE_FREESCALE_IMX=y +BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M=y +BR2_PACKAGE_FIRMWARE_IMX=y + +# ARM Trusted Firmware +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL=y +# Latest revision of branch boundary-imx_4.9.51_imx8m_ga +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION="https://github.com/boundarydevices/imx-atf/archive/67c68675.tar.gz" +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="imx8mq" +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y + +# Bootloader +BR2_TARGET_UBOOT=y +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nitrogen8m" +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y +BR2_TARGET_UBOOT_CUSTOM_TARBALL=y +# Latest revision of branch boundary-imx_v2017.03_4.9.51_imx8m_ga +BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="https://github.com/boundarydevices/u-boot-imx6/archive/b661d854.tar.gz" +BR2_TARGET_UBOOT_NEEDS_DTC=y +BR2_TARGET_UBOOT_SPL=y + +# Kernel +BR2_LINUX_KERNEL=y +BR2_LINUX_KERNEL_CUSTOM_TARBALL=y +# Latest revision of branch boundary-imx_4.9.x_2.0.0_ga +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="https://github.com/boundarydevices/linux-imx6/archive/7777e14d.tar.gz" +BR2_LINUX_KERNEL_DEFCONFIG="boundary" +BR2_LINUX_KERNEL_DTS_SUPPORT=y +BR2_LINUX_KERNEL_INSTALL_TARGET=y +BR2_LINUX_KERNEL_INTREE_DTS_NAME="freescale/imx8mq-nitrogen8m freescale/imx8mq-nitrogen8m-m4"
NXP i.MX8MQ based SBC with 2GB of LPDDR4 and 8GB eMMC. More details on the platform here: https://boundarydevices.com/product/nitrogen8m Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> --- configs/nitrogen8m_defconfig | 54 ++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) create mode 100644 configs/nitrogen8m_defconfig