From patchwork Tue May 15 13:34:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anssi Hannula X-Patchwork-Id: 913621 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bitwise.fi Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40ldq94sDnz9ry1 for ; Tue, 15 May 2018 23:35:16 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 885B28618E; Tue, 15 May 2018 13:35:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ir8VORN4rpjG; Tue, 15 May 2018 13:35:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id C3901860C9; Tue, 15 May 2018 13:35:08 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 6823D1C072D for ; Tue, 15 May 2018 13:35:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 655EA22648 for ; Tue, 15 May 2018 13:35:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3CP1lrUYe7hT for ; Tue, 15 May 2018 13:35:04 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.bitwise.fi (mail.bitwise.fi [109.204.228.163]) by silver.osuosl.org (Postfix) with ESMTPS id 2254A22643 for ; Tue, 15 May 2018 13:35:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.bitwise.fi (Postfix) with ESMTP id 86F146004B for ; Tue, 15 May 2018 16:35:02 +0300 (EEST) X-Virus-Scanned: Debian amavisd-new at mail.bitwise.fi Received: from mail.bitwise.fi ([127.0.0.1]) by localhost (mail.bitwise.fi [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0PDsgDfAP8HT for ; Tue, 15 May 2018 16:35:00 +0300 (EEST) Received: from localhost.sec.bitwise.fi (fw1.dmz.bitwise.fi [192.168.69.1]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: anssiha) by mail.bitwise.fi (Postfix) with ESMTPSA id 678FE60030 for ; Tue, 15 May 2018 16:35:00 +0300 (EEST) From: Anssi Hannula To: buildroot@buildroot.org Date: Tue, 15 May 2018 16:34:42 +0300 Message-Id: <20180515133442.16607-1-anssi.hannula@bitwise.fi> X-Mailer: git-send-email 2.16.3 Subject: [Buildroot] [PATCH] gdb: actually disable gdbserver if BR2_PACKAGE_GDB_SERVER is unset X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" The gdb configure script is given --enable-gdbserver when BR2_PACKAGE_GDB_SERVER is set, but it is not given --disable-gdbserver when BR2_PACKAGE_GDB_SERVER is unset. gdb gdb/configure.ac defaults to enabling gdbserver in "native" (host=target) cases, which is always the case when buildroot builds a gdb which runs on the target hardware. The gdbserver will overwrite BR2_TOOLCHAIN_EXTERNAL_GDB_SERVER_COPY gdbserver, if any. Fix that by passing --disable-gdbserver when BR2_PACKAGE_GDB_SERVER is unset. Signed-off-by: Anssi Hannula --- package/gdb/gdb.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk index b69193af51..b2e07602f3 100644 --- a/package/gdb/gdb.mk +++ b/package/gdb/gdb.mk @@ -109,7 +109,7 @@ GDB_CONF_OPTS = \ --without-x \ --disable-sim \ $(GDB_DISABLE_BINUTILS_CONF_OPTS) \ - $(if $(BR2_PACKAGE_GDB_SERVER),--enable-gdbserver) \ + $(if $(BR2_PACKAGE_GDB_SERVER),--enable-gdbserver,--disable-gdbserver) \ --with-curses \ --without-included-gettext \ --disable-werror \