From patchwork Thu May 3 07:58:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnout Vandecappelle X-Patchwork-Id: 907879 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mind.be Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=mind-be.20150623.gappssmtp.com header.i=@mind-be.20150623.gappssmtp.com header.b="w4a2pYDR"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40c6vw0PM8z9s35 for ; Thu, 3 May 2018 17:58:18 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3B76587899; Thu, 3 May 2018 07:58:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bfrVnG_iF9ze; Thu, 3 May 2018 07:58:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 5615A8774C; Thu, 3 May 2018 07:58:15 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id DC9471C1058 for ; Thu, 3 May 2018 07:58:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D678E8774C for ; Thu, 3 May 2018 07:58:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7DFspB2xYpnk for ; Thu, 3 May 2018 07:58:12 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 64CE486B63 for ; Thu, 3 May 2018 07:58:12 +0000 (UTC) Received: by mail-wm0-f41.google.com with SMTP id x12-v6so1806239wmc.0 for ; Thu, 03 May 2018 00:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mind-be.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=daWFN6cxheHxzHkSZBB/4jlnim42HcH2Md+wFubk4dI=; b=w4a2pYDR/3koEAtMK6lOqqv4FqMEv8m2Fbq9HJOy9VFhjLpL0PC8wiuzZBB8YKcJNj opdn5POSX++3QU52ymsyrJ6P4mfYaEufOmHwp7Z5k+CLJtj/0k49u7gNHGC/3WFCxt2k WbLT6bY/sUGWkfnbe9sV7FXF6uPsPfmy1Ks+rhmCoVNwFk7JmNLJy48cXN/Xv2sZn9MZ XJjanIvNe5IC8t++eGycUflB7DKv7tzH9HSkrRvvPFL0q//GuYJ9u45LNNfp9wABe/HA /Qoeh4BVIT89rJHcBJ3L5w3L7/uRsEvMAbk0x6YicLztnTJ0ED0BXHLMaTZYMJnmZHwW U9Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=daWFN6cxheHxzHkSZBB/4jlnim42HcH2Md+wFubk4dI=; b=LIzt5B3mxzN3XXE1ZHgeivxVyDlAApoPO/V/2ouf7jEJBTNM1dPWaQfTyeYzFGxH2g VV3rXTDL/WG/PE8OHs2vgnOdkmJiq4ykoPFclnWmSzzD9dTDL4jBOgH/XfvtBpaxxfi+ ZO1ZkjWMg8J4iSi9ElXQ/YZl7H4a5VFd5lTBIG5JLw/pPsbWq6RI6NWSlu5ZQ/zYc9wl PJdcsy5iqjS3Z0xuX/THdMGd2ouK9qM6JBwzRrNIE85yd3zdAoq22tqw0IXjbwwis0F7 QPdTtR8t9K84jdQlsxCzLXgiCUtVrm75iviR/KVHiAOi0V4i2mze5Lj8OpatfNAQoCug XF7A== X-Gm-Message-State: ALQs6tCSJ2E53ai9N/inXNt1jlPmi/uG0o+wsvd6U7i856zAFLuhSY3r b2eGN/1uS4VPtrtMYHcD3EUKnwAZpQg= X-Google-Smtp-Source: AB8JxZoP15zpEvtCVJNZk1jfF8+WNcwQW7vA3fZWc8zGlEAh/GGXMb80zhYvye+Y3KlkVc8kG3bVkA== X-Received: by 2002:a50:b7ed:: with SMTP id i42-v6mr29981137ede.284.1525334290146; Thu, 03 May 2018 00:58:10 -0700 (PDT) Received: from vandecaa-laptop.local.ess-mail.com (ip-188-118-3-185.reverse.destiny.be. [188.118.3.185]) by smtp.gmail.com with ESMTPSA id d89-v6sm7479123edc.41.2018.05.03.00.58.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 May 2018 00:58:09 -0700 (PDT) From: "Arnout Vandecappelle (Essensium/Mind)" To: buildroot@buildroot.org Date: Thu, 3 May 2018 09:58:08 +0200 Message-Id: <20180503075808.26367-1-arnout@mind.be> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180426190845.21415-1-arnout@mind.be> References: <20180426190845.21415-1-arnout@mind.be> Subject: [Buildroot] [PATCH] package/ncurses: enable widechar for host build X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.24 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David De Grave , Scott Fan MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Kconfig uses either pkg-config or hard-coded /usr/include paths to find the ncurses or ncursesw library. If ncursesw is found, it will include . Since Buildroot's host-ncurses doesn't install a .pc file, and linux.mk anyway doesn't pass the pkg-config options to find the host pkg-config files, Kconfig will always find the system's ncursesw.h. However, since commit dde090c299 (linux: fix passing of host CFLAGS and LDFLAGS) HOST_LDFLAGS is passed to the linux build system. Thus, if host-ncurses was already built before 'make linux-menuconfig' is called, the build will pick up libncurses from the host directory, which is NOT widechar. Thus, two different ncurses configurations are mixed into the final mconf program. This will result in serious breakage in the rendering of the menus (lots of @ and question mark characters). As a workaround, just build host-ncurses with widechar support. That makes it compatible with ncursesw.h picked up from the host. Clearly, this is not a robust solution. But it's simple, it works, and it shouldn't hurt to build host-ncurses with widechar support (we can safely assume that the system doesn't have a non-widechar uClibc library...). Signed-off-by: Arnout Vandecappelle (Essensium/Mind) Cc: David De Grave Cc: Scott Fan --- v2: - fix typo in commit message; - extend commit message; - keep alphabetic ordering of configure options (Scott) Note: I haven't tested what happens on a system which doesn't have ncursesw.h. But I guess such a system is so exotic that it's not worthwhile to do something special for it. --- package/ncurses/ncurses.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk index 90cf4a4dc5..f9cd0d3fbd 100644 --- a/package/ncurses/ncurses.mk +++ b/package/ncurses/ncurses.mk @@ -147,6 +147,7 @@ define HOST_NCURSES_BUILD_CMDS endef HOST_NCURSES_CONF_OPTS = \ + --enable-widec \ --with-shared \ --without-gpm \ --without-manpages \