diff mbox series

[2/4] package/mesa3d: RadeonSI needs libdrm-radeon and libdrm-amdgpu

Message ID 20180428172803.11179-2-romain.naour@gmail.com
State Accepted
Headers show
Series [1/4] package/mesa3d: radeonSI: specify drm platform | expand

Commit Message

Romain Naour April 28, 2018, 5:28 p.m. UTC
Fixes:
checking for EXPAT... yes
checking for RADEON... no
configure: error: Package requirements (libdrm >= 2.4.71 libdrm_radeon >= 2.4.71)

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Michał Kalbarczyk <michal@gamecodehq.com>
---
 package/mesa3d/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni April 28, 2018, 8:04 p.m. UTC | #1
Hello,

On Sat, 28 Apr 2018 19:28:01 +0200, Romain Naour wrote:
> Fixes:
> checking for EXPAT... yes
> checking for RADEON... no
> configure: error: Package requirements (libdrm >= 2.4.71 libdrm_radeon >= 2.4.71)
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Michał Kalbarczyk <michal@gamecodehq.com>
> ---
>  package/mesa3d/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index 1984e4f11c..32337a36a4 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -122,6 +122,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI
>  			BR2_TOOLCHAIN_USES_GLIBC)) # elfutils
>  	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
>  	select BR2_PACKAGE_LIBDRM_AMDGPU
> +	select BR2_PACKAGE_LIBDRM_RADEON

So it needs both libdrm_radeon and libdrm_amdgpu ?

Thomas
Romain Naour April 28, 2018, 8:13 p.m. UTC | #2
Hi Thomas,

Le 28/04/2018 à 22:04, Thomas Petazzoni a écrit :
> Hello,
> 
> On Sat, 28 Apr 2018 19:28:01 +0200, Romain Naour wrote:
>> Fixes:
>> checking for EXPAT... yes
>> checking for RADEON... no
>> configure: error: Package requirements (libdrm >= 2.4.71 libdrm_radeon >= 2.4.71)
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> Cc: Michał Kalbarczyk <michal@gamecodehq.com>
>> ---
>>  package/mesa3d/Config.in | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
>> index 1984e4f11c..32337a36a4 100644
>> --- a/package/mesa3d/Config.in
>> +++ b/package/mesa3d/Config.in
>> @@ -122,6 +122,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI
>>  			BR2_TOOLCHAIN_USES_GLIBC)) # elfutils
>>  	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
>>  	select BR2_PACKAGE_LIBDRM_AMDGPU
>> +	select BR2_PACKAGE_LIBDRM_RADEON
> 
> So it needs both libdrm_radeon and libdrm_amdgpu ?

Indeed, see [1]

xradeonsi)
  HAVE_GALLIUM_RADEONSI=yes
  PKG_CHECK_MODULES([RADEON], [libdrm >= $LIBDRM_RADEON_REQUIRED libdrm_radeon
>= $LIBDRM_RADEON_REQUIRED])
  PKG_CHECK_MODULES([AMDGPU], [libdrm >= $LIBDRM_AMDGPU_REQUIRED libdrm_amdgpu
>= $LIBDRM_AMDGPU_REQUIRED])
  require_libdrm "radeonsi"
  radeon_llvm_check $LLVM_REQUIRED_RADEONSI "radeonsi"
  if test "x$enable_egl" = xyes; then
  require_basic_egl "radeonsi"
  fi
;;

[1] https://github.com/mesa3d/mesa/blob/master/configure.ac#L2618

Best regards,
Romain

> 
> Thomas
>
diff mbox series

Patch

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 1984e4f11c..32337a36a4 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -122,6 +122,7 @@  config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI
 			BR2_TOOLCHAIN_USES_GLIBC)) # elfutils
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 	select BR2_PACKAGE_LIBDRM_AMDGPU
+	select BR2_PACKAGE_LIBDRM_RADEON
 	select BR2_PACKAGE_LLVM_AMDGPU if BR2_PACKAGE_MESA3D_LLVM
 	select BR2_PACKAGE_ELFUTILS if BR2_PACKAGE_MESA3D_LLVM
 	select BR2_PACKAGE_MESA3D_NEEDS_XA