diff mbox series

[3/3] package/brltty: depends on !BR2_STATIC_LIBS

Message ID 20171230104804.16489-3-mlang@blind.guru
State Accepted
Headers show
Series [1/3] package/brltty: add missing dependency on host-pkgconf | expand

Commit Message

Mario Lang Dec. 30, 2017, 10:48 a.m. UTC
This requirement is likely to go away in the future.  However, declaring
this fact explicitly for now fixes a number of test-pkg failures.

Signed-off-by: Mario Lang <mlang@blind.guru>
---
 package/brltty/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN Dec. 30, 2017, 1:08 p.m. UTC | #1
Mario, All,

On 2017-12-30 11:48 +0100, Mario Lang spake thusly:
> This requirement is likely to go away in the future.  However, declaring
> this fact explicitly for now fixes a number of test-pkg failures.
> 
> Signed-off-by: Mario Lang <mlang@blind.guru>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/brltty/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/brltty/Config.in b/package/brltty/Config.in
> index dfd2ff4428..288d9b56d8 100644
> --- a/package/brltty/Config.in
> +++ b/package/brltty/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_BRLTTY
>  	bool "brltty"
>  	depends on BR2_USE_WCHAR
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_STATIC_LIBS
>  	help
>  	  A daemon providing access to the Linux console for a blind
>  	  person using a refreshable braille display.
> @@ -15,5 +16,5 @@ config BR2_PACKAGE_BRLTTY_TEXT_TABLE
>  
>  endif
>  
> -comment "brltty needs a toolchain w/ threads, wchar"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
> +comment "brltty needs a toolchain w/ dynamic lib, threads, wchar"
> +	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
> -- 
> 2.15.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/brltty/Config.in b/package/brltty/Config.in
index dfd2ff4428..288d9b56d8 100644
--- a/package/brltty/Config.in
+++ b/package/brltty/Config.in
@@ -2,6 +2,7 @@  config BR2_PACKAGE_BRLTTY
 	bool "brltty"
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_STATIC_LIBS
 	help
 	  A daemon providing access to the Linux console for a blind
 	  person using a refreshable braille display.
@@ -15,5 +16,5 @@  config BR2_PACKAGE_BRLTTY_TEXT_TABLE
 
 endif
 
-comment "brltty needs a toolchain w/ threads, wchar"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
+comment "brltty needs a toolchain w/ dynamic lib, threads, wchar"
+	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR